From e78acb4fdfc2da51c9e99df66e57b84d21eafe2f Mon Sep 17 00:00:00 2001 From: Anton Leherbauer Date: Tue, 14 Jul 2015 16:29:21 +0200 Subject: [PATCH] Validate breakpoint string fields also on mouse clicks --- .../ui/breakpoints/CBreakpointPropertyPage.java | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/breakpoints/CBreakpointPropertyPage.java b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/breakpoints/CBreakpointPropertyPage.java index f943927ac47..95b39bc5088 100644 --- a/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/breakpoints/CBreakpointPropertyPage.java +++ b/debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/breakpoints/CBreakpointPropertyPage.java @@ -63,6 +63,8 @@ import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jface.window.Window; import org.eclipse.swt.SWT; +import org.eclipse.swt.events.MouseAdapter; +import org.eclipse.swt.events.MouseEvent; import org.eclipse.swt.events.SelectionAdapter; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; @@ -155,6 +157,19 @@ public class CBreakpointPropertyPage extends FieldEditorPreferencePage implement super( name, labelText, parent ); } + @Override + protected void doFillIntoGrid(Composite parent, int numColumns) { + super.doFillIntoGrid(parent, numColumns); + // also validate on mouse clicks, eg. middle-mouse-paste + Text textControl = getTextControl(); + textControl.addMouseListener(new MouseAdapter() { + @Override + public void mouseUp(MouseEvent e) { + valueChanged(); + } + }); + } + /** * @see StringFieldEditor#checkState() */ @@ -175,6 +190,7 @@ public class CBreakpointPropertyPage extends FieldEditorPreferencePage implement super.doStore(); } } + @Override protected void doLoad() { String value = getPreferenceStore().getString(getPreferenceName()); setStringValue(value); @@ -922,6 +938,7 @@ public class CBreakpointPropertyPage extends FieldEditorPreferencePage implement return null; } + @Override public IPreferenceStore getPreferenceStore() { IAdaptable element = getElement(); if (element instanceof ICBreakpointContext) {