mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-08 10:16:03 +02:00
Code Issues Wiki Activity

Bug 407579 - False ambiguity in template function resolution.

Browse source
This commit is contained in:
Sergey Prigogin 2013-05-08 20:31:36 -07:00
parent 77465f88fe
commit e7282ec04e
2 changed files with 40 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java
View file

@ -5178,6 +5178,20 @@ public class AST2TemplateTests extends AST2TestBase {
parseAndCheckBindings(); parseAndCheckBindings();
} }
// template <typename T, int N>
// char (&f(T (&a)[N]))[N];
//
// template <typename T, int N>
// char (&f(const T (&a)[N]))[N];
//
// const char c[] = "";
// int x = sizeof(f(c));
// int d[] = { 0 };
// int y = sizeof(f(d));
public void testOverloadResolution() throws Exception {
parseAndCheckBindings();
}
// template<typename ...T> void f(T..., T...); // template<typename ...T> void f(T..., T...);
// void test() { // void test() {
// f(1,1); // f(1,1);

30
core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPVisitor.java
View file

@ -95,6 +95,7 @@ import org.eclipse.cdt.core.dom.ast.IScope;
import org.eclipse.cdt.core.dom.ast.ISemanticProblem; import org.eclipse.cdt.core.dom.ast.ISemanticProblem;
import org.eclipse.cdt.core.dom.ast.IType; import org.eclipse.cdt.core.dom.ast.IType;
import org.eclipse.cdt.core.dom.ast.ITypedef; import org.eclipse.cdt.core.dom.ast.ITypedef;
import org.eclipse.cdt.core.dom.ast.IValue;
import org.eclipse.cdt.core.dom.ast.IVariable; import org.eclipse.cdt.core.dom.ast.IVariable;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTAliasDeclaration; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTAliasDeclaration;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTCatchHandler; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTCatchHandler;
@ -116,6 +117,7 @@ import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTInitializerClause;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTInitializerList; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTInitializerList;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTLambdaExpression; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTLambdaExpression;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTLinkageSpecification; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTLinkageSpecification;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTLiteralExpression;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTNamedTypeSpecifier; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTNamedTypeSpecifier;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTNamespaceAlias; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTNamespaceAlias;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTNamespaceDefinition; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTNamespaceDefinition;
@ -1924,11 +1926,31 @@ public class CPPVisitor extends ASTQueries {
return type.getModifiers() & (IBasicType.IS_SIGNED | IBasicType.IS_UNSIGNED); return type.getModifiers() & (IBasicType.IS_SIGNED | IBasicType.IS_UNSIGNED);
} }
private static IType getArrayTypes(IType type, IASTArrayDeclarator declarator) { private static IType getArrayType(IType type, IASTArrayDeclarator declarator) {
IASTArrayModifier[] mods = declarator.getArrayModifiers(); IASTArrayModifier[] mods = declarator.getArrayModifiers();
for (int i = mods.length - 1; i >= 0; i--) { for (int i = mods.length; --i >= 0;) {
IASTArrayModifier mod = mods[i]; IASTArrayModifier mod = mods[i];
type = new CPPArrayType(type, mod.getConstantExpression()); IASTExpression sizeExpression = mod.getConstantExpression();
if (sizeExpression != null) {
type = new CPPArrayType(type, sizeExpression);
} else {
IValue sizeValue = null;
IASTInitializer initializer = declarator.getInitializer();
if (initializer instanceof IASTEqualsInitializer) {
IASTInitializerClause clause = ((IASTEqualsInitializer) initializer).getInitializerClause();
if (clause instanceof IASTInitializerList) {
IASTInitializerClause[] clauses = ((IASTInitializerList) clause).getClauses();
sizeValue = Value.create(clauses.length);
} else if (clause instanceof ICPPASTLiteralExpression) {
ICPPEvaluation value = ((ICPPASTLiteralExpression) clause).getEvaluation();
IType valueType = value.getTypeOrFunctionSet(clause);
if (valueType instanceof IArrayType) {
sizeValue = ((IArrayType) valueType).getSize();
}
}
}
type = new CPPArrayType(type, sizeValue);
}
} }
return type; return type;
} }
@ -2177,7 +2199,7 @@ public class CPPVisitor extends ASTQueries {
type = applyAttributes(type, declarator); type = applyAttributes(type, declarator);
type = getPointerTypes(type, declarator); type = getPointerTypes(type, declarator);
if (declarator instanceof IASTArrayDeclarator) if (declarator instanceof IASTArrayDeclarator)
type = getArrayTypes(type, (IASTArrayDeclarator) declarator); type = getArrayType(type, (IASTArrayDeclarator) declarator);
IASTDeclarator nested = declarator.getNestedDeclarator(); IASTDeclarator nested = declarator.getNestedDeclarator();
if (nested != null) { if (nested != null) {