mirror of
https://github.com/eclipse-cdt/cdt
synced 2025-08-04 14:55:41 +02:00
Bug 240947
Missing done() calls in view model
This commit is contained in:
parent
9ac7056923
commit
e5930da951
4 changed files with 18 additions and 2 deletions
|
@ -268,7 +268,7 @@ public class StackFramesVMNode extends AbstractDMVMNode
|
||||||
update.setLabel("<...more frames...>", 0); //$NON-NLS-1$
|
update.setLabel("<...more frames...>", 0); //$NON-NLS-1$
|
||||||
update.setImageDescriptor(DebugUITools.getImageDescriptor(IDebugUIConstants.IMG_OBJS_STACKFRAME), 0);
|
update.setImageDescriptor(DebugUITools.getImageDescriptor(IDebugUIConstants.IMG_OBJS_STACKFRAME), 0);
|
||||||
update.done();
|
update.done();
|
||||||
return;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
final IFrameDMContext dmc = findDmcInPath(update.getViewerInput(), update.getElementPath(), IFrameDMContext.class);
|
final IFrameDMContext dmc = findDmcInPath(update.getViewerInput(), update.getElementPath(), IFrameDMContext.class);
|
||||||
|
@ -474,6 +474,8 @@ public class StackFramesVMNode extends AbstractDMVMNode
|
||||||
|| IDsfDebugUIConstants.PREF_STACK_FRAME_LIMIT.equals(property))
|
|| IDsfDebugUIConstants.PREF_STACK_FRAME_LIMIT.equals(property))
|
||||||
{
|
{
|
||||||
buildDeltaForStackFrameLimitPreferenceChangedEvent(parent, rm);
|
buildDeltaForStackFrameLimitPreferenceChangedEvent(parent, rm);
|
||||||
|
} else {
|
||||||
|
rm.done();
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
rm.done();
|
rm.done();
|
||||||
|
|
|
@ -66,6 +66,7 @@ public class ModulesVMNode extends AbstractDMVMNode
|
||||||
|
|
||||||
if (modulesService == null || symDmc == null) {
|
if (modulesService == null || symDmc == null) {
|
||||||
handleFailedUpdate(update);
|
handleFailedUpdate(update);
|
||||||
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
modulesService.getModules(
|
modulesService.getModules(
|
||||||
|
|
|
@ -430,11 +430,17 @@ public class RegisterVMNode extends AbstractExpressionVMNode
|
||||||
if ( ! weAreExtractingFormattedData ) {
|
if ( ! weAreExtractingFormattedData ) {
|
||||||
update.done();
|
update.done();
|
||||||
} else {
|
} else {
|
||||||
|
boolean found = false;
|
||||||
for (int idx = 0; idx < localColumns.length; idx++) {
|
for (int idx = 0; idx < localColumns.length; idx++) {
|
||||||
if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
|
if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
|
||||||
|
found = true;
|
||||||
updateFormattedRegisterValue(update, idx, dmc);
|
updateFormattedRegisterValue(update, idx, dmc);
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
if (!found) {
|
||||||
|
update.done();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|
|
@ -311,11 +311,16 @@ public class VariableVMNode extends AbstractExpressionVMNode
|
||||||
if ( ! weAreExtractingFormattedData ) {
|
if ( ! weAreExtractingFormattedData ) {
|
||||||
update.done();
|
update.done();
|
||||||
} else {
|
} else {
|
||||||
|
boolean found = false;
|
||||||
for (int idx = 0; idx < localColumns.length; idx++) {
|
for (int idx = 0; idx < localColumns.length; idx++) {
|
||||||
if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
|
if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
|
||||||
|
found = true;
|
||||||
updateFormattedExpressionValue(update, idx, dmc, getData());
|
updateFormattedExpressionValue(update, idx, dmc, getData());
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
update.setFontData(JFaceResources.getFontDescriptor(IInternalDebugUIConstants.VARIABLE_TEXT_FONT).getFontData()[0], idx);
|
}
|
||||||
|
if (!found) {
|
||||||
|
update.done();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -608,6 +613,8 @@ public class VariableVMNode extends AbstractExpressionVMNode
|
||||||
// DataRequestMonitor.handleCompleted() above.
|
// DataRequestMonitor.handleCompleted() above.
|
||||||
|
|
||||||
expressionService.getSubExpressions(expressionDMC, rm);
|
expressionService.getSubExpressions(expressionDMC, rm);
|
||||||
|
} else {
|
||||||
|
handleFailedUpdate(update);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Add table
Reference in a new issue