mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-03 22:35:43 +02:00
Code Issues Wiki Activity

Bug 240947

Browse source 
Missing done() calls in view model
This commit is contained in:
Marc Khouzam 2008-07-16 00:20:46 +00:00
parent 9ac7056923
commit e5930da951
4 changed files with 18 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
plugins/org.eclipse.dd.dsf.debug.ui/src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/launch/StackFramesVMNode.java
View file

@ -268,7 +268,7 @@ public class StackFramesVMNode extends AbstractDMVMNode
update.setLabel("<...more frames...>", 0); //$NON-NLS-1$
update.setImageDescriptor(DebugUITools.getImageDescriptor(IDebugUIConstants.IMG_OBJS_STACKFRAME), 0);
update.done();
return;
continue;
}
final IFrameDMContext dmc = findDmcInPath(update.getViewerInput(), update.getElementPath(), IFrameDMContext.class);
@ -474,6 +474,8 @@ public class StackFramesVMNode extends AbstractDMVMNode
|| IDsfDebugUIConstants.PREF_STACK_FRAME_LIMIT.equals(property))
{
buildDeltaForStackFrameLimitPreferenceChangedEvent(parent, rm);
} else {
rm.done();
}
} else {
rm.done();

1
plugins/org.eclipse.dd.dsf.debug.ui/src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/modules/ModulesVMNode.java
View file

@ -66,6 +66,7 @@ public class ModulesVMNode extends AbstractDMVMNode
if (modulesService == null || symDmc == null) {
handleFailedUpdate(update);
return;
}
modulesService.getModules(

6
plugins/org.eclipse.dd.dsf.debug.ui/src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/register/RegisterVMNode.java
View file

@ -430,11 +430,17 @@ public class RegisterVMNode extends AbstractExpressionVMNode
if ( ! weAreExtractingFormattedData ) {
update.done();
} else {
boolean found = false;
for (int idx = 0; idx < localColumns.length; idx++) {
if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
found = true;
updateFormattedRegisterValue(update, idx, dmc);
break;
}
}
if (!found) {
update.done();
}
}
}
},

9
plugins/org.eclipse.dd.dsf.debug.ui/src/org/eclipse/dd/dsf/debug/internal/provisional/ui/viewmodel/variable/VariableVMNode.java
View file

@ -311,11 +311,16 @@ public class VariableVMNode extends AbstractExpressionVMNode
if ( ! weAreExtractingFormattedData ) {
update.done();
} else {
boolean found = false;
for (int idx = 0; idx < localColumns.length; idx++) {
if (IDebugVMConstants.COLUMN_ID__VALUE.equals(localColumns[idx])) {
found = true;
updateFormattedExpressionValue(update, idx, dmc, getData());
break;
}
update.setFontData(JFaceResources.getFontDescriptor(IInternalDebugUIConstants.VARIABLE_TEXT_FONT).getFontData()[0], idx);
}
if (!found) {
update.done();
}
}
}
@ -608,6 +613,8 @@ public class VariableVMNode extends AbstractExpressionVMNode
// DataRequestMonitor.handleCompleted() above.
expressionService.getSubExpressions(expressionDMC, rm);
} else {
handleFailedUpdate(update);
}
}