From e451cbd6d26a80d685a834e967a44e907612a1ba Mon Sep 17 00:00:00 2001 From: David McKnight Date: Fri, 4 Apr 2008 18:49:16 +0000 Subject: [PATCH] [225507] @since and @noimplement --- .../eclipse/dstore/extra/IDomainNotifier.java | 27 ++++++++----- .../dstore/internal/extra/DomainNotifier.java | 38 ------------------- 2 files changed, 17 insertions(+), 48 deletions(-) diff --git a/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/extra/IDomainNotifier.java b/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/extra/IDomainNotifier.java index 5ee2b8254d3..be7c02b34a3 100644 --- a/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/extra/IDomainNotifier.java +++ b/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/extra/IDomainNotifier.java @@ -12,25 +12,32 @@ * Emily Bruner, Mazen Faraj, Adrian Storisteanu, Li Ding, and Kent Hawley. * * Contributors: - * {Name} (company) - description of contribution. + * David McKnight (IBM) - [225507][api][breaking] RSE dstore API leaks non-API types *******************************************************************************/ package org.eclipse.dstore.extra; - /** * For DataStore domain notification - * + * + * @noimplement This interface is not intended to be implemented by clients. */ -public interface IDomainNotifier -{ +public interface IDomainNotifier { + public void addDomainListener(IDomainListener listener); + public void fireDomainChanged(DomainEvent event); - public void addDomainListener(IDomainListener listener); - public void fireDomainChanged(DomainEvent event); - public boolean hasDomainListener(IDomainListener listener); - public void removeDomainListener(IDomainListener listener); - + public boolean hasDomainListener(IDomainListener listener); + + public void removeDomainListener(IDomainListener listener); + + /** + * @since 2.1 + */ public void enable(boolean on); + + /** + * @since 2.1 + */ public boolean isEnabled(); } diff --git a/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/internal/extra/DomainNotifier.java b/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/internal/extra/DomainNotifier.java index c799d65eb79..05885daf456 100644 --- a/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/internal/extra/DomainNotifier.java +++ b/rse/plugins/org.eclipse.dstore.extra/src/org/eclipse/dstore/internal/extra/DomainNotifier.java @@ -30,43 +30,7 @@ public class DomainNotifier implements IDomainNotifier private ArrayList _listeners; private boolean _enabled; - -/* - public class FireMainThread extends Job - { - public boolean _isWorking; - private DomainEvent _event; - - public FireMainThread(DomainEvent event) - { - super("DStore Events Fired"); - _isWorking = false; - _event = event; - setPriority(Job.INTERACTIVE); - } - - public IStatus run(IProgressMonitor monitor) - { - _isWorking = true; - - if (_event.getType() != DomainEvent.FILE_CHANGE) - { - for (int i = 0; i < _listeners.size(); i++) - { - IDomainListener listener = (IDomainListener) _listeners.get(i); - if ((listener != null) && listener.listeningTo(_event)) - { - listener.domainChanged(_event); - } - } - } - - _isWorking = false; - return Status.OK_STATUS; - } - } -*/ public DomainNotifier() { _listeners = new ArrayList(); @@ -106,8 +70,6 @@ public class DomainNotifier implements IDomainNotifier listener.domainChanged(event); } } - //FireMainThread fireJob = new FireMainThread(event); - //fireJob.schedule(); } }