From e3a5acb7612417e8b342e0f2b7f7e62e51499a60 Mon Sep 17 00:00:00 2001 From: Alvaro Sanchez-Leon Date: Wed, 16 Mar 2016 15:35:01 -0400 Subject: [PATCH] minor fix, replace == for .equals Change-Id: I26f949b64d1d5da0f410c76379d51f7edfcf9474 --- .../cdt/internal/autotools/ui/text/hover/AutoconfTextHover.java | 2 +- .../cdt/managedbuilder/makegen/gnu/GnuMakefileGenerator.java | 2 +- .../cdt/managedbuilder/makegen/gnu/ManagedBuildGnuToolInfo.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/text/hover/AutoconfTextHover.java b/build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/text/hover/AutoconfTextHover.java index d1d9b7f345f..338c6ded8ba 100644 --- a/build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/text/hover/AutoconfTextHover.java +++ b/build/org.eclipse.cdt.autotools.ui/src/org/eclipse/cdt/internal/autotools/ui/text/hover/AutoconfTextHover.java @@ -374,7 +374,7 @@ public class AutoconfTextHover implements ITextHover, ITextHoverExtension { int parmCount = 0; for (int k = 0; k < parmList.getLength(); ++k) { Node n3 = parmList.item(k); - if (n3.getNodeName() == "parameter") { //$NON-NLS-1$ + if (n3.getNodeName().equals("parameter")) { //$NON-NLS-1$ NamedNodeMap parmVals = n3.getAttributes(); Node parmVal = parmVals.item(0); if (parmCount > 0) diff --git a/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/GnuMakefileGenerator.java b/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/GnuMakefileGenerator.java index 7128d6408a0..8646c2dbb47 100644 --- a/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/GnuMakefileGenerator.java +++ b/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/GnuMakefileGenerator.java @@ -4370,7 +4370,7 @@ public class GnuMakefileGenerator implements IManagedBuilderMakefileGenerator2 { rcInfo = config.getResourceInfo(folderPath.removeLastSegments(1), false); } String targetExtension = ((IFolderInfo)rcInfo).getOutputExtension(srcExtension); - if (targetExtension != "") //$NON-NLS-1$ + if (!targetExtension.equals("")) //$NON-NLS-1$ fileName += DOT + targetExtension; IPath projectRelativePath = deletedFile.getProjectRelativePath().removeLastSegments(1); IPath targetFilePath = getBuildWorkingDir().append(projectRelativePath).append(fileName); diff --git a/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/ManagedBuildGnuToolInfo.java b/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/ManagedBuildGnuToolInfo.java index 3da95914456..e8dbd2bf75e 100644 --- a/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/ManagedBuildGnuToolInfo.java +++ b/build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/makegen/gnu/ManagedBuildGnuToolInfo.java @@ -1013,7 +1013,7 @@ public class ManagedBuildGnuToolInfo implements IManagedBuildGnuToolInfo { if (outExtensionName != null) { OptDotExt = DOT + outExtensionName; } else - if (tool.getOutputExtension(srcExtensionName) != "") //$NON-NLS-1$ + if (!tool.getOutputExtension(srcExtensionName).equals("")) //$NON-NLS-1$ OptDotExt = DOT + tool.getOutputExtension(srcExtensionName); // create rule of the form