mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-05 23:35:48 +02:00
Code Issues Wiki Activity

[342095] Properties in Properties view remain "Pending..." in some cases

Browse source
This commit is contained in:
David McKnight 2011-06-08 16:36:04 +00:00
parent 5b6e61db56
commit e37806d927
1 changed files with 32 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemView.java
View file

@ -79,6 +79,7 @@
* David McKnight (IBM) - [333196] New member filter dialogue keep popping up when creating a shared member filter. * David McKnight (IBM) - [333196] New member filter dialogue keep popping up when creating a shared member filter.
* David McKnight (IBM) - [341281] amendment to fix for bug 308983 * David McKnight (IBM) - [341281] amendment to fix for bug 308983
* David McKnight (IBM) - [342208] potential NPE in SystemView$ExpandRemoteObjects.execute() * David McKnight (IBM) - [342208] potential NPE in SystemView$ExpandRemoteObjects.execute()
* David McKnight (IBM) - [342095] Properties in Properties view remain "Pending..." in some cases
********************************************************************************/ ********************************************************************************/
package org.eclipse.rse.internal.ui.view; package org.eclipse.rse.internal.ui.view;
@ -221,6 +222,7 @@ import org.eclipse.swt.widgets.Tree;
import org.eclipse.swt.widgets.TreeItem; import org.eclipse.swt.widgets.TreeItem;
import org.eclipse.swt.widgets.Widget; import org.eclipse.swt.widgets.Widget;
import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbench;
import org.eclipse.ui.IWorkbenchPage;
import org.eclipse.ui.IWorkbenchPart; import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.IWorkbenchWindow;
import org.eclipse.ui.PlatformUI; import org.eclipse.ui.PlatformUI;
@ -5963,22 +5965,38 @@ public class SystemView extends SafeTreeViewer
// only fire this event if the view actually has focus // only fire this event if the view actually has focus
if (force || getControl().isFocusControl()) if (force || getControl().isFocusControl())
{ {
IStructuredSelection fakeSelection = null; Object object = ((IStructuredSelection)selection).getFirstElement();
// create events in order to update the property sheet if (object != null){
if (selection instanceof IStructuredSelection){ IWorkbenchPart ourPart = getWorkbenchPart();
fakeSelection = new StructuredSelection(new Object()); IWorkbenchPart activePart = getWorkbenchWindow().getActivePage().getActivePart();
if (activePart != ourPart){
ourPart.setFocus(); // without part focus, there are no post selection change listeners
}
IStructuredSelection fakeSelection = null;
// create events in order to update the property sheet
if (selection instanceof IStructuredSelection){
fakeSelection = new StructuredSelection(new Object());
}
if (fakeSelection != null){
SelectionChangedEvent dummyEvent = new SelectionChangedEvent(this, fakeSelection);
// first change the selection, then change it back (otherwise the property sheet ignores the event)
fireSelectionChanged(dummyEvent);
firePostSelectionChanged(dummyEvent);
}
SelectionChangedEvent event = new SelectionChangedEvent(this, selection);
// fire the event
fireSelectionChanged(event);
firePostSelectionChanged(event);
if (ourPart != activePart){
activePart.setFocus();
}
} }
if (fakeSelection != null){
SelectionChangedEvent dummyEvent = new SelectionChangedEvent(this, fakeSelection);
// first change the selection, then change it back (otherwise the property sheet ignores the event)
fireSelectionChanged(dummyEvent);
}
SelectionChangedEvent event = new SelectionChangedEvent(this, selection);
// fire the event
fireSelectionChanged(event);
} }
} }