mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-23 14:42:11 +02:00
Code Issues Wiki Activity

Ranking of derived to base conversion, bug 269318

Browse source
This commit is contained in:
Markus Schorn 2009-04-20 12:32:37 +00:00
parent c7b512cbdf
commit e2f1c90b0b
2 changed files with 45 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2CPPTests.java
View file

@ -7130,4 +7130,33 @@ public class AST2CPPTests extends AST2BaseTest {
IScope scope= t.getScope();
assertEquals(EScopeKind.eGlobal, scope.getKind());
}
// class C {};
// class D : public C {};
// class E {
// public: E(D) {}
// };
// void test(C c) {}
// void test(E e) {}
//
// void xx() {
// D d1;
// const D d2= D();
// test(d1); // problem binding here although test(C c) has to be selected
// test(d2); // problem binding here although test(C c) has to be selected
// }
public void testDerivedToBaseConversion_269318() throws Exception {
final String code = getAboveComment();
BindingAssertionHelper ba= new BindingAssertionHelper(code, true);
ICPPFunction t= ba.assertNonProblem("test(d1);", 4, ICPPFunction.class);
ICPPClassType ct= (ICPPClassType) t.getParameters()[0].getType();
assertEquals("C", ct.getName());
t= ba.assertNonProblem("test(d2);", 4, ICPPFunction.class);
ct= (ICPPClassType) t.getParameters()[0].getType();
assertEquals("C", ct.getName());
parseAndCheckBindings(code, ParserLanguage.CPP);
}
}

35
core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/Conversions.java
View file

@ -162,6 +162,22 @@ public class Conversions {
}
// Non-reference binding
// [13.3.3.1-6] Subsume cv-qualifications
source= getNestedType(source, TDEF | REF | CVQ | PTR_CVQ);
target= getNestedType(target, TDEF | REF | CVQ | PTR_CVQ);
// [13.3.3.1-6] Derived to base conversion
if (source instanceof ICPPClassType && target instanceof ICPPClassType) {
int depth= calculateInheritanceDepth(CPPSemantics.MAX_INHERITANCE_DEPTH, source, target);
if (depth > -1) {
if (depth == 0) {
return new Cost(source, target, Rank.IDENTITY);
}
Cost cost= new Cost(source, target, Rank.CONVERSION);
cost.setInheritanceDistance(depth);
return cost;
}
}
return nonReferenceConversion(source, target, udc, isImpliedObject);
}
@ -799,23 +815,4 @@ public class Conversions {
return true;
}
// mstodo must be part of implicit conversion
// /**
// * [13.3.3.1-6] Derived to base conversion
// * @param cost
// * @throws DOMException
// */
// private static final void derivedToBaseConversion(Cost cost) throws DOMException {
// IType s = getUltimateType(cost.source, true);
// IType t = getUltimateType(cost.target, true);
//
// if (s instanceof ICPPClassType && t instanceof ICPPClassType) {
// int depth= calculateInheritanceDepth(CPPSemantics.MAX_INHERITANCE_DEPTH, s, t);
// if (depth > -1) {
// cost.rank = Cost.DERIVED_TO_BASE_CONVERSION;
// cost.conversion = depth;
// }
// }
// }
}