mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-23 17:05:26 +02:00
Code Issues Wiki Activity

Shouldn't use new SWT.Shell()

Browse source 
I noticed that one case in the template engine is creating a dialog that
uses it's own instance of SWT Shell (i.e., the code contains "new
Shell()".

This patch modifies that case to use the display's active shell instead.

Change-Id: I253d6540899ce4dfef033924e27e2ddcd62ded19
Signed-off-by: Andrew Eidsness <eclipse@jfront.com>
Reviewed-on: https://git.eclipse.org/r/27278
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
This commit is contained in:
Andrew Eidsness 2014-05-26 06:55:16 -04:00 • committed by Doug Schaefer
parent 251d54056e
commit e0682a2412
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
core/org.eclipse.cdt.ui/templateengine/org/eclipse/cdt/ui/templateengine/pages/TemplateInputDialog.java
View file

@ -274,12 +274,17 @@ public class TemplateInputDialog extends Dialog {
public int popDuplicate() {
MessageBox mBox = new MessageBox(new Shell(), SWT.ICON_INFORMATION);
mBox.setText(TemplatePreferencePage.Message);
mBox.setMessage(TemplatePreferencePage.DuplicateEntry);
int result = mBox.open();
return result;
final int[] result = new int[]{ 0 };
Display.getDefault().syncExec(new Runnable() {
@Override
public void run() {
MessageBox mBox = new MessageBox(Display.getCurrent().getActiveShell(), SWT.ICON_INFORMATION);
mBox.setText(TemplatePreferencePage.Message);
mBox.setMessage(TemplatePreferencePage.DuplicateEntry);
result[0] = mBox.open();
}
});
return result[0];
}
/*