mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Bug 379490 - [Implement method] NPE when a method needing a parameter

Browse source 
input is not selected
This commit is contained in:
Marc-Andre Laperle 2012-05-15 12:46:28 -04:00
parent 20be45ecfa
commit e02293b2fe
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/implementmethod/ParameterNamesInputPage.java
View file

@ -1,5 +1,5 @@
/******************************************************************************* /*******************************************************************************
* Copyright (c) 2008, 2011 Institute for Software, HSR Hochschule fuer Technik * Copyright (c) 2008, 2012 Institute for Software, HSR Hochschule fuer Technik
* Rapperswil, University of applied sciences and others * Rapperswil, University of applied sciences and others
* All rights reserved. This program and the accompanying materials * All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0 * are made available under the terms of the Eclipse Public License v1.0
@ -197,7 +197,14 @@ public class ParameterNamesInputPage extends UserInputWizardPage {
} }
} }
/**
* @return true if the preview job could still be running, false otherwise
*/
protected boolean cancelPreviewJob() { protected boolean cancelPreviewJob() {
if (delayedPreviewUpdater == null) {
return false;
}
// We cannot rely on getState being accurate in all cases so we only use this // We cannot rely on getState being accurate in all cases so we only use this
// as a hint to change the preview text // as a hint to change the preview text
if (delayedPreviewUpdater.getState() != Job.NONE) { if (delayedPreviewUpdater.getState() != Job.NONE) {
@ -207,6 +214,10 @@ public class ParameterNamesInputPage extends UserInputWizardPage {
} }
protected void joinPreviewJob() { protected void joinPreviewJob() {
if (delayedPreviewUpdater == null) {
return;
}
try { try {
delayedPreviewUpdater.join(); delayedPreviewUpdater.join();
} catch (InterruptedException e1) { } catch (InterruptedException e1) {