diff --git a/core/org.eclipse.cdt.core/ChangeLog b/core/org.eclipse.cdt.core/ChangeLog index e0cd84232b7..82e8def659c 100644 --- a/core/org.eclipse.cdt.core/ChangeLog +++ b/core/org.eclipse.cdt.core/ChangeLog @@ -1,3 +1,7 @@ +2004-12-09 Alain Magloire + Fix for 80724: not showing initialized global variables. + * utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java + 2004-12-10 David Inglis Fixed bug #80713 diff --git a/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java b/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java index 55ebb4e7504..891f6402ac4 100644 --- a/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java +++ b/core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/coff/parser/CygwinPEBinaryObject.java @@ -15,6 +15,7 @@ import java.util.ArrayList; import java.util.Arrays; import java.util.List; +import org.eclipse.cdt.core.CConventions; import org.eclipse.cdt.core.IAddress; import org.eclipse.cdt.core.IBinaryParser; import org.eclipse.cdt.core.IBinaryParser.ISymbol; @@ -191,6 +192,10 @@ public class CygwinPEBinaryObject extends PEBinaryObject { for (int i = 0; i < pairs.length; ++i) { addSymbol(pairs[i], list, ISymbol.VARIABLE); } + pairs = nm.getDataSymbols(); + for (int i = 0; i < pairs.length; ++i) { + addSymbol(pairs[i], list, ISymbol.VARIABLE); + } } // pairs = nm.getTextSymbols(); // for (int i = 0; i < pairs.length; ++i) { @@ -216,7 +221,7 @@ public class CygwinPEBinaryObject extends PEBinaryObject { private void addSymbol(NM.AddressNamePair p, List list, int type) { String name = p.name; - if (name != null && name.length() > 0 && Character.isJavaIdentifierStart(name.charAt(0))) { + if (name != null && name.length() > 0 && CConventions.isValidIdentifier(name)) { IAddress addr = new Addr32(p.address); int size = 4; if (symbolLoadingCPPFilt != null) {