From d89fe5b50d3bf3093f1082595face820288316fb Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Mon, 29 Sep 2008 14:10:55 +0000 Subject: [PATCH] [248942] The .gdbinit box in the launch has a warning following it. The non-stop checkbox was added in between the .gdbinit box and its corresponding warning. Instead, the warning should remain right under its box. --- .../ui/launching/GdbDebuggerPage.java | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/plugins/org.eclipse.dd.gdb.ui/src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java b/plugins/org.eclipse.dd.gdb.ui/src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java index 16a7bc83e79..1fb79a0717c 100644 --- a/plugins/org.eclipse.dd.gdb.ui/src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java +++ b/plugins/org.eclipse.dd.gdb.ui/src/org/eclipse/dd/gdb/internal/ui/launching/GdbDebuggerPage.java @@ -259,18 +259,6 @@ public class GdbDebuggerPage extends AbstractCDebuggerPage implements Observer { } }); - // TODO: Fetch the string from LaunchUIMessages - // TODO: Ideally, this field should be disabled if the back-end doesn't support non-stop debugging - // TODO: Find a way to determine if non-stop is supported (i.e. find the GDB version) then grey out the check box if necessary - // Button fNonStopButton = ControlFactory.createCheckBox(subComp, LaunchUIMessages.getString( "GDBDebuggerPage.15") ); //$NON-NLS-1$ - fNonStopCheckBox = ControlFactory.createCheckBox(subComp, LaunchUIMessages.getString("GDBDebuggerPage.13")); //$NON-NLS-1$ - fNonStopCheckBox.addSelectionListener( new SelectionAdapter() { - @Override - public void widgetSelected(SelectionEvent e) { - updateLaunchConfigurationDialog(); - } - }); - label = ControlFactory.createLabel(subComp, LaunchUIMessages.getString("GDBDebuggerPage.9"), //$NON-NLS-1$ 200, SWT.DEFAULT, SWT.WRAP); @@ -278,6 +266,16 @@ public class GdbDebuggerPage extends AbstractCDebuggerPage implements Observer { gd.horizontalSpan = 3; gd.widthHint = 200; label.setLayoutData(gd); + + // TODO: Ideally, this field should be disabled if the back-end doesn't support non-stop debugging + // TODO: Find a way to determine if non-stop is supported (i.e. find the GDB version) then grey out the check box if necessary + fNonStopCheckBox = ControlFactory.createCheckBox(subComp, LaunchUIMessages.getString("GDBDebuggerPage.13")); //$NON-NLS-1$ + fNonStopCheckBox.addSelectionListener( new SelectionAdapter() { + @Override + public void widgetSelected(SelectionEvent e) { + updateLaunchConfigurationDialog(); + } + }); } public void createSolibTab(TabFolder tabFolder) {