From d8460fa23bc2807984def0f68d4468260a9b097c Mon Sep 17 00:00:00 2001 From: Sergey Prigogin Date: Wed, 1 Aug 2012 19:15:48 -0700 Subject: [PATCH] Bug 299911. Removed redundant name lookup. --- .../core/dom/parser/cpp/semantics/EvalID.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalID.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalID.java index 206047da2f3..da50a23c01e 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalID.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/EvalID.java @@ -128,16 +128,16 @@ public class EvalID extends CPPEvaluation { @Override public IValue getValue(IASTNode point) { - IBinding nameOwner = fNameOwner; - if (nameOwner == null && fFieldOwner != null) - nameOwner = (IBinding) fFieldOwner.getTypeOrFunctionSet(point); - - // TODO(sprigogin): Verify that name resolution is required here. - if (nameOwner instanceof ICPPClassType) { - ICPPEvaluation eval = resolveName((ICPPClassType) nameOwner, fTemplateArgs, point); - if (eval != null) - return eval.getValue(point); - } + // Name lookup is not needed here because it was already done in "instantiate" method. +// IBinding nameOwner = fNameOwner; +// if (nameOwner == null && fFieldOwner != null) +// nameOwner = (IBinding) fFieldOwner.getTypeOrFunctionSet(point); +// +// if (nameOwner instanceof ICPPClassType) { +// ICPPEvaluation eval = resolveName((ICPPClassType) nameOwner, fTemplateArgs, point); +// if (eval != null) +// return eval.getValue(point); +// } return Value.create(this); }