From d6c7ba4fade4ae00920554d420f3ada50f22719e Mon Sep 17 00:00:00 2001 From: Kushal Munir < kmunir@ca.ibm.com> Date: Thu, 19 Apr 2007 05:41:19 +0000 Subject: [PATCH] [179939] BIDI3.3: HCG Text files written in ASCII Hebrew do not look correctly. Do not download to UTF-8 encoding unnecessarily. Just download to the encoding that is specified for the remote file. If an encoding is not explicitly specified, then download in the platform defalt encoding. Optimize dstore to download in the binary mode since encoding is no longer UTF-8. --- .../internal/services/dstore/files/DStoreFileService.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/internal/services/dstore/files/DStoreFileService.java b/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/internal/services/dstore/files/DStoreFileService.java index 692a2d9af27..df99137161b 100644 --- a/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/internal/services/dstore/files/DStoreFileService.java +++ b/rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/internal/services/dstore/files/DStoreFileService.java @@ -579,7 +579,7 @@ public class DStoreFileService extends AbstractDStoreService implements IFileSer return false; } - int mode; +/* int mode; if (isBinary) { @@ -588,8 +588,12 @@ public class DStoreFileService extends AbstractDStoreService implements IFileSer else { mode = IUniversalDataStoreConstants.TEXT_MODE; - } + }*/ + // just download as binary since we do not have to convert to UTF-8 anyway + // the miner does a binary download anyway + int mode = IUniversalDataStoreConstants.BINARY_MODE; + DataStore ds = getDataStore(); String remotePath = remoteParent + getSeparator(remoteParent) + remoteFile;