From cebba80b3662a67b8cdba45f8b510d71aa278e23 Mon Sep 17 00:00:00 2001 From: Marc-Andre Laperle Date: Tue, 13 Oct 2020 01:13:06 -0400 Subject: [PATCH] Bug 567822 - [Dark Theme] Several controls using ControlFactory have wrong background (preferences, dialogs) I don't think "inheriting" by hand the background colors is supposed to be done like this. Removing the lines setting the background to be the same as the parent fixes the issue. I also verified all places in the UI before/after the change. Change-Id: I2eb4cc5afdd303d5d5613fc3d50d67d0c18c7028 Signed-off-by: Marc-Andre Laperle --- .../org/eclipse/cdt/utils/ui/controls/ControlFactory.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/core/org.eclipse.cdt.ui/utils.ui/org/eclipse/cdt/utils/ui/controls/ControlFactory.java b/core/org.eclipse.cdt.ui/utils.ui/org/eclipse/cdt/utils/ui/controls/ControlFactory.java index 0870906a18f..7a0e3bbd770 100644 --- a/core/org.eclipse.cdt.ui/utils.ui/org/eclipse/cdt/utils/ui/controls/ControlFactory.java +++ b/core/org.eclipse.cdt.ui/utils.ui/org/eclipse/cdt/utils/ui/controls/ControlFactory.java @@ -277,7 +277,6 @@ public class ControlFactory { button.setText(label); GridData data = new GridData(); button.setLayoutData(data); - button.setBackground(group.getBackground()); button.setForeground(group.getForeground()); return button; } @@ -296,7 +295,6 @@ public class ControlFactory { button.setText(label); GridData data = new GridData(); button.setLayoutData(data); - button.setBackground(group.getBackground()); button.setForeground(group.getForeground()); return button; }