From cc01f2d474de3692d504f29e4e17ee708ad2c443 Mon Sep 17 00:00:00 2001 From: Javier Montalvo Orus Date: Mon, 4 Dec 2006 18:47:44 +0000 Subject: [PATCH] [cleanup] fix compiler warnings --- .../org/eclipse/rse/discovery/Activator.java | 4 +- .../rse/discovery/ServiceDiscoveryWizard.java | 41 +++++++++++-------- .../tm/discovery/engine/Activator.java | 4 +- .../model/provider/DeviceItemProvider.java | 14 +++---- .../model/provider/NetworkItemProvider.java | 6 +-- .../model/provider/PairItemProvider.java | 10 ++--- .../model/provider/ServiceItemProvider.java | 6 +-- .../provider/ServiceTypeItemProvider.java | 8 ++-- .../discovery/protocol/dnssd/Activator.java | 4 +- .../tm/discovery/transport/udp/Activator.java | 4 +- .../eclipse/tm/discovery/view/Activator.java | 4 +- .../tm/discovery/wizard/Activator.java | 4 +- .../ServiceDiscoveryWizardDisplayPage.java | 8 ++-- 13 files changed, 61 insertions(+), 56 deletions(-) diff --git a/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/Activator.java b/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/Activator.java index f5f7c1bca90..1ca27175ad1 100644 --- a/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/Activator.java +++ b/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/Activator.java @@ -5,7 +5,7 @@ * available at http://www.eclipse.org/legal/epl-v10.html * * Contributors: - * Javier Montalvo Orús (Symbian) - initial API and implementation + * Javier Montalvo Orus (Symbian) - initial API and implementation ********************************************************************************/ package org.eclipse.rse.discovery; @@ -19,7 +19,7 @@ import org.osgi.framework.BundleContext; public class Activator extends AbstractUIPlugin { // The plug-in ID - public static final String PLUGIN_ID = "org.eclipse.rse.discovery"; + public static final String PLUGIN_ID = "org.eclipse.rse.discovery"; //$NON-NLS-1$ // The shared instance private static Activator plugin; diff --git a/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/ServiceDiscoveryWizard.java b/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/ServiceDiscoveryWizard.java index 26216aee8ad..0db6121eaea 100644 --- a/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/ServiceDiscoveryWizard.java +++ b/discovery/org.eclipse.rse.discovery/src/org/eclipse/rse/discovery/ServiceDiscoveryWizard.java @@ -5,7 +5,7 @@ * available at http://www.eclipse.org/legal/epl-v10.html * * Contributors: - * Javier Montalvo Orús (Symbian) - initial API and implementation + * Javier Montalvo Orus (Symbian) - initial API and implementation ********************************************************************************/ package org.eclipse.rse.discovery; @@ -22,6 +22,7 @@ import org.eclipse.jface.wizard.IWizardPage; import org.eclipse.jface.wizard.Wizard; import org.eclipse.rse.core.model.IHost; import org.eclipse.rse.core.model.IPropertySet; +import org.eclipse.rse.core.subsystems.IConnectorService; import org.eclipse.rse.ui.RSEUIPlugin; import org.eclipse.rse.ui.actions.SystemRefreshAllAction; import org.eclipse.tm.discovery.model.Pair; @@ -96,21 +97,34 @@ public class ServiceDiscoveryWizard extends Wizard { String sysTypeString = ((ServiceType) service.eContainer()).getName(); try { - conn = RSEUIPlugin.getDefault().getSystemRegistry().createHost(sysTypeString, service.getName() + "@" + hostName, hostName, "Discovered "+sysTypeString+" server in "+hostName); //$NON-NLS-1$ //$NON-NLS-2$ + conn = RSEUIPlugin.getDefault().getSystemRegistry().createHost(sysTypeString, service.getName() + "@" + hostName, hostName, "Discovered "+sysTypeString+" server in "+hostName); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ if (conn != null) { - //copy discovered properties to RSE model - IPropertySet ps = conn.getConnectorServices()[0].createPropertySet(Messages.ServiceDiscoveryWizard_DiscoveryPropertySet); + //copy discovered properties to RSE models + Iterator pairIterator = service.getPair().iterator(); + IConnectorService[] services = conn.getConnectorServices(); + IPropertySet ps; + while (pairIterator.hasNext()) { + Pair pair = (Pair) pairIterator.next(); - ps.addProperty(pair.getKey(), pair.getValue()); - - //add port to the RSE connection - if (pair.getKey().equalsIgnoreCase(Messages.ServiceDiscoveryWizard_Port)) { - conn.getConnectorServices()[0].setPort(Integer.parseInt(pair.getValue())); + + for(int j=0; j