mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Bug 229288

Browse source 
when using GDB6.6, if the solib-search-path is used, the launch will fail because the -gdb-set sysroot command will fail.  The concept of sysroot seems to have been introduced with GDB 6.7

Let's comment it out since it was used only as a safeguard.
This commit is contained in:
Marc Khouzam 2008-07-30 14:54:21 +00:00
parent d6faf244f9
commit c928924a21
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
plugins/org.eclipse.dd.gdb/src/org/eclipse/dd/gdb/internal/provisional/launching/FinalLaunchSequence.java
View file

@ -49,7 +49,6 @@ import org.eclipse.dd.mi.service.command.commands.MIGDBSetArgs;
import org.eclipse.dd.mi.service.command.commands.MIGDBSetAutoSolib;
import org.eclipse.dd.mi.service.command.commands.MIGDBSetNonStop;
import org.eclipse.dd.mi.service.command.commands.MIGDBSetSolibSearchPath;
import org.eclipse.dd.mi.service.command.commands.MIGDBSetSysroot;
import org.eclipse.dd.mi.service.command.commands.MITargetSelect;
import org.eclipse.dd.mi.service.command.commands.RawCommand;
import org.eclipse.dd.mi.service.command.output.MIInfo;
@ -282,13 +281,16 @@ public class FinalLaunchSequence extends Sequence {
new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor) {
@Override
protected void handleSuccess() {
// If we are able to set the solib-search-path,
// we should disable the sysroot variable, as indicated
// in the GDB documentation. This is to avoid the sysroot
// variable finding libraries that were not meant to be found.
fCommandControl.queueCommand(
new MIGDBSetSysroot(fCommandControl.getControlDMContext()),
new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor));
// Sysroot is not available in GDB6.6 and will make the launch fail in that case.
// Let's remove it for now
requestMonitor.done();
// // If we are able to set the solib-search-path,
// // we should disable the sysroot variable, as indicated
// // in the GDB documentation. This is to avoid the sysroot
// // variable finding libraries that were not meant to be found.
// fCommandControl.queueCommand(
// new MIGDBSetSysroot(fCommandControl.getControlDMContext()),
// new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor));
};
});
} else {