Fix vararg warning with 4.13.

While touching the class:
* convert to lambda
* foreach conversion
* remove useless non-javadoc comments.

Change-Id: I3419be135c68829bb98827683bc8fe47c1e2940e

core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/util/RemoteTreeViewer.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2015 IBM Corporation and others.
+ * Copyright (c) 2000, 2019 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -25,8 +25,6 @@ import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.jface.viewers.IStructuredSelection;
-import org.eclipse.swt.events.DisposeEvent;
-import org.eclipse.swt.events.DisposeListener;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Item;
 import org.eclipse.swt.widgets.Tree;
@@ -54,9 +52,6 @@ public class RemoteTreeViewer extends ProblemTreeViewer {
 			setSystem(true);
 		}
 
-		/* (non-Javadoc)
-		 * @see org.eclipse.ui.progress.UIJob#runInUIThread(org.eclipse.core.runtime.IProgressMonitor)
-		 */
 		@Override
 		public IStatus runInUIThread(IProgressMonitor monitor) {
 			if (getControl().isDisposed() || element == null) {
@@ -123,9 +118,6 @@ public class RemoteTreeViewer extends ProblemTreeViewer {
 			setSystem(true);
 		}
 
-		/* (non-Javadoc)
-		 * @see org.eclipse.ui.progress.UIJob#runInUIThread(org.eclipse.core.runtime.IProgressMonitor)
-		 */
 		@Override
 		public IStatus runInUIThread(IProgressMonitor monitor) {
 			if (getControl().isDisposed() || selection == null) {
@@ -214,12 +206,7 @@ public class RemoteTreeViewer extends ProblemTreeViewer {
 	}
 
 	private void addDisposeListener() {
-		getControl().addDisposeListener(new DisposeListener() {
+		getControl().addDisposeListener(e -> cancelJobs());
-			@Override
-			public void widgetDisposed(DisposeEvent e) {
-				cancelJobs();
-			}
-		});
 	}
 
 	protected void runDeferredUpdates() {
@@ -248,40 +235,28 @@ public class RemoteTreeViewer extends ProblemTreeViewer {
 		}
 	}
 
-	/* (non-Javadoc)
-	 * @see org.eclipse.jface.viewers.AbstractTreeViewer#add(java.lang.Object, java.lang.Object)
-	 */
 	@Override
 	public synchronized void add(Object parentElement, Object childElement) {
 		super.add(parentElement, childElement);
 		runDeferredUpdates();
 	}
 
-	/* (non-Javadoc)
-	 * @see org.eclipse.jface.viewers.AbstractTreeViewer#add(java.lang.Object, java.lang.Object[])
-	 */
 	@Override
-	public synchronized void add(Object parentElement, Object[] childElements) {
+	public synchronized void add(Object parentElement, Object... childElements) {
 		super.add(parentElement, childElements);
 		runDeferredUpdates();
 	}
 
-	/* (non-Javadoc)
-	 * @see org.eclipse.jface.viewers.AbstractTreeViewer#remove(java.lang.Object)
-	 */
 	@Override
 	public synchronized void remove(Object element) {
 		validateDeferredUpdates(element);
 		super.remove(element);
 	}
 
-	/* (non-Javadoc)
-	 * @see org.eclipse.jface.viewers.AbstractTreeViewer#remove(java.lang.Object[])
-	 */
 	@Override
-	public synchronized void remove(Object[] elements) {
+	public synchronized void remove(Object... elements) {
-		for (int i = 0; i < elements.length; i++) {
+		for (Object element : elements) {
-			validateDeferredUpdates(elements[i]);
+			validateDeferredUpdates(element);
 		}
 		super.remove(elements);
 	}
@@ -371,25 +346,20 @@ public class RemoteTreeViewer extends ProblemTreeViewer {
 		if (widget != null) {
 			final Item[] currentChildren = getChildren(widget);
 			if (offset < currentChildren.length) {
-				preservingSelection(new Runnable() {
+				preservingSelection(() -> {
-					@Override
-					public void run() {
 					for (int i = offset; i < currentChildren.length; i++) {
 						if (currentChildren[i].getData() != null) {
 							disassociate(currentChildren[i]);
 						}
 						currentChildren[i].dispose();
 					}
-					}
 				});
 			}
 		}
 	}
 
 	public synchronized void replace(final Object parent, final Object[] children, final int offset) {
-		preservingSelection(new Runnable() {
+		preservingSelection(() -> {
-			@Override
-			public void run() {
 			Widget widget = findItem(parent);
 			if (widget == null) {
 				add(parent, children);
@@ -432,7 +402,6 @@ public class RemoteTreeViewer extends ProblemTreeViewer {
 				}
 			}
 			runDeferredUpdates();
-			}
 		});
 	}