mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-09-08 11:03:28 +02:00
Code Issues Wiki Activity

Fix potential synchronization issue in Spawner

Browse source
This commit is contained in:
Anton Leherbauer 2014-02-04 16:55:57 +01:00
parent 8dc69e1ca0
commit c516d8d4ab
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/org.eclipse.cdt.core/utils/org/eclipse/cdt/utils/spawner/Spawner.java
View file

@ -483,19 +483,21 @@ public class Spawner extends Process {
@Override @Override
public void run() { public void run() {
int _pid;
try { try {
pid = execute(fCmdarray, fEnvp, fDirpath, fChannels); _pid = execute(fCmdarray, fEnvp, fDirpath, fChannels);
} catch (Exception e) { } catch (Exception e) {
pid = -1; _pid = -1;
fException= e; fException= e;
} }
// Tell spawner that the process started. // Tell spawner that the process started.
synchronized (Spawner.this) { synchronized (Spawner.this) {
pid = _pid;
Spawner.this.notifyAll(); Spawner.this.notifyAll();
} }
if (pid != -1) { if (_pid != -1) {
// Sync with spawner and notify when done. // Sync with spawner and notify when done.
status = waitFor(pid); status = waitFor(pid);
synchronized (Spawner.this) { synchronized (Spawner.this) {