From c4f5c35620a59734b697e3c4df99283ef849b628 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 30 Apr 2015 16:52:56 -0400 Subject: [PATCH] [dsf-gdb] debug tests: Remove useless try/catch The try/catch doesn't add anything. If getStackTrace throws, the test will fail and will show the useful stack trace. Change-Id: Icf453ff2ca6c10a32f264fece0f0db9af8049612 Signed-off-by: Simon Marchi --- .../eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java | 2 +- .../eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java | 9 +-------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java b/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java index 8cca5c3b647..63651876695 100644 --- a/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java +++ b/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/SyncUtil.java @@ -384,7 +384,7 @@ public class SyncUtil { return resumeUntilStopped(timeout); } - public static IFrameDMContext getStackFrame(final IExecutionDMContext execCtx, final int level) throws Throwable { + public static IFrameDMContext getStackFrame(final IExecutionDMContext execCtx, final int level) throws Exception { Query query = new Query() { @Override protected void execute(final DataRequestMonitor rm) { diff --git a/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java b/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java index f24ea78475f..5c08836fe5d 100644 --- a/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java +++ b/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java @@ -155,14 +155,7 @@ public class MIRegistersTest extends BaseTestCase { fSession.getExecutor().submit(runnable).get(); //resolve the execution context - MIStoppedEvent stoppedEvent = getInitialStoppedEvent(); - IFrameDMContext frameDmc = null; - try { - frameDmc = SyncUtil.getStackFrame(stoppedEvent.getDMContext(), 0); - } catch (Throwable e1) { - e1.printStackTrace(); - fail("Initialization problem"); - } + IFrameDMContext frameDmc = SyncUtil.getStackFrame(getInitialStoppedEvent().getDMContext(), 0); //resolve the container context IContainerDMContext containerDmc = DMContexts.getAncestorOfType(getInitialStoppedEvent().getDMContext(), IContainerDMContext.class);