Bug 237306: Enable --thread-group for all MI commands

dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/CLICommand.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2009 QNX Software Systems and others.
+ * Copyright (c) 2000, 2011 QNX Software Systems and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -27,4 +27,6 @@ public class CLICommand<V extends MIInfo> extends MICommand<V>
     @Override
 	public boolean supportsThreadAndFrameOptions() { return false; }
     
+    @Override
+    public boolean supportsThreadGroupOption() { return false; }
 }

dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MICommand.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2010 QNX Software Systems and others.
+ * Copyright (c) 2000, 2011 QNX Software Systems and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -153,14 +153,14 @@ public class MICommand<V extends MIInfo> implements ICommand<V> {
         StringBuffer command = new StringBuffer(getOperation());
         
         // Add the --thread option
-        if (supportsThreadAndFrameOptions() && threadId != null) {
+        if (supportsThreadAndFrameOptions() && threadId != null && threadId.trim().length() > 0) {
         	command.append(" --thread " + threadId); //$NON-NLS-1$
 
         	// Add the --frame option, but only if we are using the --thread option
         	if (frameId >= 0) {
         		command.append(" --frame " + frameId); //$NON-NLS-1$
         	}
-        } else if (supportsThreadGroupOption() && groupId != null) {
+        } else if (supportsThreadGroupOption() && groupId != null && groupId.trim().length() > 0) {
         	// The --thread-group option is only allowed if we are not using the --thread option
         	command.append(" --thread-group " + groupId); //$NON-NLS-1$
         }
@@ -257,7 +257,7 @@ public class MICommand<V extends MIInfo> implements ICommand<V> {
     /**
      * @since 4.0
      */
-    public boolean supportsThreadGroupOption() { return false; }
+    public boolean supportsThreadGroupOption() { return true; }
     
     /**
      * Compare commands based on the MI command string that they generate, 

dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIFileExecAndSymbols.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2010 Ericsson and others.
+ * Copyright (c) 2008, 2011 Ericsson and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -56,9 +56,4 @@ public class MIFileExecAndSymbols extends MICommand<MIInfo>
     public MIFileExecAndSymbols(IMIContainerDMContext dmc, String file) {
         super(dmc, "-file-exec-and-symbols", null, file == null ? null : new String[] {file}); //$NON-NLS-1$
     }
-
-    @Override
-    public boolean supportsThreadGroupOption() {
-    	return true;
-    }
 }

dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetAttach.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2010 Ericsson and others.
+ * Copyright (c) 2008, 2011 Ericsson and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -45,9 +45,4 @@ public class MITargetAttach extends MICommand<MIInfo> {
 	public MITargetAttach(IMIContainerDMContext ctx, String pid) {
 		super(ctx, "-target-attach", new String[] { pid }); //$NON-NLS-1$
 	}
-	
-    @Override
-    public boolean supportsThreadGroupOption() {
-    	return true;
-    }
 }

dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MITargetDetach.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2008, 2010 Ericsson and others.
+ * Copyright (c) 2008, 2011 Ericsson and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -49,10 +49,4 @@ public class MITargetDetach extends MICommand<MIInfo> {
 	public MITargetDetach(IMIContainerDMContext ctx) {
 		super(ctx, "-target-detach"); //$NON-NLS-1$
 	}
-	
-	@Override
-	public boolean supportsThreadGroupOption() {
-		return true;
-	}
-
 }

dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/RawCommand.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2009 QNX Software Systems and others.
+ * Copyright (c) 2000, 2011 QNX Software Systems and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -30,6 +30,9 @@ public class RawCommand extends MICommand<MIInfo> {
     @Override
 	public boolean supportsThreadAndFrameOptions() { return false; }
 
+    @Override
+    public boolean supportsThreadGroupOption() { return false; }
+    
     /* (non-Javadoc)
      * @see org.eclipse.cdt.debug.mi.core.command.Command#getMIOutput()
      */