From c3733d0473c9504467759f300f264fb4c0936dea Mon Sep 17 00:00:00 2001 From: Andrew Eidsness Date: Tue, 28 Jan 2014 07:38:30 -0500 Subject: [PATCH] Bug 426784: Qt Codan checker uses wrong type view.connect( view.engine(), SIGNAL( quit() ), ... The return type of view.engine() should be checked for the quit() signal. The implementation was actually checking the type of view. I've fixed a copy/paste error in a utility function. Change-Id: Id483015214f04951fb30e3271d43499f31614446 Signed-off-by: Andrew Eidsness Reviewed-on: https://git.eclipse.org/r/21189 Reviewed-by: Doug Schaefer IP-Clean: Doug Schaefer Tested-by: Doug Schaefer --- .../src/org/eclipse/cdt/internal/qt/core/ASTUtil.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java b/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java index 4deccf48a94..e18152b0b95 100644 --- a/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java +++ b/qt/org.eclipse.cdt.qt.core/src/org/eclipse/cdt/internal/qt/core/ASTUtil.java @@ -130,7 +130,7 @@ public class ASTUtil { if (node instanceof IASTIdExpression) return getBaseType((IASTIdExpression) node); if (node instanceof IASTFunctionCallExpression) - return getReceiverType((IASTFunctionCallExpression) node); + return getBaseType((IASTFunctionCallExpression) node); if (node instanceof IASTExpression) return getBaseType(((IASTExpression) node).getExpressionType());