From c31f99c76e9b01ed5ce3a9d86a818b04c3cd8266 Mon Sep 17 00:00:00 2001 From: Sergey Prigogin Date: Tue, 7 Oct 2014 14:36:03 -0700 Subject: [PATCH] Made few methods final. --- .../cdt/internal/core/dom/parser/ASTNode.java | 13 ++++++------- .../internal/core/dom/rewrite/ASTLiteralNode.java | 2 +- .../cdt/internal/core/pdom/dom/PDOMASTAdapter.java | 2 +- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTNode.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTNode.java index f11b5788e0e..189031670be 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTNode.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ASTNode.java @@ -60,7 +60,7 @@ public abstract class ASTNode implements IASTNode { } @Override - public boolean isFrozen() { + public final boolean isFrozen() { return frozen; } @@ -74,14 +74,13 @@ public abstract class ASTNode implements IASTNode { } public void setInactive() { - if (frozen) - throw new IllegalStateException("attempt to modify frozen AST node"); //$NON-NLS-1$ + assertNotFrozen(); active= false; } - protected void assertNotFrozen() throws IllegalStateException { + protected final void assertNotFrozen() throws IllegalStateException { if (frozen) - throw new IllegalStateException("attempt to modify frozen AST node"); //$NON-NLS-1$ + throw new IllegalStateException("Attempt to modify a frozen AST node"); //$NON-NLS-1$ } @Override @@ -91,7 +90,7 @@ public abstract class ASTNode implements IASTNode { } @Override - public ASTNodeProperty getPropertyInParent() { + public final ASTNodeProperty getPropertyInParent() { return property; } @@ -105,7 +104,7 @@ public abstract class ASTNode implements IASTNode { return offset; } - public int getLength() { + public final int getLength() { return length; } diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/ASTLiteralNode.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/ASTLiteralNode.java index 4bfd9b5d47f..1306b15e7af 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/ASTLiteralNode.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/rewrite/ASTLiteralNode.java @@ -75,7 +75,7 @@ public class ASTLiteralNode implements IASTNode { } @Override - public ASTNodeProperty getPropertyInParent() { + public final ASTNodeProperty getPropertyInParent() { return null; } diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/PDOMASTAdapter.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/PDOMASTAdapter.java index a6bf95f62d6..ee573c3d9c7 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/PDOMASTAdapter.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/dom/PDOMASTAdapter.java @@ -142,7 +142,7 @@ public class PDOMASTAdapter { } @Override - public ASTNodeProperty getPropertyInParent() { + public final ASTNodeProperty getPropertyInParent() { return fDelegate.getPropertyInParent(); }