From c1e3974e1b94511c7970faa41ac0c70882e67b35 Mon Sep 17 00:00:00 2001 From: Umair Sair Date: Wed, 12 Sep 2018 00:00:29 +0500 Subject: [PATCH] Bug 538942 - Moving backward and forward in "Create Launch Configuration" dialog of launchbar causes NPEs Change-Id: Ibd11b43d4348abfa74509ce715c8d5e741f1582f Signed-off-by: Umair Sair --- .../ui/internal/dialogs/NewLaunchConfigEditPage.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/bundles/org.eclipse.launchbar.ui/src/org/eclipse/launchbar/ui/internal/dialogs/NewLaunchConfigEditPage.java b/bundles/org.eclipse.launchbar.ui/src/org/eclipse/launchbar/ui/internal/dialogs/NewLaunchConfigEditPage.java index 9e32ba076a0..2c6f50cc5a7 100644 --- a/bundles/org.eclipse.launchbar.ui/src/org/eclipse/launchbar/ui/internal/dialogs/NewLaunchConfigEditPage.java +++ b/bundles/org.eclipse.launchbar.ui/src/org/eclipse/launchbar/ui/internal/dialogs/NewLaunchConfigEditPage.java @@ -83,7 +83,9 @@ public class NewLaunchConfigEditPage extends WizardPage implements IPageChanging @Override public void handlePageChanging(PageChangingEvent event) { - if (launchConfigType == null) { + if (launchConfigType == null || event.getTargetPage() != this) { + if (tabViewer != null) + tabViewer.setInput(null); return; } LaunchConfigurationsDialog.setCurrentlyVisibleLaunchConfigurationDialog(launchConfigurationDialog); @@ -186,6 +188,11 @@ public class NewLaunchConfigEditPage extends WizardPage implements IPageChanging public void setTabViewer(LaunchConfigurationTabGroupViewer viewer) { super.setTabViewer(viewer); } + + @Override + public boolean isTreeSelectionEmpty() { + return false; + } } private class LaunchConfigurationTabGroupViewerExt extends LaunchConfigurationTabGroupViewer {