From c14712793d0702fb9ddd0f719cd1994e6917a0b0 Mon Sep 17 00:00:00 2001 From: Mikhail Khodjaiants Date: Wed, 3 Oct 2012 11:04:04 -0400 Subject: [PATCH] Bug 363688 - CDT issues "auto-solib-add on" command to gdb with invalid syntax --- .../win32/StandardWinCommandFactory.java | 19 +------------ .../factories/win32/WinMIGDBSetAutoSolib.java | 27 +++++++++++++++++++ 2 files changed, 28 insertions(+), 18 deletions(-) create mode 100644 debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/WinMIGDBSetAutoSolib.java diff --git a/debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/StandardWinCommandFactory.java b/debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/StandardWinCommandFactory.java index 76a66f0640a..e4aee9f6177 100644 --- a/debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/StandardWinCommandFactory.java +++ b/debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/StandardWinCommandFactory.java @@ -49,24 +49,7 @@ public class StandardWinCommandFactory extends StandardCommandFactory { @Override public MIGDBSetAutoSolib createMIGDBSetAutoSolib( boolean set ) { - // Suppress "set auto-solib" - returns error on Windows - return new MIGDBSetAutoSolib( getMIVersion(), true ) { - - @Override - public String getOperation() { - return ""; //$NON-NLS-1$ - } - - @Override - public String[] getOptions() { - return new String[0]; - } - - @Override - public String[] getParameters() { - return new String[0]; - } - }; + return new WinMIGDBSetAutoSolib( getMIVersion(), set ); } @Override diff --git a/debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/WinMIGDBSetAutoSolib.java b/debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/WinMIGDBSetAutoSolib.java new file mode 100644 index 00000000000..cbbd491d71d --- /dev/null +++ b/debug/org.eclipse.cdt.debug.mi.core/mi/org/eclipse/cdt/debug/mi/core/command/factories/win32/WinMIGDBSetAutoSolib.java @@ -0,0 +1,27 @@ +/******************************************************************************* + * Copyright (c) 2012 Mentor Graphics and others. + * All rights reserved. This program and the accompanying materials + * are made available under the terms of the Eclipse Public License v1.0 + * which accompanies this distribution, and is available at + * http://www.eclipse.org/legal/epl-v10.html + * + * Contributors: + * Mentor Graphics - Initial API and implementation + *******************************************************************************/ + +package org.eclipse.cdt.debug.mi.core.command.factories.win32; + +import org.eclipse.cdt.debug.mi.core.command.MIGDBSetAutoSolib; + +/** + * Suppress "set auto-solib" - returns error on Windows + */ +class WinMIGDBSetAutoSolib extends MIGDBSetAutoSolib { + + public WinMIGDBSetAutoSolib(String miVersion, boolean isSet) { + super(miVersion, isSet); + setOperation(""); //$NON-NLS-1$ + setOptions(new String[0]); + setParameters(new String[0]); + } +}