mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-23 22:52:11 +02:00
Code Issues Wiki Activity

Documentation enhancements

Browse source
This commit is contained in:
John Cortell 2009-09-30 10:05:23 +00:00
parent b6cb68b56d
commit bf4a4149cf
2 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/numberformat/FormattedValueVMUtil.java
View file

@ -123,14 +123,14 @@ public class FormattedValueVMUtil {
*
* @param updates The array of updates to fill in information to. This
* update is used to retrieve the data model context and to write the
* properties into.
* properties into. Implementation will not directly mark these updates
* complete, but contribute towards that end by marking [monitor] complete.
* @param service The service to be used to retrieve the values from.
* @param dmcType The class type of the data model context. Some updates
* can contain multiple formatted data data model contexts, and this
* method assures that there is no ambiguity in which context should be
* used.
* @param monitor Request monitor that will be called when all the
* updates are completed.
* @param monitor Request monitor used to signal completion of work
*/
@ConfinedToDsfExecutor("service.getExecutor()")
public static void updateFormattedValues(
@ -152,6 +152,8 @@ public class FormattedValueVMUtil {
// Retrieve the formatted values now that we have the available formats (where needed).
// Note that we are passing off responsibility of our parent monitor
updateFormattedValuesWithAvailableFormats(updates, service, dmcType, availableFormats, monitor);
// Note: we must not call the update's done method
}
};
int count = 0;
@ -208,6 +210,10 @@ public class FormattedValueVMUtil {
}
/**
* @param updates
* the update objects to act on. Implementation will not directly
* mark these complete, but contribute towards that end by
* marking [monitor] complete.
* @param availableFormatsMap
* prior to calling this method, the caller queries (where
* necessary) the formats supported by the element in each
@ -216,6 +222,8 @@ public class FormattedValueVMUtil {
* view-model element doesn't support any formats (very
* unlikely), or that the available formats aren't necessary to
* service the properties specified in the update
* @param monitor
* Request monitor used to signal completion of work
*/
@ConfinedToDsfExecutor("service.getExecutor()")
private static void updateFormattedValuesWithAvailableFormats(
@ -319,6 +327,8 @@ public class FormattedValueVMUtil {
update.setStatus(getStatus());
}
countingRm.done();
// Note: we must not call the update's done method
};
});
count++;

7
dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/register/RegisterVMNode.java
View file

@ -467,6 +467,11 @@ public class RegisterVMNode extends AbstractExpressionVMNode
protected void updatePropertiesInSessionThread(final IPropertiesUpdate[] updates) {
IRegisters service = getServicesTracker().getService(IRegisters.class, null);
// Create a counting request monitor to coordinate various activities
// on the updated objects. Though the update objects will be given to
// various ViewerDataRequestMonitors, such monitors must make sure to
// not mark the update objects complete. That needs to be left to the
// following monitor.
final CountingRequestMonitor countingRm = new CountingRequestMonitor(ImmediateExecutor.getInstance(), null) {
@Override
protected void handleCompleted() {
@ -512,6 +517,8 @@ public class RegisterVMNode extends AbstractExpressionVMNode
update.setStatus(getStatus());
}
countingRm.done();
// Note: we must not call the update's done method
}
});
count++;