mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Code Issues Wiki Activity

Bug 409186 - Memory tests had failures.

Browse source 
First failure was because we now know the endianess but the test was not
updated.  The second failure was because different GDB versions gave
different error messages for memory write failures.


Change-Id: Idbac275a5de3a0af77d030474fea60808ca9a54c
Reviewed-on: https://git.eclipse.org/r/13331
Reviewed-by: Marc Khouzam <marc.khouzam@ericsson.com>
IP-Clean: Marc Khouzam <marc.khouzam@ericsson.com>
Tested-by: Marc Khouzam <marc.khouzam@ericsson.com>
This commit is contained in:
Marc Khouzam 2013-05-28 16:24:46 -04:00
parent fcb46a9a5d
commit bd28316f57
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIMemoryTest.java
View file

@ -504,8 +504,8 @@ public class MIMemoryTest extends BaseTestCase {
// Ensure that we receive a block of invalid memory bytes // Ensure that we receive a block of invalid memory bytes
assertTrue(fWait.getMessage(), fWait.isOK()); assertTrue(fWait.getMessage(), fWait.isOK());
MemoryByte[] buffer = (MemoryByte[]) fWait.getReturnInfo(); MemoryByte[] buffer = (MemoryByte[]) fWait.getReturnInfo();
assertTrue("Wrong value: expected '-1, 0', received '" + buffer[0].getValue() + ", " + buffer[0].getFlags() + "'", assertTrue("Wrong value: expected '0, 32', received '" + buffer[0].getValue() + ", " + buffer[0].getFlags() + "'",
(buffer[0].getValue() == (byte) 0) && (buffer[0].getFlags() == (byte) 0)); (buffer[0].getValue() == (byte) 0) && (buffer[0].getFlags() == (byte) 32));
// Ensure no MemoryChangedEvent event was received // Ensure no MemoryChangedEvent event was received
assertTrue("MemoryChangedEvent problem: expected " + 0 + ", received " + getEventCount(), getEventCount() == 0); assertTrue("MemoryChangedEvent problem: expected " + 0 + ", received " + getEventCount(), getEventCount() == 0);
@ -797,9 +797,7 @@ public class MIMemoryTest extends BaseTestCase {
writeMemory(fMemoryDmc, fBaseAddress, offset, word_size, count, buffer); writeMemory(fMemoryDmc, fBaseAddress, offset, word_size, count, buffer);
fWait.waitUntilDone(AsyncCompletionWaitor.WAIT_FOREVER); fWait.waitUntilDone(AsyncCompletionWaitor.WAIT_FOREVER);
assertFalse(fWait.getMessage(), fWait.isOK()); assertFalse(fWait.getMessage(), fWait.isOK());
String expected = "Cannot access memory at address"; // Error msg returned by gdb // Don't test the error message since it changes from one GDB version to another
assertTrue("Wrong error message: expected '" + expected + "', received '" + fWait.getMessage() + "'",
fWait.getMessage().contains(expected));
// Ensure no MemoryChangedEvent event was received // Ensure no MemoryChangedEvent event was received
assertTrue("MemoryChangedEvent problem: expected " + 0 + ", received " + getEventCount(), getEventCount() == 0); assertTrue("MemoryChangedEvent problem: expected " + 0 + ", received " + getEventCount(), getEventCount() == 0);