1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-23 14:42:11 +02:00

Bug 309760 - renamed checker

This commit is contained in:
Alena Laskavaia 2010-07-21 00:05:44 +00:00
parent bba580e5a0
commit bcc7727f9c
5 changed files with 431 additions and 56 deletions

View file

@ -120,17 +120,134 @@
</problem> </problem>
</checker> </checker>
<checker <checker
class="org.eclipse.cdt.codan.internal.checkers.NameResolutionChecker" class="org.eclipse.cdt.codan.internal.checkers.ProblemBindingChecker"
id="org.eclipse.cdt.codan.checkers.NameResolutionChecker" id="org.eclipse.cdt.codan.internal.checkers.ProblemBindingChecker"
name="Name Resolution Checker"> name="Problem Binding Checker">
<problem <problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems" category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true" defaultEnabled="true"
defaultSeverity="Error" defaultSeverity="Error"
description="Name resolution problem found by the indexer" description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.NameResolutionChecker" id="org.eclipse.cdt.codan.internal.checkers.VariableResolutionProblem"
messagePattern="Symbol &apos;&apos;{0}&apos;&apos; could not be resolved" messagePattern="Symbol &apos;&apos;{0}&apos;&apos; could not be resolved"
name="Name Resolution Problem"> name="Variable resolution problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.OverloadProblem"
messagePattern="Invalid overload of {0}"
name="Overload problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.AmbiguousProblem"
messagePattern="{0} is ambiguous {1}"
name="Ambiguous problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.CircularReferenceProblem"
messagePattern="Circular inheritance encountered in {0}"
name="Circular reference problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.RedeclarationProblem"
messagePattern="Invalid redeclaration of {0}"
name="Redeclaration problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.RedefinitionProblem"
messagePattern="Invalid redefinition of {0}"
name="Redefinition problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.MemberDeclarationNotFoundProblem"
messagePattern="Member declaration not found"
name="Member declaration not found">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.LabelStatementNotFoundProblem"
messagePattern="{0} : label not found"
name="Label statement not found">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.InvalidTemplateArgumentsProblem"
messagePattern="Invalid template arguments"
name="Invalid template argument">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.TypeResolutionProblem"
messagePattern="{0} type could not be resolved"
name="Type resolution problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.FunctionResolutionProblem"
messagePattern="{0} : function could not be resolved"
name="Function resolution problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.InvalidArguments"
messagePattern="Invalid arguments {0}"
name="Invalid arguments problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.MethodResolutionProblem"
messagePattern="{0} : method could not be resolved"
name="Method resolution problem">
</problem>
<problem
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultEnabled="true"
defaultSeverity="Error"
description="Name resolution problem found by the indexer"
id="org.eclipse.cdt.codan.internal.checkers.FieldResolutionProblem"
messagePattern="{0} : field could not be resolved"
name="Field resolution problem">
</problem> </problem>
</checker> </checker>
</extension> </extension>

View file

@ -24,6 +24,9 @@ public class CheckersMessages extends NLS {
public static String GenericParameter_ParameterExceptionsItem; public static String GenericParameter_ParameterExceptionsItem;
public static String StatementHasNoEffectChecker_ParameterMacro; public static String StatementHasNoEffectChecker_ParameterMacro;
public static String SuggestedParenthesisChecker_SuggestParanthesesAroundNot; public static String SuggestedParenthesisChecker_SuggestParanthesesAroundNot;
public static String ProblemBindingChecker_Candidates;
static { static {
// initialize resource bundle // initialize resource bundle
NLS.initializeMessages(BUNDLE_NAME, CheckersMessages.class); NLS.initializeMessages(BUNDLE_NAME, CheckersMessages.class);

View file

@ -1,51 +0,0 @@
/*******************************************************************************
* Copyright (c) 2010 Marc-Andre Laperle and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* Marc-Andre Laperle - Initial API and implementation
*******************************************************************************/
package org.eclipse.cdt.codan.internal.checkers;
import org.eclipse.cdt.codan.core.cxx.model.AbstractIndexAstChecker;
import org.eclipse.cdt.core.dom.ast.ASTVisitor;
import org.eclipse.cdt.core.dom.ast.IASTName;
import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit;
import org.eclipse.cdt.core.dom.ast.IBinding;
import org.eclipse.cdt.core.dom.ast.IProblemBinding;
public class NameResolutionChecker extends AbstractIndexAstChecker {
static final String ERR_ID = "org.eclipse.cdt.codan.internal.checkers.NameResolutionChecker"; //$NON-NLS-1$
public void processAst(IASTTranslationUnit ast) {
try {
ast.accept(new ASTVisitor() {
{
shouldVisitNames = true;
}
@Override
public int visit(IASTName name) {
IBinding binding = name.resolveBinding();
if (binding instanceof IProblemBinding) {
reportProblem(ERR_ID, name, name.getRawSignature());
}
return PROCESS_CONTINUE;
}
});
} catch (Exception e) {
e.printStackTrace();
}
}
@Override
public boolean runInEditor() {
return true;
}
}

View file

@ -0,0 +1,304 @@
/*******************************************************************************
* Copyright (c) 2010 Marc-Andre Laperle and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* Marc-Andre Laperle - Initial API and implementation
* Tomasz Wesolowski - Extension for fixes
*******************************************************************************/
package org.eclipse.cdt.codan.internal.checkers;
import org.eclipse.cdt.codan.core.cxx.CxxAstUtils;
import org.eclipse.cdt.codan.core.cxx.model.AbstractIndexAstChecker;
import org.eclipse.cdt.core.dom.ast.ASTTypeUtil;
import org.eclipse.cdt.core.dom.ast.ASTVisitor;
import org.eclipse.cdt.core.dom.ast.DOMException;
import org.eclipse.cdt.core.dom.ast.IASTCompositeTypeSpecifier;
import org.eclipse.cdt.core.dom.ast.IASTExpression;
import org.eclipse.cdt.core.dom.ast.IASTFieldReference;
import org.eclipse.cdt.core.dom.ast.IASTFunctionCallExpression;
import org.eclipse.cdt.core.dom.ast.IASTFunctionDefinition;
import org.eclipse.cdt.core.dom.ast.IASTIdExpression;
import org.eclipse.cdt.core.dom.ast.IASTName;
import org.eclipse.cdt.core.dom.ast.IASTNamedTypeSpecifier;
import org.eclipse.cdt.core.dom.ast.IASTNode;
import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit;
import org.eclipse.cdt.core.dom.ast.IBinding;
import org.eclipse.cdt.core.dom.ast.IFunctionType;
import org.eclipse.cdt.core.dom.ast.IProblemBinding;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTQualifiedName;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTTemplateId;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPClassType;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPFunction;
import org.eclipse.cdt.core.index.IIndex;
public class ProblemBindingChecker extends AbstractIndexAstChecker {
public static String ERR_ID_OverloadProblem = "org.eclipse.cdt.codan.internal.checkers.OverloadProblem"; //$NON-NLS-1$
public static String ERR_ID_AmbiguousProblem = "org.eclipse.cdt.codan.internal.checkers.AmbiguousProblem"; //$NON-NLS-1$
public static String ERR_ID_CircularReferenceProblem = "org.eclipse.cdt.codan.internal.checkers.CircularReferenceProblem"; //$NON-NLS-1$
public static String ERR_ID_RedeclarationProblem = "org.eclipse.cdt.codan.internal.checkers.RedeclarationProblem"; //$NON-NLS-1$
public static String ERR_ID_RedefinitionProblem = "org.eclipse.cdt.codan.internal.checkers.RedefinitionProblem"; //$NON-NLS-1$
public static String ERR_ID_MemberDeclarationNotFoundProblem = "org.eclipse.cdt.codan.internal.checkers.MemberDeclarationNotFoundProblem"; //$NON-NLS-1$
public static String ERR_ID_LabelStatementNotFoundProblem = "org.eclipse.cdt.codan.internal.checkers.LabelStatementNotFoundProblem"; //$NON-NLS-1$
public static String ERR_ID_InvalidTemplateArgumentsProblem = "org.eclipse.cdt.codan.internal.checkers.InvalidTemplateArgumentsProblem"; //$NON-NLS-1$
public static String ERR_ID_TypeResolutionProblem = "org.eclipse.cdt.codan.internal.checkers.TypeResolutionProblem"; //$NON-NLS-1$
public static String ERR_ID_FunctionResolutionProblem = "org.eclipse.cdt.codan.internal.checkers.FunctionResolutionProblem"; //$NON-NLS-1$
public static String ERR_ID_InvalidArguments = "org.eclipse.cdt.codan.internal.checkers.InvalidArguments"; //$NON-NLS-1$
public static String ERR_ID_MethodResolutionProblem = "org.eclipse.cdt.codan.internal.checkers.MethodResolutionProblem"; //$NON-NLS-1$
public static String ERR_ID_FieldResolutionProblem = "org.eclipse.cdt.codan.internal.checkers.FieldResolutionProblem"; //$NON-NLS-1$
public static String ERR_ID_VariableResolutionProblem = "org.eclipse.cdt.codan.internal.checkers.VariableResolutionProblem"; //$NON-NLS-1$
public static String ERR_ID_Candidates = "org.eclipse.cdt.codan.internal.checkers.Candidates"; //$NON-NLS-1$
@Override
public boolean runInEditor() {
return true;
}
public void processAst(IASTTranslationUnit ast) {
try {
ast.accept(new ASTVisitor() {
{
shouldVisitNames = true;
}
@Override
public int visit(IASTName name) {
try {
IBinding binding = name.resolveBinding();
if (binding instanceof IProblemBinding) {
IASTNode parentNode = name.getParent();
// Don't report multiple problems with qualified names
if(parentNode instanceof ICPPASTQualifiedName) {
if(((ICPPASTQualifiedName)parentNode).resolveBinding() instanceof IProblemBinding)
return PROCESS_CONTINUE;
}
String contextFlagsString = createContextFlagsString(name);
IProblemBinding problemBinding = (IProblemBinding) binding;
int id = problemBinding.getID();
if(id == IProblemBinding.SEMANTIC_INVALID_OVERLOAD) {
reportProblem(ERR_ID_OverloadProblem, name, name.getRawSignature(), contextFlagsString);
return PROCESS_CONTINUE;
}
if(id == IProblemBinding.SEMANTIC_AMBIGUOUS_LOOKUP) {
String candidatesString = getCandidatesString(problemBinding);
reportProblem(ERR_ID_AmbiguousProblem, name, name.getRawSignature(), candidatesString, contextFlagsString);
return PROCESS_CONTINUE;
}
if(id == IProblemBinding.SEMANTIC_CIRCULAR_INHERITANCE) {
String typeString;
IASTNode problemNode;
if(parentNode instanceof IASTFieldReference) {
IASTExpression ownerExpression = ((IASTFieldReference)parentNode).getFieldOwner();
typeString = ASTTypeUtil.getType(ownerExpression.getExpressionType());
problemNode = ownerExpression;
} else {
problemNode = name;
typeString = name.getRawSignature();
}
reportProblem(ERR_ID_CircularReferenceProblem, problemNode, typeString, contextFlagsString);
return PROCESS_CONTINUE;
}
if(id == IProblemBinding.SEMANTIC_INVALID_REDECLARATION) {
reportProblem(ERR_ID_RedeclarationProblem, name, name.getRawSignature(), contextFlagsString);
return PROCESS_CONTINUE;
}
if(id == IProblemBinding.SEMANTIC_INVALID_REDEFINITION) {
reportProblem(ERR_ID_RedefinitionProblem, name, name.getRawSignature(), contextFlagsString);
return PROCESS_CONTINUE;
}
if(id == IProblemBinding.SEMANTIC_MEMBER_DECLARATION_NOT_FOUND) {
reportProblem(ERR_ID_MemberDeclarationNotFoundProblem, name, contextFlagsString);
return PROCESS_CONTINUE;
}
if(id == IProblemBinding.SEMANTIC_LABEL_STATEMENT_NOT_FOUND) {
reportProblem(ERR_ID_LabelStatementNotFoundProblem, name, name.getRawSignature(), contextFlagsString);
return PROCESS_CONTINUE;
}
if(id == IProblemBinding.SEMANTIC_INVALID_TEMPLATE_ARGUMENTS) {
// We use the templateName since we don't want the whole
// argument list to be underlined. That way we can see which argument is invalid.
IASTNode templateName = getTemplateName(name);
reportProblem(ERR_ID_InvalidTemplateArgumentsProblem, templateName, contextFlagsString);
return PROCESS_CONTINUE;
}
// From this point, we'll deal only with NAME_NOT_FOUND problems.
// If it's something else continue because we don't want to give bad messages
if(id != IProblemBinding.SEMANTIC_NAME_NOT_FOUND) {
return PROCESS_CONTINUE;
}
if(isFunctionCall(parentNode)) {
handleFunctionProblem(name, problemBinding, contextFlagsString);
} else if (parentNode instanceof IASTFieldReference) {
handleMemberProblem(name, parentNode, problemBinding, contextFlagsString);
} else if (parentNode instanceof IASTNamedTypeSpecifier) {
reportProblem(ERR_ID_TypeResolutionProblem, name, name.getRawSignature(), contextFlagsString);
}
// Probably a variable
else {
handleVariableProblem(name, contextFlagsString);
}
}
} catch (DOMException e) {
e.printStackTrace();
}
return PROCESS_CONTINUE;
}
});
} catch (Exception e) {
e.printStackTrace();
}
}
protected String createContextFlagsString(IASTName name) {
StringBuilder buf = new StringBuilder();
if (isInClassContext(name)) {
buf.append(":class"); //$NON-NLS-1$
}
if (isInFunctionContext(name)) {
buf.append(":func"); //$NON-NLS-1$
}
return buf.toString();
}
private boolean isInClassContext(IASTName name) {
CxxAstUtils utils = CxxAstUtils.getInstance();
if (utils.getEnclosingCompositeTypeSpecifier(name) != null) {
return true;
}
IASTFunctionDefinition function = utils.getEnclosingFunction(name);
if (name == null || function == null) {
return false;
}
IIndex index = name.getTranslationUnit().getIndex();
IASTCompositeTypeSpecifier composite = utils.getCompositeTypeFromFunction(function, index);
return composite != null;
}
private boolean isInFunctionContext(IASTName name) {
CxxAstUtils utils = CxxAstUtils.getInstance();
IASTFunctionDefinition function = utils.getEnclosingFunction(name);
return (function != null);
}
private void handleFunctionProblem(IASTName name, IProblemBinding problemBinding, String contextFlagsString)
throws DOMException {
if(problemBinding.getCandidateBindings().length == 0) {
reportProblem(ERR_ID_FunctionResolutionProblem, name.getLastName(), name.getRawSignature(), contextFlagsString);
} else {
String candidatesString = getCandidatesString(problemBinding);
reportProblem(ERR_ID_InvalidArguments, name.getLastName(), candidatesString, contextFlagsString);
}
}
private void handleMemberProblem(IASTName name, IASTNode parentNode,
IProblemBinding problemBinding, String contextFlagsString) throws DOMException {
IASTNode parentParentNode = parentNode.getParent();
if(parentParentNode instanceof IASTFunctionCallExpression) {
if(problemBinding.getCandidateBindings().length == 0) {
reportProblem(ERR_ID_MethodResolutionProblem, name.getLastName(), name.getRawSignature(), contextFlagsString);
} else {
String candidatesString = getCandidatesString(problemBinding);
reportProblem(ERR_ID_InvalidArguments, name.getLastName(), candidatesString, contextFlagsString);
}
} else {
reportProblem(ERR_ID_FieldResolutionProblem, name.getLastName(), name.getRawSignature(), contextFlagsString);
}
}
private void handleVariableProblem(IASTName name, String contextFlagsString) {
reportProblem(ERR_ID_VariableResolutionProblem, name, name.getRawSignature(), contextFlagsString);
}
private boolean isFunctionCall(IASTNode parentNode) {
if(parentNode instanceof IASTIdExpression) {
IASTIdExpression expression = (IASTIdExpression)parentNode;
IASTNode parentParentNode = expression.getParent();
if(parentParentNode instanceof IASTFunctionCallExpression &&
expression.getPropertyInParent().getName().equals(IASTFunctionCallExpression.FUNCTION_NAME.getName())) {
return true;
}
}
return false;
}
protected IASTNode getTemplateName(IASTName name) {
IASTName nameToGetTempate = name.getLastName();
if(nameToGetTempate instanceof ICPPASTTemplateId) {
return ((ICPPASTTemplateId)nameToGetTempate).getTemplateName();
}
return nameToGetTempate;
}
/**
* Returns a string of the candidates for the binding
*
* @param problemBinding
* @return A string of the candidates, one per line
* @throws DOMException
*/
private String getCandidatesString(IProblemBinding problemBinding) throws DOMException {
String candidatesString = "\n" + CheckersMessages.ProblemBindingChecker_Candidates + "\n"; //$NON-NLS-1$ //$NON-NLS-2$
String lastSignature = ""; //$NON-NLS-1$
for(IBinding candidateBinding : problemBinding.getCandidateBindings()) {
if(candidateBinding instanceof ICPPFunction) {
ICPPFunction functionBinding = (ICPPFunction)candidateBinding;
String signature = getFunctionSignature(functionBinding);
if(!signature.equals(lastSignature)) {
candidatesString += signature + "\n"; //$NON-NLS-1$
lastSignature = signature;
}
} else if(candidateBinding instanceof ICPPClassType) {
ICPPClassType classType = (ICPPClassType)candidateBinding;
for(ICPPFunction constructor : classType.getConstructors()) {
String signature = getFunctionSignature(constructor);
if(!signature.equals(lastSignature)) {
candidatesString += signature + "\n"; //$NON-NLS-1$
lastSignature = signature;
}
}
}
}
return candidatesString;
}
/**
* Returns a string of the function signature : returntype + function + parameters
*
* @param functionBinding The function to get the signature
* @return A string of the function signature
* @throws DOMException
*/
private String getFunctionSignature(ICPPFunction functionBinding) throws DOMException {
IFunctionType functionType = functionBinding.getType();
String returnTypeString = ASTTypeUtil.getType(functionBinding.getType().getReturnType()) + " "; //$NON-NLS-1$
String functionName = functionBinding.getName();
String parameterTypeString = ASTTypeUtil.getParameterTypeString(functionType);
return returnTypeString + functionName + parameterTypeString;
}
}

View file

@ -15,3 +15,5 @@ GenericParameter_ParameterExceptions=Exceptions (value of the problem argument)
GenericParameter_ParameterExceptionsItem=Value of the argument GenericParameter_ParameterExceptionsItem=Value of the argument
StatementHasNoEffectChecker_ParameterMacro=Report problem in statements that comes from macro expansion StatementHasNoEffectChecker_ParameterMacro=Report problem in statements that comes from macro expansion
SuggestedParenthesisChecker_SuggestParanthesesAroundNot=Suggest parenthesis around not operator SuggestedParenthesisChecker_SuggestParanthesesAroundNot=Suggest parenthesis around not operator
ProblemBindingChecker_Candidates=Candidates are: