From bb97b889b255fe35d40995726ff87f1d0f0a4f6c Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 6 Dec 2012 15:51:14 -0800 Subject: [PATCH] Bug 395247 - Error involving variadic constructor Change-Id: Ia5f911e0a80a5372943a505b814c333c53a5a602 Reviewed-on: https://git.eclipse.org/r/9061 Reviewed-by: Sergey Prigogin IP-Clean: Sergey Prigogin Tested-by: Sergey Prigogin --- .../core/parser/tests/ast2/AST2TemplateTests.java | 14 +++++++++++++- .../dom/parser/cpp/semantics/CPPSemantics.java | 3 +++ .../core/dom/parser/cpp/semantics/LookupData.java | 2 +- 3 files changed, 17 insertions(+), 2 deletions(-) diff --git a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java index e07b132667a..868304db03e 100644 --- a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java +++ b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/AST2TemplateTests.java @@ -6897,7 +6897,7 @@ public class AST2TemplateTests extends AST2BaseTest { // struct Cat {}; // typedef S::value>::type T; public void testDependentExpressionInvolvingField_388623() throws Exception { - parseAndCheckBindings(getAboveComment(), CPP, true); + parseAndCheckBindings(); } // struct S { @@ -6911,4 +6911,16 @@ public class AST2TemplateTests extends AST2BaseTest { public void testSFINAEInDefaultArgument() throws Exception { parseAndCheckBindings(); } + + // template + // struct M { + // template + // M(Args...); + // }; + // void foo() { + // new M((int*)0, 0); + // } + public void testVariadicConstructor_395247() throws Exception { + parseAndCheckBindings(); + } } diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java index dec5a062f90..eeb245d2399 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java @@ -417,6 +417,9 @@ public class CPPSemantics { if (cls instanceof ICPPUnknownBinding) { binding= new CPPUnknownConstructor(cls); } else { + // Do not interpret template arguments to a template class as being + // explicit template arguments to its templated constructor. + data.fTemplateArguments = null; binding= CPPSemantics.resolveFunction(data, ClassTypeHelper.getConstructors(cls, lookupPoint), true); } } catch (DOMException e) { diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/LookupData.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/LookupData.java index bb4677269e0..eb52bce8ca3 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/LookupData.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/LookupData.java @@ -79,7 +79,7 @@ import org.eclipse.cdt.internal.core.dom.parser.cpp.ICPPEvaluation; * Context data for IASTName lookup */ public class LookupData extends ScopeLookupData { - final public ICPPTemplateArgument[] fTemplateArguments; + public ICPPTemplateArgument[] fTemplateArguments; public Map> usingDirectives= Collections.emptyMap(); /** Used to ensure we don't visit things more than once. */