From b8427cb54a566c90c6432ebf9329b42a5849082c Mon Sep 17 00:00:00 2001 From: Alexander Fedorov Date: Thu, 20 Aug 2020 11:19:25 +0300 Subject: [PATCH] Bug 558664 - cquery and clangd: registered each LS from its own bundle Part 10: Move clangd code to org.eclipse.cdt.lsp.clangd bundle. Change-Id: Ib2938ea34a4996a535658decc61a725f4626c649 Signed-off-by: Alexander Fedorov --- lsp/org.eclipse.cdt.lsp.clangd/.project | 5 +++++ lsp/org.eclipse.cdt.lsp.clangd/META-INF/MANIFEST.MF | 5 +++++ ...pse.cdt.lsp.internal.clangd.ClangdLanguageServer.xml} | 4 ++-- lsp/org.eclipse.cdt.lsp.clangd/src/.gitkeep | 0 .../cdt/lsp}/internal/clangd/ClangdLanguageServer.java | 2 +- .../eclipse/cdt/lsp}/internal/clangd/ClangdMessages.java | 9 ++++++--- .../cdt/lsp}/internal/clangd/ClangdMessages.properties | 0 lsp/org.eclipse.cdt.lsp.core/META-INF/MANIFEST.MF | 4 +--- 8 files changed, 20 insertions(+), 9 deletions(-) rename lsp/{org.eclipse.cdt.lsp.core/OSGI-INF/org.eclipse.cdt.internal.clangd.ClangdLanguageServer.xml => org.eclipse.cdt.lsp.clangd/OSGI-INF/org.eclipse.cdt.lsp.internal.clangd.ClangdLanguageServer.xml} (59%) delete mode 100644 lsp/org.eclipse.cdt.lsp.clangd/src/.gitkeep rename lsp/{org.eclipse.cdt.lsp.core/src/org/eclipse/cdt => org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp}/internal/clangd/ClangdLanguageServer.java (95%) rename lsp/{org.eclipse.cdt.lsp.core/src/org/eclipse/cdt => org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp}/internal/clangd/ClangdMessages.java (83%) rename lsp/{org.eclipse.cdt.lsp.core/src/org/eclipse/cdt => org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp}/internal/clangd/ClangdMessages.properties (100%) diff --git a/lsp/org.eclipse.cdt.lsp.clangd/.project b/lsp/org.eclipse.cdt.lsp.clangd/.project index e7db37a25a3..3e1df7ce1ce 100644 --- a/lsp/org.eclipse.cdt.lsp.clangd/.project +++ b/lsp/org.eclipse.cdt.lsp.clangd/.project @@ -20,6 +20,11 @@ + + org.eclipse.pde.ds.core.builder + + + org.eclipse.pde.PluginNature diff --git a/lsp/org.eclipse.cdt.lsp.clangd/META-INF/MANIFEST.MF b/lsp/org.eclipse.cdt.lsp.clangd/META-INF/MANIFEST.MF index a1e8b83865f..71a123a3563 100644 --- a/lsp/org.eclipse.cdt.lsp.clangd/META-INF/MANIFEST.MF +++ b/lsp/org.eclipse.cdt.lsp.clangd/META-INF/MANIFEST.MF @@ -6,3 +6,8 @@ Bundle-Version: 0.1.0.qualifier Bundle-Name: %Bundle-Name Bundle-Vendor: %Bundle-Vendor Bundle-RequiredExecutionEnvironment: JavaSE-1.8 +Service-Component: OSGI-INF/org.eclipse.cdt.lsp.internal.clangd.ClangdLanguageServer.xml +Bundle-ActivationPolicy: lazy +Require-Bundle: org.eclipse.cdt.lsp.core;bundle-version="1.1.100", + org.eclipse.osgi.services;bundle-version="3.9.0";resolution:=optional, + org.eclipse.osgi;bundle-version="3.16.0" diff --git a/lsp/org.eclipse.cdt.lsp.core/OSGI-INF/org.eclipse.cdt.internal.clangd.ClangdLanguageServer.xml b/lsp/org.eclipse.cdt.lsp.clangd/OSGI-INF/org.eclipse.cdt.lsp.internal.clangd.ClangdLanguageServer.xml similarity index 59% rename from lsp/org.eclipse.cdt.lsp.core/OSGI-INF/org.eclipse.cdt.internal.clangd.ClangdLanguageServer.xml rename to lsp/org.eclipse.cdt.lsp.clangd/OSGI-INF/org.eclipse.cdt.lsp.internal.clangd.ClangdLanguageServer.xml index d139d35d2e1..8a3304ae03e 100644 --- a/lsp/org.eclipse.cdt.lsp.core/OSGI-INF/org.eclipse.cdt.internal.clangd.ClangdLanguageServer.xml +++ b/lsp/org.eclipse.cdt.lsp.clangd/OSGI-INF/org.eclipse.cdt.lsp.internal.clangd.ClangdLanguageServer.xml @@ -1,7 +1,7 @@ - + - + \ No newline at end of file diff --git a/lsp/org.eclipse.cdt.lsp.clangd/src/.gitkeep b/lsp/org.eclipse.cdt.lsp.clangd/src/.gitkeep deleted file mode 100644 index e69de29bb2d..00000000000 diff --git a/lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdLanguageServer.java b/lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdLanguageServer.java similarity index 95% rename from lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdLanguageServer.java rename to lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdLanguageServer.java index 43f97ec74f1..d41c9cb7f34 100644 --- a/lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdLanguageServer.java +++ b/lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdLanguageServer.java @@ -9,7 +9,7 @@ * SPDX-License-Identifier: EPL-2.0 *******************************************************************************/ -package org.eclipse.cdt.internal.clangd; +package org.eclipse.cdt.lsp.internal.clangd; import java.net.URI; diff --git a/lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdMessages.java b/lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdMessages.java similarity index 83% rename from lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdMessages.java rename to lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdMessages.java index ef31ff2245e..d029fc11c0b 100644 --- a/lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdMessages.java +++ b/lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdMessages.java @@ -11,18 +11,21 @@ * Contributors: * Alexander Fedorov (ArSysOp) - initial API and implementation *******************************************************************************/ -package org.eclipse.cdt.internal.clangd; +package org.eclipse.cdt.lsp.internal.clangd; import org.eclipse.osgi.util.NLS; public class ClangdMessages extends NLS { - private static final String BUNDLE_NAME = "org.eclipse.cdt.internal.clangd.ClangdMessages"; //$NON-NLS-1$ - public static String ClangdLanguageServer_label; + + private static final String BUNDLE_NAME = "org.eclipse.cdt.lsp.internal.clangd.ClangdMessages"; //$NON-NLS-1$ + static { // initialize resource bundle NLS.initializeMessages(BUNDLE_NAME, ClangdMessages.class); } + public static String ClangdLanguageServer_label; + private ClangdMessages() { } } diff --git a/lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdMessages.properties b/lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdMessages.properties similarity index 100% rename from lsp/org.eclipse.cdt.lsp.core/src/org/eclipse/cdt/internal/clangd/ClangdMessages.properties rename to lsp/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/internal/clangd/ClangdMessages.properties diff --git a/lsp/org.eclipse.cdt.lsp.core/META-INF/MANIFEST.MF b/lsp/org.eclipse.cdt.lsp.core/META-INF/MANIFEST.MF index fef4fd1b8d5..5b6dc3c613f 100644 --- a/lsp/org.eclipse.cdt.lsp.core/META-INF/MANIFEST.MF +++ b/lsp/org.eclipse.cdt.lsp.core/META-INF/MANIFEST.MF @@ -24,17 +24,15 @@ Require-Bundle: com.google.gson;bundle-version="2.8.2", Import-Package: org.eclipse.ui.editors.text, org.eclipse.ui.texteditor Export-Package: org.eclipse.cdt.cquery;x-friends:="org.eclipse.cdt.lsp.ui", - org.eclipse.cdt.internal.clangd;x-friends:="org.eclipse.cdt.lsp.ui", org.eclipse.cdt.internal.cquery;x-friends:="org.eclipse.cdt.lsp.ui", org.eclipse.cdt.internal.cquery.ui;x-internal:=true, - org.eclipse.cdt.lsp;x-friends:="org.eclipse.cdt.lsp.ui", + org.eclipse.cdt.lsp;x-friends:="org.eclipse.cdt.lsp.ui,org.eclipse.cdt.lsp.clangd", org.eclipse.cdt.lsp.core;x-friends:="org.eclipse.cdt.lsp.ui", org.eclipse.cdt.lsp.internal.core;x-internal:=true, org.eclipse.cdt.lsp.internal.text;x-friends:="org.eclipse.cdt.lsp.ui" Bundle-Activator: org.eclipse.cdt.lsp.core.Activator Bundle-ActivationPolicy: lazy Service-Component: OSGI-INF/org.eclipse.cdt.lsp.internal.core.ContributedLanguageServers.xml, - OSGI-INF/org.eclipse.cdt.internal.clangd.ClangdLanguageServer.xml, OSGI-INF/org.eclipse.cdt.internal.cquery.CqueryLanguageServer.xml, OSGI-INF/org.eclipse.cdt.lsp.internal.core.ContributedProtocolExtensions.xml, OSGI-INF/org.eclipse.cdt.internal.cquery.ui.CqueryProtocolExtension.xml