mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-11 02:05:39 +02:00
Code Issues Wiki Activity

[306563 ] - fixed false positives

Browse source
This commit is contained in:
Alena Laskavaia 2010-03-20 14:19:43 +00:00
parent e3b26be436
commit b239297541
3 changed files with 60 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
codan/org.eclipse.cdt.codan.checkers/plugin.xml
View file

@ -25,8 +25,9 @@
category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems" category="org.eclipse.cdt.codan.core.categories.ProgrammingProblems"
defaultSeverity="Warning" defaultSeverity="Warning"
id="org.eclipse.cdt.codan.internal.checkers.StatementHasNoEffectProblem" id="org.eclipse.cdt.codan.internal.checkers.StatementHasNoEffectProblem"
name="Statement has no effect"> name="Statement has no effect"
</problem> messagePattern="Statement has no effect"
/>
</checker> </checker>
<checker <checker

21
codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/StatementHasNoEffectChecker.java
View file

@ -36,10 +36,9 @@ import org.eclipse.cdt.internal.core.dom.parser.cpp.CPPASTBinaryExpression;
* *
*/ */
public class StatementHasNoEffectChecker extends AbstractIndexAstChecker { public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
private static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.StatementHasNoEffectProblem"; private static final String ER_ID = "org.eclipse.cdt.codan.internal.checkers.StatementHasNoEffectProblem"; //$NON-NLS-1$
public void processAst(IASTTranslationUnit ast) { public void processAst(IASTTranslationUnit ast) {
// traverse the ast using the visitor pattern.
ast.accept(new CheckStmpVisitor()); ast.accept(new CheckStmpVisitor());
} }
@ -52,7 +51,7 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
if (stmt instanceof IASTExpressionStatement) { if (stmt instanceof IASTExpressionStatement) {
if (hasNoEffect(((IASTExpressionStatement) stmt) if (hasNoEffect(((IASTExpressionStatement) stmt)
.getExpression())) { .getExpression())) {
reportProblem(ER_ID, stmt, "Statement has no effect"); reportProblem(ER_ID, stmt);
} }
return PROCESS_SKIP; return PROCESS_SKIP;
} }
@ -70,8 +69,20 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
private boolean hasNoEffect(IASTExpression e) { private boolean hasNoEffect(IASTExpression e) {
if (e instanceof IASTBinaryExpression) { if (e instanceof IASTBinaryExpression) {
IASTBinaryExpression binExpr = (IASTBinaryExpression) e; IASTBinaryExpression binExpr = (IASTBinaryExpression) e;
if (binExpr.getOperator() == IASTBinaryExpression.op_assign) switch (binExpr.getOperator()) {
case IASTBinaryExpression.op_assign:
case IASTBinaryExpression.op_binaryAndAssign:
case IASTBinaryExpression.op_binaryOrAssign:
case IASTBinaryExpression.op_binaryXorAssign:
case IASTBinaryExpression.op_divideAssign:
case IASTBinaryExpression.op_plusAssign:
case IASTBinaryExpression.op_minusAssign:
case IASTBinaryExpression.op_multiplyAssign:
case IASTBinaryExpression.op_moduloAssign:
case IASTBinaryExpression.op_shiftLeftAssign:
case IASTBinaryExpression.op_shiftRightAssign:
return false; return false;
}
if (binExpr instanceof CPPASTBinaryExpression) { if (binExpr instanceof CPPASTBinaryExpression) {
// unfortunately ICPPASTBinaryExpression does not have // unfortunately ICPPASTBinaryExpression does not have
// getOverload public method // getOverload public method
@ -97,6 +108,8 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
case IASTUnaryExpression.op_postFixIncr: case IASTUnaryExpression.op_postFixIncr:
case IASTUnaryExpression.op_prefixIncr: case IASTUnaryExpression.op_prefixIncr:
return false; return false;
case IASTUnaryExpression.op_bracketedPrimary:
return hasNoEffect(unaryExpr.getOperand());
} }
return true; return true;
} }

43
codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/checkers/sample/StatementHasNoEffectCheckerTest.java
View file

@ -25,7 +25,7 @@ public class StatementHasNoEffectCheckerTest extends CheckerTestCase {
} }
</code> </code>
*/ */
public void test1() { public void testUnaryExpression() {
load("test1.c"); load("test1.c");
runOnFile(); runOnFile();
checkErrorLine(3); checkErrorLine(3);
@ -40,7 +40,7 @@ public class StatementHasNoEffectCheckerTest extends CheckerTestCase {
} }
</code> </code>
*/ */
public void test2() { public void testBinaryExpression() {
load("test2.c"); load("test2.c");
runOnFile(); runOnFile();
checkErrorLine(4); checkErrorLine(4);
@ -55,9 +55,46 @@ public class StatementHasNoEffectCheckerTest extends CheckerTestCase {
} }
</code> </code>
*/ */
public void test3() { public void testNormalAssignment() {
load("test3.c"); load("test3.c");
runOnFile(); runOnFile();
checkNoErrors(); checkNoErrors();
} }
/*-
<code file="test4.c">
main() {
int a,b;
(a=b); // no errors here
a+=b;
a<<=b;
a-=b;
a++;
b--;
--a;
++b;
a%=2;
a>>=2;
}
</code>
*/
public void testFalsePositives() {
load("test4.c");
runOnFile();
checkNoErrors();
}
/*-
<code file="test5.c">
main() {
int a;
a; // error here on line 3
}
</code>
*/
public void testIdExpression() {
load("test5.c");
runOnFile();
checkErrorLine(3);
}
} }