From ac5c884286fac6d55f5b8a42007335c2d1e4c438 Mon Sep 17 00:00:00 2001 From: Doug Schaefer Date: Tue, 11 Jul 2017 12:12:56 -0400 Subject: [PATCH] Add some logging to debug test failures we're seeing on Linux. Change-Id: I570733a2d3c81937a59cfa2aa93dfc98f6b6d325 --- .../eclipse/launchbar/ui/controls/internal/Activator.java | 3 +++ .../eclipse/launchbar/ui/controls/internal/CSelector.java | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/Activator.java b/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/Activator.java index 363516acea0..651bac3e78b 100644 --- a/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/Activator.java +++ b/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/Activator.java @@ -80,4 +80,7 @@ public class Activator extends AbstractUIPlugin { plugin.getLog().log(status); } + public static void log(String msg) { + plugin.getLog().log(new Status(IStatus.ERROR, PLUGIN_ID, msg)); + } } diff --git a/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/CSelector.java b/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/CSelector.java index 55948f7745c..0b24dad0993 100644 --- a/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/CSelector.java +++ b/bundles/org.eclipse.launchbar.ui.controls/src/org/eclipse/launchbar/ui/controls/internal/CSelector.java @@ -295,6 +295,7 @@ public abstract class CSelector extends Composite { } protected void openPopup() { + Activator.log(CSelector.this.getClass().getName() + " opening"); Object[] elements = contentProvider.getElements(input); if (elements.length == 0 && !hasActionArea()) return; @@ -342,6 +343,7 @@ public abstract class CSelector extends Composite { saveShellSize(); } }); + Activator.log(CSelector.this.getClass().getName() + " openned"); } protected String getDialogPreferencePrefix() { @@ -382,14 +384,18 @@ public abstract class CSelector extends Composite { } private void closePopup() { + Activator.log(new Throwable(CSelector.this.getClass().getName() + " close requested")); getDisplay().asyncExec(new Runnable() { @Override public void run() { - if (popup == null || popup.isDisposed()) + if (popup == null || popup.isDisposed()) { + Activator.log(CSelector.this.getClass().getName() + " close aborted"); return; + } arrowTransition.to(arrowMax); popup.setVisible(false); popup.dispose(); + Activator.log(CSelector.this.getClass().getName() + " closed"); } }); }