mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-23 22:52:11 +02:00
Code Issues Wiki Activity

Bug 433329 - Thread-specific bp created from gdb console loose their

Browse source 
thread-specific state

Change-Id: I7474c8e139545a723ddbebbaf92574ebf8547874
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25578
This commit is contained in:
Marc Khouzam 2014-04-25 13:15:05 -04:00
parent 5216346374
commit ab445bbf47
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIBreakpointsManager.java
View file

@ -1180,7 +1180,16 @@ public class MIBreakpointsManager extends AbstractDsfService implements IBreakpo
for (IDMContext dmc : getData()) { for (IDMContext dmc : getData()) {
IContainerDMContext containerDmc = DMContexts.getAncestorOfType(dmc, IContainerDMContext.class); IContainerDMContext containerDmc = DMContexts.getAncestorOfType(dmc, IContainerDMContext.class);
assert containerDmc != null; assert containerDmc != null;
if (filterExtension.getThreadFilters(containerDmc) == null) {
// Do this only if there wasn't already an entry, or else we would
// erase the content of that previous entry.
// There can be an entry already when a thread-specific breakpoint is created
// from the MIBreakpointsSynchronizer (through the gdb console). In that case the
// platform bp gets created, and the targetFilter gets set by MIBreakpointsSynchronizer
// before the call to breakpointAdded() is made and we get to here.
// Bug 433339
filterExtension.setTargetFilter(containerDmc); filterExtension.setTargetFilter(containerDmc);
}
} }
} catch (CoreException e1) { } catch (CoreException e1) {
// Error setting target filter, just skip altogether // Error setting target filter, just skip altogether
@ -1479,7 +1488,15 @@ public class MIBreakpointsManager extends AbstractDsfService implements IBreakpo
private void setTargetFilter(ICBreakpoint breakpoint, IContainerDMContext containerDmc) { private void setTargetFilter(ICBreakpoint breakpoint, IContainerDMContext containerDmc) {
try { try {
IDsfBreakpointExtension filterExt = getFilterExtension(breakpoint); IDsfBreakpointExtension filterExt = getFilterExtension(breakpoint);
if (filterExt.getThreadFilters(containerDmc) == null) {
// Do this only if there wasn't already an entry, or else we would
// erase the content of that previous entry.
// This could theoretically happen if the targetFilter is set by
// someone else, before the IStartedDMEvent arrives indicating a new process.
// Bug 433339
filterExt.setTargetFilter(containerDmc); filterExt.setTargetFilter(containerDmc);
}
} catch (CoreException e) { } catch (CoreException e) {
} }
} }