mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

fix more warnings

Browse source
This commit is contained in:
Andrew Ferguson 2008-04-29 14:15:45 +00:00
parent 1d5e7d407b
commit ab41c57c9f
4 changed files with 12 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/org.eclipse.cdt.core/templateengine/org/eclipse/cdt/core/templateengine/TemplateDescriptor.java
View file

@ -110,10 +110,8 @@ public class TemplateDescriptor {
/** /**
* This method is to get the list of property-group elements from template * This method is to get the list of property-group elements from template
* descriptor root element * descriptor root element.
* *
* @param aRootElement
* root element of type JDOM Element
* @return list of property-group elements * @return list of property-group elements
*/ */
public List<Element> getPropertyGroupList() { public List<Element> getPropertyGroupList() {
@ -156,7 +154,7 @@ public class TemplateDescriptor {
Element nextPGElement = propertyGroupList.get(i); Element nextPGElement = propertyGroupList.get(i);
if (isNestedElement(nextPGElement)) if (isNestedElement(nextPGElement))
nextPGElementName = nextPGElement.getNodeName(); nextPGElementName = nextPGElement.getNodeName();
if (nextPGElementName.equalsIgnoreCase(PROPERTY_GROUP) && isNestedElement(nextPGElement)) { if (PROPERTY_GROUP.equalsIgnoreCase(nextPGElementName) && isNestedElement(nextPGElement)) {
return nextPGElement; return nextPGElement;
} }
} }

3
core/org.eclipse.cdt.core/templateengine/org/eclipse/cdt/core/templateengine/process/ConditionalProcessGroup.java
View file

@ -253,8 +253,7 @@ public class ConditionalProcessGroup {
} }
/** /**
* Returns All Macros as a Set. * @return the union of all macros used in the child processes
* @return Set, contains macros
*/ */
public Set<String> getAllMacros() { public Set<String> getAllMacros() {
Set<String> set = null; Set<String> set = null;

20
core/org.eclipse.cdt.core/templateengine/org/eclipse/cdt/core/templateengine/process/ProcessHelper.java
View file

@ -43,10 +43,8 @@ public class ProcessHelper {
/** /**
* This method is to append the given contents into a file. * This method is to append the given contents into a file.
* *
* @param fileContents, * @param fileContents contents which are appended to the file.
* contents which are appended to the file. * @param toFile a file to append contents.
* @param toFile,
* a file to append contents.
* @throws IOException, * @throws IOException,
* exception while writing contents into a file * exception while writing contents into a file
* *
@ -62,7 +60,9 @@ public class ProcessHelper {
raf.skipBytes((int) raf.length()); raf.skipBytes((int) raf.length());
raf.writeBytes(fileContents); raf.writeBytes(fileContents);
} finally { } finally {
raf.close(); if(raf != null) {
raf.close();
}
} }
} }
} }
@ -71,8 +71,7 @@ public class ProcessHelper {
* This method returns a vector of all replace marker strings. (e.g., * This method returns a vector of all replace marker strings. (e.g.,
* $(item), vector contains 'item' as one item. , ) is the end pattern. * $(item), vector contains 'item' as one item. , ) is the end pattern.
* *
* @param str, * @param str A given string possibly containing markers.
* A given string possibly containing markers.
* @return the set of names occurring within markers * @return the set of names occurring within markers
* @since 4.0 * @since 4.0
*/ */
@ -172,11 +171,10 @@ public class ProcessHelper {
/** /**
* Returns the Macro Value after expanding the Macros.
* @param string * @param string
* @param macros * @param macros
* @param valueStore * @param valueStore
* @return * @return the Macro Value after expanding the Macros.
* *
* @since 4.0 * @since 4.0
*/ */
@ -192,10 +190,8 @@ public class ProcessHelper {
} }
/** /**
* Construct and return the replacement markers
* after adding the patterns to the macro.
* @param macro * @param macro
* @return * @return the replacement marker string
* *
* @since 4.0 * @since 4.0
*/ */

3
core/org.eclipse.cdt.core/templateengine/org/eclipse/cdt/core/templateengine/process/TemplateProcessHandler.java
View file

@ -71,8 +71,7 @@ public class TemplateProcessHandler {
} }
/** /**
* Returns all macros * @return the union of all macros used in this template's process groups
* @return
*/ */
public Set<String> getAllMacros() { public Set<String> getAllMacros() {
Set<String> set = new HashSet<String>(); Set<String> set = new HashSet<String>();