From a9a9a085ea9f5c375fc2acf1e39236710d462e85 Mon Sep 17 00:00:00 2001
From: Martin Oberhuber <martin.oberhuber@windriver.com>
Date: Thu, 18 Dec 2008 17:03:57 +0000
Subject: [PATCH] Add FIXME comments for future Terminal API.

---
 .../provisional/api/ITerminalConnector.java      | 16 ++++++++++------
 .../terminal/provisional/api/TerminalState.java  | 14 +++++++-------
 2 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java b/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java
index 3a389b75094..c8dcc844d26 100644
--- a/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java
+++ b/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java
@@ -29,14 +29,14 @@ import org.eclipse.tm.internal.terminal.provisional.api.provider.TerminalConnect
  * communications. This pattern allows for lazy initialization, bundle
  * activation and class loading of the actual {@link TerminalConnectorImpl}
  * instance.
- * 
+ *
  * Clients can get terminal connector instances from the
  * {@link TerminalConnectorExtension} class, or from
  * {@link ITerminalViewControl#getTerminalConnector()} when running inside an
  * active terminal widget.
- * 
+ *
  * @noimplement This interface is not intended to be implemented by clients.
- * 
+ *
  * @author Michael Scharf
  *         <p>
  *         <strong>EXPERIMENTAL</strong>. This class or interface has been
@@ -125,10 +125,14 @@ public interface ITerminalConnector extends IAdaptable {
 	void save(ISettingsStore store);
 
 	/**
+	 * FIXME should not have UI related stuff in ITerminalConnector, since
+	 * connectors may be totally programmatic and UI-less. Better make the
+	 * connector adapt to an interface that controls the UI aspect.
+	 * 
 	 * @return a new page that can be used in a dialog to setup this connection.
-	 * The dialog should persist its settings with the {@link #load(ISettingsStore)}
-	 * and {@link #save(ISettingsStore)} methods.
-	 *
+	 *         The dialog should persist its settings with the
+	 *         {@link #load(ISettingsStore)} and {@link #save(ISettingsStore)}
+	 *         methods.
 	 */
 	ISettingsPage makeSettingsPage();
 
diff --git a/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalState.java b/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalState.java
index 308bd9fdcfe..5c7112c1c21 100644
--- a/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalState.java
+++ b/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalState.java
@@ -1,11 +1,11 @@
 /*******************************************************************************
  * Copyright (c) 2006, 2007 Wind River Systems, Inc. and others.
- * All rights reserved. This program and the accompanying materials 
- * are made available under the terms of the Eclipse Public License v1.0 
- * which accompanies this distribution, and is available at 
- * http://www.eclipse.org/legal/epl-v10.html 
- * 
- * Contributors: 
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
  * Michael Scharf (Wind River) - initial API and implementation
  * Martin Oberhuber (Wind River) - fixed copyright headers and beautified
  *******************************************************************************/
@@ -30,7 +30,7 @@ public class TerminalState {
 	public final static TerminalState CLOSED=new TerminalState("CLOSED"); //$NON-NLS-1$
 
 	/**
-	 * TODO: Michael Scharf: it's not clear to me what the meaning of the open state is
+	 * FIXME Get rid of this state it is equivalent to CONNECTING.
 	 */
 	public final static TerminalState OPENED=new TerminalState("OPENED"); //$NON-NLS-1$