From a7c9cf50528d650a08451ed1c74b9e6c9bd7b279 Mon Sep 17 00:00:00 2001 From: Vivian Kong Date: Wed, 20 Apr 2011 18:21:46 +0000 Subject: [PATCH] Bug 133881 - Make refreshing after building optional Work in progress. --- .../ui/properties/RefreshPolicyExceptionDialog.java | 3 ++- .../managedbuilder/ui/properties/RefreshPolicyTab.java | 10 ++-------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyExceptionDialog.java b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyExceptionDialog.java index e377854c31c..5e27804c3f0 100644 --- a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyExceptionDialog.java +++ b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyExceptionDialog.java @@ -31,6 +31,7 @@ import org.eclipse.swt.widgets.Label; import org.eclipse.swt.widgets.Shell; /** + * The RefreshPolicyExceptionDialog allows users to add or edit a refresh exclusion. * * EXPERIMENTAL. This class or interface has been added as * part of a work in progress. There is no guarantee that this API will work or @@ -54,7 +55,7 @@ public class RefreshPolicyExceptionDialog extends Dialog { //should only be used by the Add Exception dialog private java.util.List fExclusionContributors; - private RefreshPolicyExceptionDialog(Shell parent, boolean addException){ + private RefreshPolicyExceptionDialog(Shell parent, boolean addException){ super(parent); setShellStyle(getShellStyle()); fContrManager = RefreshExclusionContributionManager.getInstance(); diff --git a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyTab.java b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyTab.java index baf2c03ab69..a7f91731a41 100644 --- a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyTab.java +++ b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/RefreshPolicyTab.java @@ -53,6 +53,7 @@ import org.eclipse.swt.widgets.TreeItem; import org.eclipse.ui.dialogs.ContainerSelectionDialog; /** + * The RefreshPolicyTab allows users to modify a project's refresh settings for each build. * * EXPERIMENTAL. This class or interface has been added as * part of a work in progress. There is no guarantee that this API will work or @@ -186,14 +187,10 @@ public class RefreshPolicyTab extends AbstractCPropertyTab { List exclusionInstancesToAdd = exclusion.getExclusionInstances(); Iterator iterator = exclusionInstancesToAdd.iterator(); exclusion_instances.clear(); -// List exclusionInstancesToRemove = this.exclusion.getExclusionInstances(); -// for (int i = 0; i < exclusionInstancesToRemove.size(); i++) { -// this.exclusion.removeExclusionInstance(exclusionInstancesToRemove.get(i)); -// } + while (iterator.hasNext()) { ExclusionInstance instanceToAdd = iterator.next(); exclusion_instances.add(new _Exclusion_Instance(instanceToAdd, this)); -// this.exclusion.addExclusionInstance(instanceToAdd); } } @@ -224,8 +221,6 @@ public class RefreshPolicyTab extends AbstractCPropertyTab { } - - class _Exception_Node { _Entry parent; //can be IResource or RefreshExclusion - must not be null @@ -590,6 +585,5 @@ public class RefreshPolicyTab extends AbstractCPropertyTab { List exclusions = fResourceToExclusionsMap.get(resource); fManager.setExclusions(resource, exclusions); } - } }