From a7746e4e9ef25140f9029fdf6e1ac5d2dbb28369 Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Fri, 14 Jan 2022 12:19:46 -0500 Subject: [PATCH] Bug 578219: Make the FileDialog in Copy Build Log a Save dialog Prior to this it was SWT.NONE which is now being interpreted as an Open dialog which means an existing file must be selected. In some conditions the SWT.NONE would allow a new file to be entered that didn't exist already, so this did not affect everyone. With this change a normal Save dialog is presented, and the OS confirm overwrite is enabled. Change-Id: Iea8c4211f8d9fe0c2f4d423780d91a62f6d3edab --- .../cdt/internal/ui/buildconsole/CopyBuildLogAction.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java index a66c17f9695..e576db8b085 100644 --- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java +++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/buildconsole/CopyBuildLogAction.java @@ -80,7 +80,8 @@ public class CopyBuildLogAction extends Action { } // open file dialog - FileDialog dialog = new FileDialog(shell, SWT.NONE); + FileDialog dialog = new FileDialog(shell, SWT.SAVE); + dialog.setOverwrite(true); dialog.setText(ConsoleMessages.CopyLog_ChooseDestination); String destLocation = dialog.open();