mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Code Issues Wiki Activity

Fixing NPE in ACBuilder

Browse source 
ACBuilder now fails to add a marker if some other marker have no
linumber attribute. Added default line and severity for marker
comparision purposes.

Change-Id: I9c42f660cae08c3303382d8c35aa6404e7130652
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31398
Tested-by: Hudson CI
This commit is contained in:
Alena Laskavaia 2014-08-11 15:02:00 -04:00 • committed by Elena Laskavaia
parent 4dd9a12177
commit a458a0fe9f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/org.eclipse.cdt.core/src/org/eclipse/cdt/core/resources/ACBuilder.java
View file

@ -75,8 +75,8 @@ public abstract class ACBuilder extends IncrementalProjectBuilder implements IMa
// Try to find matching markers and don't put in duplicates
IMarker[] markers = markerResource.findMarkers(ICModelMarker.C_MODEL_PROBLEM_MARKER, true, IResource.DEPTH_ONE);
for (IMarker m : markers) {
int line = ((Integer) m.getAttribute(IMarker.LINE_NUMBER)).intValue();
int sev = ((Integer) m.getAttribute(IMarker.SEVERITY)).intValue();
int line = m.getAttribute(IMarker.LINE_NUMBER, -1);
int sev = m.getAttribute(IMarker.SEVERITY, -1);
String msg = (String) m.getAttribute(IMarker.MESSAGE);
if (line == problemMarkerInfo.lineNumber && sev == mapMarkerSeverity(problemMarkerInfo.severity) && msg.equals(problemMarkerInfo.description)) {
String extloc = (String) m.getAttribute(ICModelMarker.C_MODEL_MARKER_EXTERNAL_LOCATION);