mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

remove side effect of findInsertLocation()

Browse source
This commit is contained in:
Emanuel Graf 2008-11-12 12:46:30 +00:00
parent e9b5691317
commit a33b8d111f
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/implementmethod/ImplementMethodRefactoring.java
View file

@ -94,7 +94,7 @@ public class ImplementMethodRefactoring extends CRefactoring {
parameterHandler.initArgumentNames(); parameterHandler.initArgumentNames();
sm.worked(1); sm.worked(1);
sm.done(); sm.done();
findInsertLocation(); insertLocation = findInsertLocation();
sm.worked(1); sm.worked(1);
sm.done(); sm.done();
return initStatus; return initStatus;
@ -136,13 +136,15 @@ public class ImplementMethodRefactoring extends CRefactoring {
} }
} }
private void findInsertLocation() throws CoreException { private InsertLocation findInsertLocation() throws CoreException {
insertLocation = MethodDefinitionInsertLocationFinder.find(methodDeclaration.getFileLocation(), methodDeclaration.getParent(), file); InsertLocation insertLocation = MethodDefinitionInsertLocationFinder.find(methodDeclaration.getFileLocation(), methodDeclaration.getParent(), file);
if (!insertLocation.hasFile() || NodeHelper.isContainedInTemplateDeclaration(methodDeclaration)) { if (!insertLocation.hasFile() || NodeHelper.isContainedInTemplateDeclaration(methodDeclaration)) {
insertLocation.setInsertFile(file); insertLocation.setInsertFile(file);
insertLocation.setNodeToInsertAfter(NodeHelper.findTopLevelParent(methodDeclaration)); insertLocation.setNodeToInsertAfter(NodeHelper.findTopLevelParent(methodDeclaration));
} }
return insertLocation;
} }
private void createFunctionDefinition(IASTTranslationUnit unit) throws CoreException { private void createFunctionDefinition(IASTTranslationUnit unit) throws CoreException {