mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-21 07:05:58 +02:00
Code Issues Wiki Activity

[210812] for text transfer, need honour preference instead of straight binary

Browse source
This commit is contained in:
David McKnight 2007-11-23 20:58:12 +00:00
parent 02e91e10d7
commit a240d92192
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/internal/services/dstore/files/DStoreFileService.java
View file

@ -26,6 +26,7 @@
* David McKnight (IBM) - [209423] Fix for null pointer - filter attributes need unique ids * David McKnight (IBM) - [209423] Fix for null pointer - filter attributes need unique ids
* David McKnight (IBM) - [209552] API changes to use multiple and getting rid of deprecated * David McKnight (IBM) - [209552] API changes to use multiple and getting rid of deprecated
* David McKnight (IBM) - [210109] store constants in IFileService rather than IFileServiceConstants * David McKnight (IBM) - [210109] store constants in IFileService rather than IFileServiceConstants
* David McKnight (IBM) - [210812] for text transfer, need to honour the preference (instead of straight binary)
********************************************************************************/ ********************************************************************************/
package org.eclipse.rse.internal.services.dstore.files; package org.eclipse.rse.internal.services.dstore.files;
@ -674,9 +675,7 @@ public class DStoreFileService extends AbstractDStoreService implements IFileSer
DataStore ds = getDataStore(); DataStore ds = getDataStore();
DataElement universaltemp = getMinerElement(); DataElement universaltemp = getMinerElement();
// just download as binary since we do not have to convert to UTF-8 anyway int mode = isBinary ? IUniversalDataStoreConstants.BINARY_MODE : IUniversalDataStoreConstants.TEXT_MODE;
// the miner does a binary download anyway
int mode = IUniversalDataStoreConstants.BINARY_MODE;
if (!makeSureLocalExists(localFile)) if (!makeSureLocalExists(localFile))
{ {
@ -684,9 +683,6 @@ public class DStoreFileService extends AbstractDStoreService implements IFileSer
} }
String remotePath = remoteParent + getSeparator(remoteParent) + remoteFile; String remotePath = remoteParent + getSeparator(remoteParent) + remoteFile;
DataElement de = getElementFor(remotePath); DataElement de = getElementFor(remotePath);
@ -882,10 +878,9 @@ public class DStoreFileService extends AbstractDStoreService implements IFileSer
// kick off all downloads // kick off all downloads
int mode = IUniversalDataStoreConstants.BINARY_MODE;
for (int i = 0; i < des.length && result == true; i++) for (int i = 0; i < des.length && result == true; i++)
{ {
int mode = isBinaries[i] ? IUniversalDataStoreConstants.BINARY_MODE : IUniversalDataStoreConstants.TEXT_MODE;
DataElement de = des[i]; DataElement de = des[i];
String remotePath = paths[i]; String remotePath = paths[i];