From a15514c96441cd9395d39f6f3fd91f21e07a832c Mon Sep 17 00:00:00 2001 From: Tam Dang Date: Tue, 18 Mar 2025 15:44:23 +0700 Subject: [PATCH] Build Type comboBox false update when switching tab The Build type combo custom value was lost when switching to another tab and back again. Solution: Add modifyListener for buildTypeCombo and generator combo to keep properties up-to-date when switching tab. This fixes #1118 --- .../src/org/eclipse/cdt/cmake/ui/internal/CMakeBuildTab.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmake/org.eclipse.cdt.cmake.ui/src/org/eclipse/cdt/cmake/ui/internal/CMakeBuildTab.java b/cmake/org.eclipse.cdt.cmake.ui/src/org/eclipse/cdt/cmake/ui/internal/CMakeBuildTab.java index eb61d63aa86..3c67a8eb81e 100644 --- a/cmake/org.eclipse.cdt.cmake.ui/src/org/eclipse/cdt/cmake/ui/internal/CMakeBuildTab.java +++ b/cmake/org.eclipse.cdt.cmake.ui/src/org/eclipse/cdt/cmake/ui/internal/CMakeBuildTab.java @@ -96,6 +96,7 @@ public class CMakeBuildTab extends CommonBuildTab { generatorCombo = new Combo(cmakeGroup, SWT.DROP_DOWN); generatorCombo.setItems(generatorNames); generatorCombo.select(0); + generatorCombo.addModifyListener(e -> updateLaunchConfigurationDialog()); generatorCombo.addSelectionListener(new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) { @@ -142,6 +143,7 @@ public class CMakeBuildTab extends CommonBuildTab { buildTypeCombo = new Combo(buildTypeComp, SWT.DROP_DOWN); buildTypeCombo.setItems(buildTypes); buildTypeCombo.setToolTipText(Messages.CMakeBuildTab_BuildTypeCombo_Tooltip); + buildTypeCombo.addModifyListener(e -> updateLaunchConfigurationDialog()); buildTypeCombo.addSelectionListener(new SelectionAdapter() { @Override public void widgetSelected(SelectionEvent e) {