From a0cde25ac6dab71737aa2ed134fb7a853f536cc9 Mon Sep 17 00:00:00 2001 From: Michael Scharf Date: Thu, 27 Sep 2007 12:33:45 +0000 Subject: [PATCH] bug 204794: [terminal] StringIndexOutOfBoundException when selecting text and doing right-click https://bugs.eclipse.org/bugs/show_bug.cgi?id=204794 check for negative column and do not copy in that case --- .../internal/terminal/textcanvas/AbstractTextCanvasModel.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/textcanvas/AbstractTextCanvasModel.java b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/textcanvas/AbstractTextCanvasModel.java index 098d84b694c..07238ebbfe7 100644 --- a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/textcanvas/AbstractTextCanvasModel.java +++ b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/textcanvas/AbstractTextCanvasModel.java @@ -228,9 +228,7 @@ abstract public class AbstractTextCanvasModel implements ITextCanvasModel { } public String getSelectedText() { - if(fSelectionStartLine<0 || fSelectionSnapshot==null) - return ""; //$NON-NLS-1$ - if(fSelectionStartLine<0 || fSelectionSnapshot==null) + if(fSelectionStartLine<0 || fSelectionStartCoumn<0|| fSelectionSnapshot==null) return ""; //$NON-NLS-1$ StringBuffer buffer=new StringBuffer(); for (int line = fSelectionStartLine; line <= fSeletionEndLine; line++) {