From 9de6de9fd4271013d16270d996a5bbb15b385c42 Mon Sep 17 00:00:00 2001
From: Sergey Prigogin <eclipse.sprigogin@gmail.com>
Date: Fri, 6 Feb 2015 14:12:02 -0800
Subject: [PATCH] Revert "Bug 459186 - Index read locks are leaking"

This reverts commit dc08061cc669d58f2579d310aa2e20eb84387e0d.
---
 .../ui/actions/SurroundWithTemplateMenuAction.java | 14 +++++---------
 .../contentassist/ParameterGuessingProposal.java   | 12 +++---------
 2 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/SurroundWithTemplateMenuAction.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/SurroundWithTemplateMenuAction.java
index 57d136d2069..96dc6624cb3 100644
--- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/SurroundWithTemplateMenuAction.java
+++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/actions/SurroundWithTemplateMenuAction.java
@@ -272,15 +272,11 @@ public class SurroundWithTemplateMenuAction implements IWorkbenchWindowPulldownD
 		TemplateCompletionProposalComputer templateComputer = new TemplateCompletionProposalComputer();
 		CContentAssistInvocationContext context = new CContentAssistInvocationContext( editor.getViewer(), textSelection.getOffset(), editor, true, false );
 
-		try {
-			List<ICompletionProposal> proposals= templateComputer.computeCompletionProposals(context, null);
-			if (proposals == null || proposals.isEmpty())
-				return null;
-	
-			return getActionsFromProposals(proposals, context.getInvocationOffset(), editor.getViewer());
-		} finally {
-			context.dispose();
-		}
+		List<ICompletionProposal> proposals= templateComputer.computeCompletionProposals(context, null);
+		if (proposals == null || proposals.isEmpty())
+			return null;
+
+		return getActionsFromProposals(proposals, context.getInvocationOffset(), editor.getViewer());
 	}
 
 	private static ITextSelection getTextSelection(CEditor editor) {
diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/ParameterGuessingProposal.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/ParameterGuessingProposal.java
index 2107d9daff2..7e252eebf40 100644
--- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/ParameterGuessingProposal.java
+++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/ParameterGuessingProposal.java
@@ -358,19 +358,13 @@ public class ParameterGuessingProposal extends FunctionCompletionProposal {
 	}
 
 	/**
-	 * Returns a list of functions and variables that are defined in the current context.
+	 * Returns a list of functions and variables that are defined in current context.
 	 * @return a list of assignable elements.
 	 */
 	private List<IBinding> getAssignableElements() {
 		int i = getStatementStartOffset(fContext.getDocument(), getStatementStartOffset());
-		CContentAssistInvocationContext context =
-				new CContentAssistInvocationContext(fTextViewer, i, getCEditor(), true, false);
-		IASTCompletionNode node;
-		try {
-			node = context.getCompletionNode();
-		} finally {
-			context.dispose();
-		}
+		CContentAssistInvocationContext c = new CContentAssistInvocationContext(fTextViewer, i, getCEditor(), true, false);
+		IASTCompletionNode node = c.getCompletionNode();
 		IASTName[] names = node.getNames();
 		List<IBinding> allBindings = new ArrayList<>();
 		for (IASTName name : names) {