From 9db32e36990f41e945faba96575acf4ba0b2a39e Mon Sep 17 00:00:00 2001 From: Martin Oberhuber < martin.oberhuber@windriver.com> Date: Tue, 3 Jun 2008 23:29:09 +0000 Subject: [PATCH] [cleanup] Add comments about failing testcases --- .../rse/tests/subsystems/files/FileServiceTest.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/subsystems/files/FileServiceTest.java b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/subsystems/files/FileServiceTest.java index e99c51b6ed7..263af92f0c1 100644 --- a/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/subsystems/files/FileServiceTest.java +++ b/rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/subsystems/files/FileServiceTest.java @@ -134,7 +134,7 @@ public class FileServiceTest extends RSEBaseConnectionTestCase { for (int i = 0; i < roots.length; i++) { assertTrue(roots[i].isRoot()); assertTrue(roots[i].exists()); - assertNull(roots[i].getParentPath()); + assertNull(roots[i].getParentPath()); //dstore: bug 235471 String rootName = roots[i].getName(); assertNotNull(rootName); System.out.println(rootName); @@ -169,7 +169,7 @@ public class FileServiceTest extends RSEBaseConnectionTestCase { if (!RSETestsPlugin.isTestCaseEnabled("FileServiceTest.testCreateFile")) return; //$NON-NLS-1$ String testName = getTestFileName(); - IHostFile hf = fs.createFile(tempDirPath, testName, mon); + IHostFile hf = fs.createFile(tempDirPath, testName, mon); //dstore-linux: bug 235492 assertTrue(hf.exists()); assertTrue(hf.canRead()); assertTrue(hf.canWrite()); @@ -217,7 +217,11 @@ public class FileServiceTest extends RSEBaseConnectionTestCase { //Different abstract path names but denote the same file //Should be equal since java.io.File treats them as equal assertEquals(new File(tempDirPath, testName), new File(tempDirPath, testName2)); - assertEquals(hf, hf2); //bug 168591: should be equal + ////While the file handles were created with different names, + ////resolving them should return the same name (the one that's on disk) + ////But Local and java.io.File do not work that way + //assertEquals(hf.getName(), hf2.getName()); + assertEquals(hf, hf2); //bug 168591, bug 235489: no equals() for IHostFile } }