From 9be5d99cc10096863c920e5888939ac7602c1f01 Mon Sep 17 00:00:00 2001 From: Martin Oberhuber < martin.oberhuber@windriver.com> Date: Tue, 29 Aug 2006 12:20:07 +0000 Subject: [PATCH] [cleanup] fix 'local variable/field is never read' compiler warnings --- .../AbstractSystemNewConnectionWizardPage.java | 12 +++++------- .../ui/wizards/ISystemNewConnectionWizardPage.java | 2 +- .../core/subsystems/ISubSystemConfiguration.java | 13 ++++++------- 3 files changed, 12 insertions(+), 15 deletions(-) diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/AbstractSystemNewConnectionWizardPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/AbstractSystemNewConnectionWizardPage.java index fea2cbd5e7a..b6edee76803 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/AbstractSystemNewConnectionWizardPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/AbstractSystemNewConnectionWizardPage.java @@ -17,8 +17,6 @@ package org.eclipse.rse.ui.wizards; import org.eclipse.jface.wizard.IWizard; import org.eclipse.jface.wizard.IWizardPage; -import org.eclipse.rse.core.IRSESystemType; -import org.eclipse.rse.core.RSECorePlugin; import org.eclipse.rse.core.subsystems.ISubSystemConfiguration; import org.eclipse.rse.ui.SystemConnectionForm; import org.eclipse.rse.ui.SystemResources; @@ -28,7 +26,7 @@ import org.eclipse.swt.widgets.Control; /** * A base class for additional pages that are to be appended to the New Connection wizard. - * @see org.eclipse.rse.core.subsystems.ISubSystemConfiguration#getNewConnectionWizardPages(IWizard) + * @see org.eclipse.rse.core.subsystems.util.ISubSystemConfigurationAdapter#getNewConnectionWizardPages(ISubSystemConfiguration, org.eclipse.jface.wizard.IWizard) */ public abstract class AbstractSystemNewConnectionWizardPage extends AbstractSystemWizardPage implements ISystemNewConnectionWizardPage @@ -113,8 +111,8 @@ public abstract class AbstractSystemNewConnectionWizardPage extends AbstractSyst { RSENewConnectionWizard ourWizard = getNewConnectionWizard(); if (ourWizard != null) { - String[] systemTypes = parentFactory.getSystemTypes(); - IRSESystemType systemType = RSECorePlugin.getDefault().getRegistry().getSystemType(systemTypes[0]); + //String[] systemTypes = parentFactory.getSystemTypes(); + //IRSESystemType systemType = RSECorePlugin.getDefault().getRegistry().getSystemType(systemTypes[0]); IWizardPage wizardPage = ourWizard.getDelegate().getMainPage(); if (wizardPage instanceof ISystemNewConnectionWizardMainPage) { @@ -137,8 +135,8 @@ public abstract class AbstractSystemNewConnectionWizardPage extends AbstractSyst { RSENewConnectionWizard ourWizard = getNewConnectionWizard(); if (ourWizard != null) { - String[] systemTypes = parentFactory.getSystemTypes(); - IRSESystemType systemType = RSECorePlugin.getDefault().getRegistry().getSystemType(systemTypes[0]); + //String[] systemTypes = parentFactory.getSystemTypes(); + //IRSESystemType systemType = RSECorePlugin.getDefault().getRegistry().getSystemType(systemTypes[0]); IWizardPage wizardPage = ourWizard.getDelegate().getMainPage(); if (wizardPage instanceof RSENewConnectionWizardDefaultDelegateMainPage) { diff --git a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/ISystemNewConnectionWizardPage.java b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/ISystemNewConnectionWizardPage.java index 503e291d3b2..60aec389215 100644 --- a/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/ISystemNewConnectionWizardPage.java +++ b/rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/ISystemNewConnectionWizardPage.java @@ -23,7 +23,7 @@ import org.eclipse.rse.core.subsystems.ISubSystemConfiguration; * Interface that all subsystem factory supplied pages contributed to the New Connection wizard * must implement. * @see org.eclipse.rse.ui.wizards.AbstractSystemNewConnectionWizardPage - * @see org.eclipse.rse.core.subsystems.ISubSystemConfiguration#getNewConnectionWizardPages(IWizard) + * @see org.eclipse.rse.ui.view.SubSystemConfigurationAdapter#getNewConnectionWizardPages(org.eclipse.rse.core.subsystems.ISubSystemConfiguration, org.eclipse.jface.wizard.IWizard) */ public interface ISystemNewConnectionWizardPage extends IWizardPage { diff --git a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java index 07dac3af3ee..47cd0224697 100644 --- a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java +++ b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java @@ -180,7 +180,7 @@ public interface ISubSystemConfiguration extends ISystemFilterPoolManagerProvide */ public boolean supportsServerLaunchProperties(IHost host); /** - * If {@link #supportsServerLaunchProperties()} returns true, this method may be called by + * If {@link #supportsServerLaunchProperties(IHost)} returns true, this method may be called by * the server launcher to decide if a given remote server launch type is supported or not. *
We return true by default. * @see org.eclipse.rse.core.subsystems.ServerLaunchType @@ -357,7 +357,8 @@ public interface ISubSystemConfiguration extends ISystemFilterPoolManagerProvide * @param creatingConnection true if we are creating a connection, false if just creating * another subsystem for an existing connection. * @param yourNewConnectionWizardPages The wizard pages you supplied to the New Connection wizard, via the - * {@link #getNewConnectionWizardPages(IWizard)} method or null if you didn't override this method. + * {@link org.eclipse.rse.core.subsystems.util.ISubSystemConfigurationAdapter#getNewConnectionWizardPages(ISubSystemConfiguration, org.eclipse.jface.wizard.IWizard)} + * method or null if you didn't override this method. */ public ISubSystem createSubSystem(IHost conn, boolean creatingConnection, ISystemNewConnectionWizardPage[] yourNewConnectionWizardPages); @@ -369,8 +370,6 @@ public interface ISubSystemConfiguration extends ISystemFilterPoolManagerProvide /** * Find or create a connector service for this host - * @param host - * @return */ public IConnectorService getConnectorService(IHost host); @@ -379,7 +378,7 @@ public interface ISubSystemConfiguration extends ISystemFilterPoolManagerProvide * for a given subsystem. *

* Create an instance of ServerLauncher, and add it to the given subsystem. - * When a subsystem is created, and {@link #supportsServerLaunchProperties()} + * When a subsystem is created, and {@link #supportsServerLaunchProperties(IHost)} * returns true, this method is called to create the server launcher instance * associated with the subsystem. The default implementation is to create an * instance of {@link IRemoteServerLauncher}, but override to create your own @@ -403,12 +402,12 @@ public interface ISubSystemConfiguration extends ISystemFilterPoolManagerProvide public void updateSubSystem(Shell shell, ISubSystem subsystem, boolean updateUserId, String userId, boolean updatePort, int port); /** * Update the port for the given subsystem instance. - * Shortcut to {@link #updateSubSystem(Shell,ISubSystem,boolean,String,boolean,Integer)} + * Shortcut to {@link #updateSubSystem(Shell, ISubSystem, boolean, String, boolean, int)} */ public void setSubSystemPort(Shell shell, ISubSystem subsystem, int port); /** * Update the user ID for the given subsystem instance. - * Shortcut to {@link #updateSubSystem(Shell,ISubSystem,boolean,String,boolean,Integer)} + * Shortcut to {@link #updateSubSystem(Shell, ISubSystem, boolean, String, boolean, int)} */ public void setSubSystemUserId(Shell shell, ISubSystem subsystem, String userId);