[225509][api][breaking] RSE useractions API leaks non-API types (apply patch from Xuan Chen)

releng/org.eclipse.rse.build/maps/rse.map

@@ -12,7 +12,7 @@ feature@org.eclipse.rse.ssh=v20080505,:pserver:anonymous:none@dev.eclipse.org:/c
 feature@org.eclipse.rse.telnet=v20080411,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/features/org.eclipse.rse.telnet-feature
 feature@org.eclipse.rse.terminals=v20080505,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/features/org.eclipse.rse.terminals-feature
 feature@org.eclipse.rse.tests=v20080505,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/tests/org.eclipse.rse.tests-feature
-feature@org.eclipse.rse.useractions=v20080409,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/features/org.eclipse.rse.useractions-feature
+feature@org.eclipse.rse.useractions=v20080505,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/features/org.eclipse.rse.useractions-feature
 plugin@org.eclipse.dstore.core=v20080505,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/plugins/org.eclipse.dstore.core
 plugin@org.eclipse.dstore.doc.isv=v20080411,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/doc/org.eclipse.dstore.doc.isv
 plugin@org.eclipse.dstore.extra=v20080406,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/plugins/org.eclipse.dstore.extra
@@ -61,4 +61,4 @@ plugin@org.eclipse.rse.terminals.ui=v20080505,:pserver:anonymous:none@dev.eclips
 plugin@org.eclipse.rse.tests=v20080505,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/tests/org.eclipse.rse.tests
 plugin@org.eclipse.rse.tests.framework=v20080331,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/tests/org.eclipse.rse.tests.framework
 plugin@org.eclipse.rse.ui=v20080505,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/plugins/org.eclipse.rse.ui
-plugin@org.eclipse.rse.useractions=v20080409,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/plugins/org.eclipse.rse.useractions
+plugin@org.eclipse.rse.useractions=v20080505,:pserver:anonymous:none@dev.eclipse.org:/cvsroot/dsdp,,org.eclipse.tm.rse/plugins/org.eclipse.rse.useractions

rse/plugins/org.eclipse.rse.useractions/META-INF/MANIFEST.MF

@@ -21,6 +21,10 @@ Require-Bundle: org.eclipse.core.resources,
 Bundle-ActivationPolicy: lazy
 Eclipse-LazyStart: true
 Export-Package: org.eclipse.rse.internal.useractions;x-internal:=true,
+ org.eclipse.rse.internal.useractions.api.files.compile;x-internal:=true,
+ org.eclipse.rse.internal.useractions.api.files.uda;x-internal:=true,
+ org.eclipse.rse.internal.useractions.api.ui.compile;x-internal:=true,
+ org.eclipse.rse.internal.useractions.api.ui.uda;x-internal:=true,
  org.eclipse.rse.internal.useractions.files.compile;x-internal:=true,
  org.eclipse.rse.internal.useractions.files.uda;x-internal:=true,
  org.eclipse.rse.internal.useractions.ui;x-internal:=true,
@@ -28,10 +32,6 @@ Export-Package: org.eclipse.rse.internal.useractions;x-internal:=true,
  org.eclipse.rse.internal.useractions.ui.uda;x-internal:=true,
  org.eclipse.rse.internal.useractions.ui.uda.actions;x-internal:=true,
  org.eclipse.rse.internal.useractions.ui.uda.util;x-internal:=true,
- org.eclipse.rse.internal.useractions.ui.validators;x-internal:=true,
+ org.eclipse.rse.internal.useractions.ui.validators;x-internal:=true
- org.eclipse.rse.useractions.files.compile,
- org.eclipse.rse.useractions.files.uda,
- org.eclipse.rse.useractions.ui.compile,
- org.eclipse.rse.useractions.ui.uda
 Bundle-Vendor: %providerName
 Bundle-RequiredExecutionEnvironment: J2SE-1.4

rse/plugins/org.eclipse.rse.useractions/plugin.xml

@@ -7,7 +7,7 @@
      <menuContribution locationURI="popup:org.eclipse.rse.ui.view.systemView">
         <menu id="org.eclipse.rse.ui.useractions.compile.menu"
               label="%DynamicLabel.CompileActionNode">
-           <dynamic class="org.eclipse.rse.useractions.ui.compile.SystemDynamicCompileMenu"
+           <dynamic class="org.eclipse.rse.internal.useractions.api.ui.compile.SystemDynamicCompileMenu"
                      id="org.eclipse.ui.rse.ui.views.dynamiccompilemenu">
            </dynamic>
            <visibleWhen>
@@ -24,7 +24,7 @@
         </menu>
       	<menu id="org.eclipse.rse.ui.useractions.useraction.menu"
               label="%DynamicLabel.UserActionNode">
-           <dynamic class="org.eclipse.rse.useractions.ui.uda.SystemDynamicUserActionMenu"
+           <dynamic class="org.eclipse.rse.internal.useractions.api.ui.uda.SystemDynamicUserActionMenu"
                     id="org.eclipse.ui.rse.ui.views.dynamicuseractionmenu">
            </dynamic>
            <visibleWhen>

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/files/compile/ISystemCompileManagerAdapter.java

@@ -7,12 +7,20 @@
  * Contributors:
  * Xuan Chen (IBM) - [222470] initial contribution.
  *********************************************************************************/
-package org.eclipse.rse.useractions.files.compile;
+package org.eclipse.rse.internal.useractions.api.files.compile;
 
 import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
 import org.eclipse.rse.internal.useractions.ui.compile.SystemCompileManager;
 
-
+/**
+ * Compile Manager Adapter Interface.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
+ */
 public interface ISystemCompileManagerAdapter {
 
 	public SystemCompileManager getSystemCompileManager(ISubSystemConfiguration ssc);

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/files/compile/UniversalCompileManagerAdapter.java

@@ -7,7 +7,7 @@
  * Contributors:
  * Xuan Chen (IBM) - [222470] initial contribution.
  *********************************************************************************/
-package org.eclipse.rse.useractions.files.compile;
+package org.eclipse.rse.internal.useractions.api.files.compile;
 
 import java.util.HashMap;
 
@@ -15,6 +15,15 @@ import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
 import org.eclipse.rse.internal.useractions.files.compile.UniversalCompileManager;
 import org.eclipse.rse.internal.useractions.ui.compile.SystemCompileManager;
 
+/**
+ * Universal Compile Manager Adapter.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
+ */
 public class UniversalCompileManagerAdapter implements
 		ISystemCompileManagerAdapter {
 	private HashMap compileManagers = new HashMap();

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/files/uda/ISystemUDActionSubsystemAdapter.java

@@ -7,12 +7,21 @@
  * Contributors:
  * Xuan Chen (IBM) - [222470] initial contribution.
  *********************************************************************************/
-package org.eclipse.rse.useractions.files.uda;
+package org.eclipse.rse.internal.useractions.api.files.uda;
 
 import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
 import org.eclipse.rse.internal.useractions.ui.uda.SystemUDActionSubsystem;
 
 
+/**
+ * User-defined Action Subsystem Adapter Interface.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
+ */
 public interface ISystemUDActionSubsystemAdapter {
 
 	public SystemUDActionSubsystem getSystemUDActionSubsystem(ISubSystemConfiguration ssc);

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/files/uda/UniversalSystemUDActionSubsystemAdapter.java

@@ -7,7 +7,7 @@
  * Contributors:
  * Xuan Chen (IBM) - [222470] initial contribution.
  *********************************************************************************/
-package org.eclipse.rse.useractions.files.uda;
+package org.eclipse.rse.internal.useractions.api.files.uda;
 
 import java.util.HashMap;
 
@@ -15,6 +15,15 @@ import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
 import org.eclipse.rse.internal.useractions.files.uda.UDActionSubsystemUniversalFiles;
 import org.eclipse.rse.internal.useractions.ui.uda.SystemUDActionSubsystem;
 
+/**
+ * Universal User-defined Action Subsystem Adapter.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
+ */
 public class UniversalSystemUDActionSubsystemAdapter implements ISystemUDActionSubsystemAdapter {
 	private HashMap uDActionSubsystems = new HashMap();
 

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemCascadingCompileAction.java

@@ -9,7 +9,7 @@
  *     IBM Corporation - initial API and implementation
  * Martin Oberhuber (Wind River) - [186773] split ISystemRegistryUI from ISystemRegistry
  *******************************************************************************/
-package org.eclipse.rse.useractions.ui.compile;
+package org.eclipse.rse.internal.useractions.api.ui.compile;
 
 import org.eclipse.jface.action.IMenuListener;
 import org.eclipse.jface.action.IMenuManager;
@@ -28,6 +28,12 @@ import org.eclipse.swt.widgets.Shell;
 
 /**
  * Cascading Compile-> menu for remote compilable resources.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
  */
 public class SystemCascadingCompileAction extends SystemBaseSubMenuAction implements IMenuListener {
 	private boolean isPrompt;

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemCompileAction.java

@@ -11,7 +11,7 @@
  * David Dykstal (IBM) - [186589] move user actions API out of org.eclipse.rse.ui
  * David McKnight   (IBM)        - [225506] [api][breaking] RSE UI leaks non-API types
  *******************************************************************************/
-package org.eclipse.rse.useractions.ui.compile;
+package org.eclipse.rse.internal.useractions.api.ui.compile;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -38,8 +38,15 @@ import org.eclipse.ui.model.AdaptableList;
 import org.eclipse.ui.model.WorkbenchContentProvider;
 
 /**
- * This is the action for an individual compile command, either prompted or not prompted.
+ * This is the action for an individual compile command, either prompted or not
- * The label for the action is simply the compile command's label. If promptable, then "..." is appended.
+ * prompted. The label for the action is simply the compile command's label. If
+ * promptable, then "..." is appended.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
  */
 public class SystemCompileAction extends SystemBaseAction {
 	private SystemCompileCommand compileCmd;

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemDynamicCompileMenu.java

@@ -7,7 +7,7 @@
  * Contributors:
  * Xuan Chen (IBM) - [222470] initial contribution.
  *********************************************************************************/
-package org.eclipse.rse.useractions.ui.compile;
+package org.eclipse.rse.internal.useractions.api.ui.compile;
 
 import java.util.ArrayList;
 
@@ -22,6 +22,7 @@ import org.eclipse.rse.core.RSECorePlugin;
 import org.eclipse.rse.core.model.ISystemProfile;
 import org.eclipse.rse.core.subsystems.ISubSystem;
 import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
+import org.eclipse.rse.internal.useractions.api.files.compile.ISystemCompileManagerAdapter;
 import org.eclipse.rse.internal.useractions.files.compile.UniversalCompileManager;
 import org.eclipse.rse.internal.useractions.ui.compile.SystemCompileCommand;
 import org.eclipse.rse.internal.useractions.ui.compile.SystemCompileManager;
@@ -31,12 +32,20 @@ import org.eclipse.rse.subsystems.files.core.subsystems.IRemoteFile;
 import org.eclipse.rse.ui.SystemBasePlugin;
 import org.eclipse.rse.ui.view.ISystemRemoteElementAdapter;
 import org.eclipse.rse.ui.view.SystemAdapterHelpers;
-import org.eclipse.rse.useractions.files.compile.ISystemCompileManagerAdapter;
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.actions.CompoundContributionItem;
 
+/**
+ * Dynamic Compile Menu.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
+ */
 public class SystemDynamicCompileMenu extends CompoundContributionItem
 {
 	private class TestContribution extends ActionContributionItem {

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/ui/compile/SystemWorkWithCompileCommandsAction.java

@@ -12,7 +12,7 @@
  *                                API to the user actions plugin
  * Xuan Chen        (IBM)    - [225617] [useraction][api] Remove Team view support inside user action.
  *******************************************************************************/
-package org.eclipse.rse.useractions.ui.compile;
+package org.eclipse.rse.internal.useractions.api.ui.compile;
 
 import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.jface.dialogs.Dialog;
@@ -21,6 +21,7 @@ import org.eclipse.rse.core.model.ISystemProfile;
 import org.eclipse.rse.core.subsystems.ISubSystem;
 import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
 import org.eclipse.rse.internal.useractions.IUserActionsImageIds;
+import org.eclipse.rse.internal.useractions.api.files.compile.ISystemCompileManagerAdapter;
 import org.eclipse.rse.internal.useractions.files.compile.UniversalCompileManager;
 import org.eclipse.rse.internal.useractions.ui.compile.SystemCompileManager;
 import org.eclipse.rse.internal.useractions.ui.compile.SystemCompileProfile;
@@ -31,11 +32,16 @@ import org.eclipse.rse.ui.RSEUIPlugin;
 import org.eclipse.rse.ui.actions.SystemBaseDialogAction;
 import org.eclipse.rse.ui.view.ISystemRemoteElementAdapter;
 import org.eclipse.rse.ui.view.SystemAdapterHelpers;
-import org.eclipse.rse.useractions.files.compile.ISystemCompileManagerAdapter;
 import org.eclipse.swt.widgets.Shell;
 
 /**
  * The action that displays the Work With -> Compile Commands menu item
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
  */
 public class SystemWorkWithCompileCommandsAction extends SystemBaseDialogAction {
 

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/api/ui/uda/SystemDynamicUserActionMenu.java

@@ -7,7 +7,7 @@
  * Contributors:
  * Xuan Chen (IBM) - [222470] initial contribution.
  *********************************************************************************/
-package org.eclipse.rse.useractions.ui.uda;
+package org.eclipse.rse.internal.useractions.api.ui.uda;
 
 import java.util.ArrayList;
 
@@ -22,6 +22,7 @@ import org.eclipse.rse.core.RSECorePlugin;
 import org.eclipse.rse.core.model.ISystemProfile;
 import org.eclipse.rse.core.subsystems.ISubSystem;
 import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
+import org.eclipse.rse.internal.useractions.api.files.uda.ISystemUDActionSubsystemAdapter;
 import org.eclipse.rse.internal.useractions.files.uda.UDActionSubsystemUniversalFiles;
 import org.eclipse.rse.internal.useractions.ui.uda.SystemUDAResources;
 import org.eclipse.rse.internal.useractions.ui.uda.SystemUDActionSubsystem;
@@ -30,12 +31,20 @@ import org.eclipse.rse.subsystems.files.core.subsystems.IRemoteFile;
 import org.eclipse.rse.ui.SystemBasePlugin;
 import org.eclipse.rse.ui.view.ISystemRemoteElementAdapter;
 import org.eclipse.rse.ui.view.SystemAdapterHelpers;
-import org.eclipse.rse.useractions.files.uda.ISystemUDActionSubsystemAdapter;
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.actions.CompoundContributionItem;
 
+/**
+ * Dynamic User-defined Action Menu.
+ * <p>
+ * <strong>EXPERIMENTAL</strong>. This class or interface has been added as part
+ * of a work in progress. There is no guarantee that this API will work or that
+ * it will remain the same. Please do not use this API without consulting with
+ * the <a href="http://www.eclipse.org/dsdp/tm/">Target Management</a> team.
+ * </p>
+ */
 public class SystemDynamicUserActionMenu extends CompoundContributionItem
 {
 	private class UserActionContribution extends ActionContributionItem {

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/ui/compile/SystemCompileCascadeByProfileAction.java

@@ -20,6 +20,8 @@ import org.eclipse.rse.core.model.ISystemProfile;
 import org.eclipse.rse.core.subsystems.ISubSystem;
 import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
 import org.eclipse.rse.internal.ui.view.SystemViewMenuListener;
+import org.eclipse.rse.internal.useractions.api.files.compile.ISystemCompileManagerAdapter;
+import org.eclipse.rse.internal.useractions.api.ui.compile.SystemCompileAction;
 import org.eclipse.rse.ui.ISystemIconConstants;
 import org.eclipse.rse.ui.RSEUIPlugin;
 import org.eclipse.rse.ui.actions.ISystemViewMenuListener;
@@ -27,8 +29,6 @@ import org.eclipse.rse.ui.actions.SystemBaseDummyAction;
 import org.eclipse.rse.ui.actions.SystemBaseSubMenuAction;
 import org.eclipse.rse.ui.view.ISystemRemoteElementAdapter;
 import org.eclipse.rse.ui.view.SystemAdapterHelpers;
-import org.eclipse.rse.useractions.files.compile.ISystemCompileManagerAdapter;
-import org.eclipse.rse.useractions.ui.compile.SystemCompileAction;
 import org.eclipse.swt.widgets.Shell;
 
 /**

rse/plugins/org.eclipse.rse.useractions/src/org/eclipse/rse/internal/useractions/ui/compile/SystemCompileManager.java

@@ -25,6 +25,7 @@ import org.eclipse.rse.core.model.IHost;
 import org.eclipse.rse.core.model.ISystemProfile;
 import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
 import org.eclipse.rse.internal.useractions.UserActionsPersistenceUtil;
+import org.eclipse.rse.internal.useractions.api.ui.compile.SystemCascadingCompileAction;
 import org.eclipse.rse.internal.useractions.ui.SystemCmdSubstVarList;
 import org.eclipse.rse.internal.useractions.ui.uda.SystemUDAResources;
 import org.eclipse.rse.services.clientserver.messages.SystemMessage;
@@ -36,7 +37,6 @@ import org.eclipse.rse.ui.SystemMenuManager;
 import org.eclipse.rse.ui.messages.SystemMessageDialog;
 import org.eclipse.rse.ui.view.ISystemRemoteElementAdapter;
 import org.eclipse.rse.ui.view.SystemAdapterHelpers;
-import org.eclipse.rse.useractions.ui.compile.SystemCascadingCompileAction;
 import org.eclipse.swt.widgets.Shell;
 
 /**