From 9811767b6aa88f6a54724e9fa74454f516609892 Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Thu, 27 Oct 2022 15:33:41 -0400 Subject: [PATCH] Make ASTWriterTester abstract so it doesn't look like a test JDT thinks this is a test and will run it in the IDE and display an error. But it is only used to compose other tests, by making it abstract the IDE won't see it anymore. Part of #117 --- .../core/parser/tests/rewrite/astwriter/ASTWriterTester.java | 2 +- .../parser/tests/rewrite/astwriter/SourceRewriteTest.java | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/ASTWriterTester.java b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/ASTWriterTester.java index 5818791bef3..17b7480144e 100644 --- a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/ASTWriterTester.java +++ b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/ASTWriterTester.java @@ -46,7 +46,7 @@ import org.eclipse.core.resources.IFile; /** * @author Guido Zgraggen */ -public class ASTWriterTester extends RewriteBaseTest { +public abstract class ASTWriterTester extends RewriteBaseTest { private static final IParserLogService NULL_LOG = new NullLogService(); private IFile file; diff --git a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/SourceRewriteTest.java b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/SourceRewriteTest.java index bcccc29f09a..8e1333480f2 100644 --- a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/SourceRewriteTest.java +++ b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/rewrite/astwriter/SourceRewriteTest.java @@ -199,7 +199,10 @@ public class SourceRewriteTest extends TestSuite { } private static RewriteBaseTest createTestClass(String testName, ASTWriterTestSourceFile file) throws Exception { - ASTWriterTester test = new ASTWriterTester(testName, file); + ASTWriterTester test = new ASTWriterTester(testName, file) { + // ASTWriterTester is an abstract class so it doesn't + // look like a test, make it a concrete class here + }; TextSelection sel = file.getSelection(); if (sel != null) { test.setFileWithSelection(file.getName());