mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-23 14:42:11 +02:00
Code Issues Wiki Activity

Bug 525438 - Fix file path comparison in AbstractIndexAstChecker.getLineCommentsForLocation()

Browse source 
Using IPath.toPortableString() was causing a forward slash vs.
backward slash mismtach in the path comparison on Windows.

Change-Id: Ib3eb392065fb473f6b6e70cb1dcddceb34ae7240
This commit is contained in:
Nathan Ridge 2017-10-06 16:11:45 -04:00
parent f5c0094767
commit 9792a72dae
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
codan/org.eclipse.cdt.codan.core.cxx/src/org/eclipse/cdt/codan/core/cxx/model/AbstractIndexAstChecker.java
View file

@ -171,8 +171,7 @@ public abstract class AbstractIndexAstChecker extends AbstractCheckerWithProblem
for (IASTComment comm : commentsArray) { for (IASTComment comm : commentsArray) {
IASTFileLocation fileLocation = comm.getFileLocation(); IASTFileLocation fileLocation = comm.getFileLocation();
if (fileLocation.getStartingLineNumber() == loc.getLineNumber()) { if (fileLocation.getStartingLineNumber() == loc.getLineNumber()) {
//XXX check on windows portable or os? String problemFile = loc.getFile().getLocation().toOSString();
String problemFile = loc.getFile().getLocation().toPortableString();
String commentFile = fileLocation.getFileName(); String commentFile = fileLocation.getFileName();
if (problemFile.equals(commentFile)) { if (problemFile.equals(commentFile)) {
lineComments.add(comm); lineComments.add(comm);