mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-13 19:25:38 +02:00
Code Issues Wiki Activity

cleanup only: generics, loops to enhanced, spaces

Browse source
This commit is contained in:
Andrew Gvozdev 2009-09-19 17:07:33 +00:00
parent f953d3feb9
commit 96da536541
1 changed files with 124 additions and 133 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

121
build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/dataprovider/BuildEntryStorage.java
View file

@ -62,9 +62,9 @@ public class BuildEntryStorage extends AbstractEntryStorage {
private ICLanguageSettingEntry fEntry; private ICLanguageSettingEntry fEntry;
private OptionStringValue fOriginalValue; private OptionStringValue fOriginalValue;
private OptionStringValue fBsResolvedValue; private OptionStringValue fBsResolvedValue;
private List fSequense; private List<UserEntryInfo> fSequense;
UserEntryInfo(ICLanguageSettingEntry entry, OptionStringValue originalValue, OptionStringValue bsResolvedValue, List sequense){ UserEntryInfo(ICLanguageSettingEntry entry, OptionStringValue originalValue, OptionStringValue bsResolvedValue, List<UserEntryInfo> sequense){
fEntry = entry; fEntry = entry;
fOriginalValue = originalValue; fOriginalValue = originalValue;
fBsResolvedValue = bsResolvedValue; fBsResolvedValue = bsResolvedValue;
@ -90,6 +90,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
fLangData = lData; fLangData = lData;
} }
@Override
protected SettingsSet createEmptySettings() { protected SettingsSet createEmptySettings() {
SettingsSet settings = new SettingsSet(3); SettingsSet settings = new SettingsSet(3);
SettingLevel levels[] = settings.getLevels(); SettingLevel levels[] = settings.getLevels();
@ -125,6 +126,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
return fBuildDirName; return fBuildDirName;
} }
@Override
protected void obtainEntriesFromLevel(int levelNum, SettingLevel level) { protected void obtainEntriesFromLevel(int levelNum, SettingLevel level) {
switch(levelNum){ switch(levelNum){
case USER_ENTRIES_LEVEL: case USER_ENTRIES_LEVEL:
@ -139,7 +141,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
uei = new UserEntryInfo(infos[i].getEntry(), null, null, null); uei = new UserEntryInfo(infos[i].getEntry(), null, null, null);
userInfos[i] = uei; userInfos[i] = uei;
} }
setUserEntries(userInfos, (List)level.getContext()); setUserEntries(userInfos, (List<EmptyEntryInfo>)level.getContext());
setUserUndefinedStringSet(level.containsOverrideInfo() ? level.getOverrideSet() : null); setUserUndefinedStringSet(level.containsOverrideInfo() ? level.getOverrideSet() : null);
} }
break; break;
@ -147,31 +149,27 @@ public class BuildEntryStorage extends AbstractEntryStorage {
} }
private void restoreDefaults(){ private void restoreDefaults(){
IOption options[] = fLangData.getOptionsForKind(getKind());
ITool tool = fLangData.getTool(); ITool tool = fLangData.getTool();
for(int i = 0; i < options.length; i++){ for (IOption option : fLangData.getOptionsForKind(getKind())) {
IOption option = options[i];
if(option.getParent() == tool){ if(option.getParent() == tool){
tool.removeOption(option); tool.removeOption(option);
} }
} }
options = fLangData.getUndefOptionsForKind(getKind()); for (IOption option : fLangData.getUndefOptionsForKind(getKind())) {
for(int i = 0; i < options.length; i++){
IOption option = options[i];
if(option.getParent() == tool){ if(option.getParent() == tool){
tool.removeOption(option); tool.removeOption(option);
} }
} }
} }
@Override
protected void putEntriesToLevel(int levelNum, SettingLevel level) { protected void putEntriesToLevel(int levelNum, SettingLevel level) {
switch(levelNum){ switch(levelNum){
case USER_ENTRIES_LEVEL: case USER_ENTRIES_LEVEL:
List emptyEntryInfos = new ArrayList(); List<EmptyEntryInfo> emptyEntryInfos = new ArrayList<EmptyEntryInfo>();
UserEntryInfo[] userEntries = getUserEntries(level.getFlags(0), true, emptyEntryInfos); for (UserEntryInfo userEntry : getUserEntries(level.getFlags(0), true, emptyEntryInfos)) {
for(int i = 0; i < userEntries.length; i++){ level.addEntry(userEntry.fEntry, userEntry);
level.addEntry(userEntries[i].fEntry, userEntries[i]);
} }
level.addOverrideNameSet(getUserUndefinedStringSet()); level.addOverrideNameSet(getUserUndefinedStringSet());
if(emptyEntryInfos.size() != 0) if(emptyEntryInfos.size() != 0)
@ -211,19 +209,18 @@ public class BuildEntryStorage extends AbstractEntryStorage {
: new SupplierBasedCdtVariableSubstitutor(ci, "", " "); //$NON-NLS-1$ //$NON-NLS-2$ : new SupplierBasedCdtVariableSubstitutor(ci, "", " "); //$NON-NLS-1$ //$NON-NLS-2$
} }
private UserEntryInfo[] getUserEntries(int flags, boolean usr, List emptyValuesInfos){ private UserEntryInfo[] getUserEntries(int flags, boolean usr, List<EmptyEntryInfo> emptyValuesInfos){
IOption options[] = fLangData.getOptionsForKind(getKind()); IOption options[] = fLangData.getOptionsForKind(getKind());
if(options.length > 0){ if(options.length > 0){
List entryList = new ArrayList(); List<UserEntryInfo> entryList = new ArrayList<UserEntryInfo>();
for(int i = 0; i < options.length; i++){ for (IOption opt : options) {
Option option = (Option)options[i]; Option option = (Option)opt;
List list = usr ? (List)option.getExactValue() : option.getExactBuiltinsList(); List<OptionStringValue> list = usr ? (List<OptionStringValue>)option.getExactValue() : (List<OptionStringValue>)option.getExactBuiltinsList();
int size = list != null ? list.size() : 0; if(list != null){
if(size > 0){
SupplierBasedCdtVariableSubstitutor subst = createSubstitutor(option, false); SupplierBasedCdtVariableSubstitutor subst = createSubstitutor(option, false);
SupplierBasedCdtVariableSubstitutor bSVarsSubst = createSubstitutor(option, true); SupplierBasedCdtVariableSubstitutor bSVarsSubst = createSubstitutor(option, true);
for(int j = 0; j < size; j++){ for(int j = 0; j < list.size(); j++){
OptionStringValue ve = (OptionStringValue)list.get(j); OptionStringValue ve = list.get(j);
OptionStringValue[] rVes = resolve(ve, option, bSVarsSubst); OptionStringValue[] rVes = resolve(ve, option, bSVarsSubst);
if(rVes.length == 0){ if(rVes.length == 0){
if(emptyValuesInfos != null){ if(emptyValuesInfos != null){
@ -231,9 +228,8 @@ public class BuildEntryStorage extends AbstractEntryStorage {
} }
} else { } else {
boolean isMultiple = rVes.length > 1; boolean isMultiple = rVes.length > 1;
List sequense = isMultiple ? new ArrayList(rVes.length) : null; List<UserEntryInfo> sequense = isMultiple ? new ArrayList<UserEntryInfo>(rVes.length) : null;
for(int k = 0; k < rVes.length; k++){ for (OptionStringValue rVe : rVes) {
OptionStringValue rVe = rVes[k];
ICLanguageSettingEntry entry = createUserEntry(option, rVe, flags, subst); ICLanguageSettingEntry entry = createUserEntry(option, rVe, flags, subst);
entryList.add(new UserEntryInfo(entry, ve, rVe, sequense)); entryList.add(new UserEntryInfo(entry, ve, rVe, sequense));
} }
@ -242,7 +238,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
} }
} }
return (UserEntryInfo[])entryList.toArray(new UserEntryInfo[entryList.size()]); return entryList.toArray(new UserEntryInfo[entryList.size()]);
} }
return new UserEntryInfo[0]; return new UserEntryInfo[0];
} }
@ -269,18 +265,14 @@ public class BuildEntryStorage extends AbstractEntryStorage {
return new OptionStringValue(value, ov.isBuiltIn(), ov.getSourceAttachmentPath(), ov.getSourceAttachmentRootPath(), ov.getSourceAttachmentPrefixMapping()); return new OptionStringValue(value, ov.isBuiltIn(), ov.getSourceAttachmentPath(), ov.getSourceAttachmentRootPath(), ov.getSourceAttachmentPrefixMapping());
} }
private HashSet getUserUndefinedStringSet(){ private HashSet<String> getUserUndefinedStringSet(){
HashSet set = null; HashSet<String> set = null;
IOption options[] = fLangData.getUndefOptionsForKind(getKind()); for (IOption option : fLangData.getUndefOptionsForKind(getKind())) {
if(options.length > 0){ List<String> list = (List<String>)option.getValue();
for(int i = 0; i < options.length; i++){ if(list.size() != 0){
IOption option = options[i]; if(set == null)
List list = (List)option.getValue(); set = new HashSet<String>();
if(list.size() != 0){ set.addAll(list);
if(set == null)
set = new HashSet();
set.addAll(list);
}
} }
} }
return set; return set;
@ -346,12 +338,12 @@ public class BuildEntryStorage extends AbstractEntryStorage {
String paths[] = null; String paths[] = null;
int kind = getKind(); int kind = getKind();
switch(kind){ switch(kind){
case ICLanguageSettingEntry.INCLUDE_PATH:{ case ICSettingEntry.INCLUDE_PATH:{
IEnvironmentVariableProvider provider = ManagedBuildManager.getEnvironmentVariableProvider(); IEnvironmentVariableProvider provider = ManagedBuildManager.getEnvironmentVariableProvider();
paths = provider.getBuildPaths(fLangData.getConfiguration(), IEnvVarBuildPath.BUILDPATH_INCLUDE); paths = provider.getBuildPaths(fLangData.getConfiguration(), IEnvVarBuildPath.BUILDPATH_INCLUDE);
} }
break; break;
case ICLanguageSettingEntry.LIBRARY_PATH:{ case ICSettingEntry.LIBRARY_PATH:{
IEnvironmentVariableProvider provider = ManagedBuildManager.getEnvironmentVariableProvider(); IEnvironmentVariableProvider provider = ManagedBuildManager.getEnvironmentVariableProvider();
paths = provider.getBuildPaths(fLangData.getConfiguration(), IEnvVarBuildPath.BUILDPATH_LIBRARY); paths = provider.getBuildPaths(fLangData.getConfiguration(), IEnvVarBuildPath.BUILDPATH_LIBRARY);
} }
@ -369,7 +361,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
return new ICLanguageSettingEntry[0]; return new ICLanguageSettingEntry[0];
} }
private ICLanguageSettingEntry createUserEntry(Option option, OptionStringValue optionValue, int flags, SupplierBasedCdtVariableSubstitutor subst){ private ICLanguageSettingEntry createUserEntry(IOption option, OptionStringValue optionValue, int flags, SupplierBasedCdtVariableSubstitutor subst){
// private ICLanguageSettingEntry createUserEntry(Option option, String optionValue, int flags){ // private ICLanguageSettingEntry createUserEntry(Option option, String optionValue, int flags){
int kind = getKind(); int kind = getKind();
@ -378,18 +370,17 @@ public class BuildEntryStorage extends AbstractEntryStorage {
IPath srcPath = null, srcRootPath = null, srcPrefixMapping = null; IPath srcPath = null, srcRootPath = null, srcPrefixMapping = null;
switch (kind){ switch (kind){
case ICLanguageSettingEntry.MACRO: case ICSettingEntry.MACRO:
String nv[] = macroNameValueFromValue(optionValue.getValue()); String nv[] = macroNameValueFromValue(optionValue.getValue());
// String nv[] = macroNameValueFromValue(optionValue); // String nv[] = macroNameValueFromValue(optionValue);
entry = new CMacroEntry(nv[0], nv[1], flags); entry = new CMacroEntry(nv[0], nv[1], flags);
break; break;
// case ICLanguageSettingEntry.INCLUDE_PATH: // case ICSettingEntry.INCLUDE_PATH:
// case ICLanguageSettingEntry.INCLUDE_FILE: // case ICSettingEntry.INCLUDE_FILE:
// case ICLanguageSettingEntry.MACRO_FILE: // case ICSettingEntry.MACRO_FILE:
// case ICLanguageSettingEntry.LIBRARY_PATH: // case ICSettingEntry.LIBRARY_PATH:
// case ICLanguageSettingEntry.LIBRARY_FILE: case ICSettingEntry.LIBRARY_FILE:
case ICLanguageSettingEntry.LIBRARY_FILE:
String tmp = optionValue.getSourceAttachmentPath(); String tmp = optionValue.getSourceAttachmentPath();
if(tmp != null) if(tmp != null)
srcPath = new Path(tmp); srcPath = new Path(tmp);
@ -400,6 +391,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
if(tmp != null) if(tmp != null)
srcPrefixMapping = new Path(tmp); srcPrefixMapping = new Path(tmp);
//do not break //do not break
//$FALL-THROUGH$
default: default:
IOptionPathConverter optionPathConverter = fLangData.getTool().getOptionPathConverter(); IOptionPathConverter optionPathConverter = fLangData.getTool().getOptionPathConverter();
PathInfo pInfo = optionPathValueToEntry(optionValue.getValue(), subst); PathInfo pInfo = optionPathValueToEntry(optionValue.getValue(), subst);
@ -407,7 +399,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
// Object[] v = optionPathValueToEntry(optionValue); // Object[] v = optionPathValueToEntry(optionValue);
if(pInfo.isWorkspacePath()){ if(pInfo.isWorkspacePath()){
flags |= ICLanguageSettingEntry.VALUE_WORKSPACE_PATH; flags |= ICSettingEntry.VALUE_WORKSPACE_PATH;
} else if (optionPathConverter != null){ } else if (optionPathConverter != null){
IPath path = optionPathConverter.convertToPlatformLocation(pInfo.getUnresolvedPath(), option, fLangData.getTool()); IPath path = optionPathConverter.convertToPlatformLocation(pInfo.getUnresolvedPath(), option, fLangData.getTool());
if(path != null){ if(path != null){
@ -450,7 +442,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
private String entryValueToOptionStringValue(IOption option, ICLanguageSettingEntry entry, SupplierBasedCdtVariableSubstitutor subst){ private String entryValueToOptionStringValue(IOption option, ICLanguageSettingEntry entry, SupplierBasedCdtVariableSubstitutor subst){
String result; String result;
boolean checkQuote = true; boolean checkQuote = true;
if(entry.getKind() == ICLanguageSettingEntry.MACRO && entry.getValue().length() > 0){ if(entry.getKind() == ICSettingEntry.MACRO && entry.getValue().length() > 0){
result = new StringBuffer(entry.getName()).append('=').append(entry.getValue()).toString(); result = new StringBuffer(entry.getName()).append('=').append(entry.getValue()).toString();
} else if(entry instanceof ICLanguageSettingPathEntry){ } else if(entry instanceof ICLanguageSettingPathEntry){
IOptionPathConverter converter = fLangData.getTool().getOptionPathConverter(); IOptionPathConverter converter = fLangData.getTool().getOptionPathConverter();
@ -511,7 +503,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
boolean quoted = false; boolean quoted = false;
/* Check for spaces, backslashes or macros */ /* Check for spaces, backslashes or macros */
int i = pathName.indexOf(' ') + pathName.indexOf('\\') //$NON-NLS-1$ //$NON-NLS-2$ int i = pathName.indexOf(' ') + pathName.indexOf('\\')
+ pathName.indexOf("${"); //$NON-NLS-1$ + pathName.indexOf("${"); //$NON-NLS-1$
/* If indexof didn't fail all three times, double-quote path */ /* If indexof didn't fail all three times, double-quote path */
@ -563,7 +555,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
return new PathInfo(unresolvedStr, isWorkspacePath, subst); return new PathInfo(unresolvedStr, isWorkspacePath, subst);
} }
private void setUserEntries(UserEntryInfo[] entries, List emptyEntryInfos){ private void setUserEntries(UserEntryInfo[] entries, List<EmptyEntryInfo> emptyEntryInfos){
int kind = getKind(); int kind = getKind();
IOption options[] = fLangData.getOptionsForKind(kind); IOption options[] = fLangData.getOptionsForKind(kind);
if(options.length != 0){ if(options.length != 0){
@ -587,22 +579,21 @@ public class BuildEntryStorage extends AbstractEntryStorage {
ITool tool = fLangData.getTool(); ITool tool = fLangData.getTool();
IResourceInfo rcInfo = tool.getParentResourceInfo(); IResourceInfo rcInfo = tool.getParentResourceInfo();
IOption newOption = ManagedBuildManager.setOption(rcInfo, tool, option, optValue); IOption newOption = ManagedBuildManager.setOption(rcInfo, tool, option, optValue);
options = fLangData.getOptionsForKind(kind); for (IOption opt : fLangData.getOptionsForKind(kind)) {
for(int i = 0; i < options.length; i++){ if(opt != newOption)
if(options[i] != newOption) ManagedBuildManager.setOption(rcInfo, tool, opt, new String[0]);
ManagedBuildManager.setOption(rcInfo, tool, options[i], new String[0]);
} }
} }
} }
private UserEntryInfo[] addEmptyEntries(UserEntryInfo infos[], List emptyEntryInfos){ private UserEntryInfo[] addEmptyEntries(UserEntryInfo infos[], List<EmptyEntryInfo> emptyEntryInfos){
if(emptyEntryInfos == null || emptyEntryInfos.size() == 0) if(emptyEntryInfos == null || emptyEntryInfos.size() == 0)
return infos; return infos;
LinkedList list = new LinkedList(); LinkedList<UserEntryInfo> list = new LinkedList<UserEntryInfo>();
list.addAll(Arrays.asList(infos)); list.addAll(Arrays.asList(infos));
for(int i = 0; i < emptyEntryInfos.size(); i++){ for(int i = 0; i < emptyEntryInfos.size(); i++){
EmptyEntryInfo ei = (EmptyEntryInfo)emptyEntryInfos.get(i); EmptyEntryInfo ei = emptyEntryInfos.get(i);
int index = ei.fPosition; int index = ei.fPosition;
if(index > list.size()) if(index > list.size())
index = list.size(); index = list.size();
@ -610,14 +601,14 @@ public class BuildEntryStorage extends AbstractEntryStorage {
list.add(index, new UserEntryInfo(null, ei.fOriginalValue, ei.fOriginalValue, null)); list.add(index, new UserEntryInfo(null, ei.fOriginalValue, ei.fOriginalValue, null));
} }
return (UserEntryInfo[])list.toArray(new UserEntryInfo[list.size()]); return list.toArray(new UserEntryInfo[list.size()]);
} }
private UserEntryInfo[] combineSequenses(UserEntryInfo infos[]){ private UserEntryInfo[] combineSequenses(UserEntryInfo infos[]){
if(infos.length == 0) if(infos.length == 0)
return infos; return infos;
List list = new ArrayList(infos.length); List<UserEntryInfo> list = new ArrayList<UserEntryInfo>(infos.length);
for(int i = 0; i < infos.length; i++){ for(int i = 0; i < infos.length; i++){
UserEntryInfo info = infos[i]; UserEntryInfo info = infos[i];
@ -649,7 +640,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
list.add(info); list.add(info);
} }
return (UserEntryInfo[])list.toArray(new UserEntryInfo[list.size()]); return list.toArray(new UserEntryInfo[list.size()]);
} }
private static UserEntryInfo createDesecuencedEntry(UserEntryInfo info){ private static UserEntryInfo createDesecuencedEntry(UserEntryInfo info){
@ -662,7 +653,7 @@ public class BuildEntryStorage extends AbstractEntryStorage {
return new UserEntryInfo(info.fEntry, resolvedValue, resolvedValue, null); return new UserEntryInfo(info.fEntry, resolvedValue, resolvedValue, null);
} }
private void setUserUndefinedStringSet(Set set){ private void setUserUndefinedStringSet(Set<String> set){
int kind = getKind(); int kind = getKind();
IOption[] options = fLangData.getUndefOptionsForKind(kind); IOption[] options = fLangData.getUndefOptionsForKind(kind);
if(options.length != 0){ if(options.length != 0){
@ -675,8 +666,8 @@ public class BuildEntryStorage extends AbstractEntryStorage {
IResourceInfo rcInfo = tool.getParentResourceInfo(); IResourceInfo rcInfo = tool.getParentResourceInfo();
IOption newOption = ManagedBuildManager.setOption(rcInfo, tool, option, optValue); IOption newOption = ManagedBuildManager.setOption(rcInfo, tool, option, optValue);
options = fLangData.getUndefOptionsForKind(kind); options = fLangData.getUndefOptionsForKind(kind);
for(int i = 0; i < options.length; i++){ for (IOption opt : options) {
if(options[i] != newOption) if(opt != newOption)
ManagedBuildManager.setOption(rcInfo, tool, option, new String[0]); ManagedBuildManager.setOption(rcInfo, tool, option, new String[0]);
} }