1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-01 06:05:24 +02:00

Bug 337303: Refactor DisassemblyToggleBreakpointsTarget and DisassemblyToggleTracepointsTarget

This commit is contained in:
Mikhail Khodjaiants 2011-02-22 18:50:40 +00:00
parent 353b63daf9
commit 9684ae54d1
3 changed files with 216 additions and 250 deletions

View file

@ -10,143 +10,35 @@
*******************************************************************************/ *******************************************************************************/
package org.eclipse.cdt.dsf.gdb.internal.ui.breakpoints; package org.eclipse.cdt.dsf.gdb.internal.ui.breakpoints;
import java.net.URI;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import org.eclipse.cdt.core.IAddress; import org.eclipse.cdt.core.IAddress;
import org.eclipse.cdt.debug.core.CDIDebugModel; import org.eclipse.cdt.debug.core.CDIDebugModel;
import org.eclipse.cdt.debug.core.model.ICBreakpointType; import org.eclipse.cdt.debug.core.model.ICBreakpointType;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.DisassemblySelection; import org.eclipse.cdt.dsf.debug.ui.actions.AbstractDisassemblyBreakpointsTarget;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.IDisassemblyPart;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.IDisassemblySelection;
import org.eclipse.core.filesystem.URIUtil;
import org.eclipse.core.resources.IMarker;
import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.debug.core.DebugPlugin;
import org.eclipse.debug.core.model.IBreakpoint;
import org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension;
import org.eclipse.jface.text.BadLocationException;
import org.eclipse.jface.text.IDocument;
import org.eclipse.jface.text.ITextSelection;
import org.eclipse.jface.text.Position;
import org.eclipse.jface.text.source.IAnnotationModel;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.texteditor.SimpleMarkerAnnotation;
/** /**
* Toggle tracepoint target implementation for the disassembly part. * Toggle tracepoint target implementation for the disassembly part.
*/ */
public class DisassemblyToggleTracepointsTarget implements IToggleBreakpointsTargetExtension { public class DisassemblyToggleTracepointsTarget extends AbstractDisassemblyBreakpointsTarget {
public void toggleLineBreakpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
assert part instanceof IDisassemblyPart && selection instanceof ITextSelection;
if (!(selection instanceof IDisassemblySelection)) { /* (non-Javadoc)
selection = new DisassemblySelection((ITextSelection) selection, (IDisassemblyPart) part); * @see org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.AbstractDisassemblyBreakpointsTarget#createLineBreakpoint(java.lang.String, org.eclipse.core.resources.IResource, int)
}
IDisassemblySelection disassemblySelection = (IDisassemblySelection)selection;
int line = disassemblySelection.getStartLine();
IBreakpoint[] bp = getBreakpointsAtLine((IDisassemblyPart) part, line);
if (bp == null || bp.length == 0) {
insertBreakpoint(disassemblySelection);
} else {
for (int i = 0; i < bp.length; i++) {
bp[i].delete();
}
}
}
public boolean canToggleLineBreakpoints(IWorkbenchPart part, ISelection selection) {
return part instanceof IDisassemblyPart && selection instanceof ITextSelection;
}
public void toggleMethodBreakpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
}
public boolean canToggleMethodBreakpoints(IWorkbenchPart part, ISelection selection) {
return false;
}
public void toggleWatchpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
}
public boolean canToggleWatchpoints(IWorkbenchPart part, ISelection selection) {
return false;
}
/*
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension#canToggleBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/ */
public boolean canToggleBreakpoints(IWorkbenchPart part, ISelection selection) { @Override
return canToggleLineBreakpoints(part, selection); protected void createLineBreakpoint( String sourceHandle, IResource resource, int lineNumber ) throws CoreException {
} CDIDebugModel.createLineTracepoint( sourceHandle, resource, getBreakpointType(), lineNumber, true, 0, "", true ); //$NON-NLS-1$
/*
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension#toggleBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public void toggleBreakpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
toggleLineBreakpoints(part, selection);
} }
private IBreakpoint[] getBreakpointsAtLine(IDisassemblyPart part, int line) { /* (non-Javadoc)
List<IBreakpoint> breakpoints = new ArrayList<IBreakpoint>(); * @see org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.AbstractDisassemblyBreakpointsTarget#createAddressBreakpoint(org.eclipse.core.resources.IResource, org.eclipse.cdt.core.IAddress)
IAnnotationModel annotationModel = part.getTextViewer().getAnnotationModel(); */
IDocument document = part.getTextViewer().getDocument(); @Override
if (annotationModel != null) { protected void createAddressBreakpoint( IResource resource, IAddress address ) throws CoreException {
Iterator<?> iterator = annotationModel.getAnnotationIterator(); CDIDebugModel.createAddressTracepoint( null, null, resource, getBreakpointType(), -1, address, true, 0, "", true ); //$NON-NLS-1$
while (iterator.hasNext()) { }
Object object = iterator.next();
if (object instanceof SimpleMarkerAnnotation) { protected int getBreakpointType() {
SimpleMarkerAnnotation markerAnnotation = (SimpleMarkerAnnotation) object; return ICBreakpointType.REGULAR;
IMarker marker = markerAnnotation.getMarker();
try {
if (marker.isSubtypeOf(IBreakpoint.BREAKPOINT_MARKER)) {
Position position = annotationModel.getPosition(markerAnnotation);
int bpLine = document.getLineOfOffset(position.getOffset());
if (line == bpLine) {
IBreakpoint breakpoint = DebugPlugin.getDefault().getBreakpointManager().getBreakpoint(marker);
if (breakpoint != null) {
breakpoints.add(breakpoint);
}
}
}
} catch (CoreException e) {
} catch (BadLocationException e) {
}
}
}
}
IBreakpoint[] breakpointsArray = new IBreakpoint[breakpoints.size()];
return breakpoints.toArray(breakpointsArray );
} }
private void insertBreakpoint(IDisassemblySelection selection) throws CoreException {
IAddress address = selection.getStartAddress();
if (address == null) {
return;
}
URI fileUri = selection.getSourceLocationURI();
if (fileUri != null) {
String filePath = null;
IResource resource = selection.getSourceFile();
if (resource != null) {
final IPath location= resource.getLocation();
if (location == null) {
return;
}
filePath = location.toOSString();
} else {
resource = ResourcesPlugin.getWorkspace().getRoot();
filePath = URIUtil.toPath(fileUri).toOSString();
}
int srcLine = selection.getSourceLine();
CDIDebugModel.createLineTracepoint(filePath, resource, ICBreakpointType.REGULAR, srcLine + 1, true, 0, "", true); //$NON-NLS-1$
} else {
IResource resource = ResourcesPlugin.getWorkspace().getRoot();
CDIDebugModel.createAddressTracepoint(null, null, resource, ICBreakpointType.REGULAR, -1, address, true, 0, "", true); //$NON-NLS-1$
}
}
} }

View file

@ -10,143 +10,35 @@
*******************************************************************************/ *******************************************************************************/
package org.eclipse.cdt.dsf.debug.internal.ui; package org.eclipse.cdt.dsf.debug.internal.ui;
import java.net.URI;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import org.eclipse.cdt.core.IAddress; import org.eclipse.cdt.core.IAddress;
import org.eclipse.cdt.debug.core.CDIDebugModel; import org.eclipse.cdt.debug.core.CDIDebugModel;
import org.eclipse.cdt.debug.core.model.ICBreakpointType; import org.eclipse.cdt.debug.core.model.ICBreakpointType;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.DisassemblySelection; import org.eclipse.cdt.dsf.debug.ui.actions.AbstractDisassemblyBreakpointsTarget;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.IDisassemblyPart;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.IDisassemblySelection;
import org.eclipse.core.filesystem.URIUtil;
import org.eclipse.core.resources.IMarker;
import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.debug.core.DebugPlugin;
import org.eclipse.debug.core.model.IBreakpoint;
import org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension;
import org.eclipse.jface.text.BadLocationException;
import org.eclipse.jface.text.IDocument;
import org.eclipse.jface.text.ITextSelection;
import org.eclipse.jface.text.Position;
import org.eclipse.jface.text.source.IAnnotationModel;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.texteditor.SimpleMarkerAnnotation;
/** /**
* Toggle breakpoint target implementation for the disassembly part. * Toggle breakpoint target implementation for the disassembly part.
*/ */
public class DisassemblyToggleBreakpointsTarget implements IToggleBreakpointsTargetExtension { public class DisassemblyToggleBreakpointsTarget extends AbstractDisassemblyBreakpointsTarget {
public void toggleLineBreakpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
assert part instanceof IDisassemblyPart && selection instanceof ITextSelection;
if (!(selection instanceof IDisassemblySelection)) { /* (non-Javadoc)
selection = new DisassemblySelection((ITextSelection) selection, (IDisassemblyPart) part); * @see org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.AbstractDisassemblyBreakpointsTarget#createLineBreakpoint(java.lang.String, org.eclipse.core.resources.IResource, int)
}
IDisassemblySelection disassemblySelection = (IDisassemblySelection)selection;
int line = disassemblySelection.getStartLine();
IBreakpoint[] bp = getBreakpointsAtLine((IDisassemblyPart) part, line);
if (bp == null || bp.length == 0) {
insertBreakpoint(disassemblySelection);
} else {
for (int i = 0; i < bp.length; i++) {
bp[i].delete();
}
}
}
public boolean canToggleLineBreakpoints(IWorkbenchPart part, ISelection selection) {
return part instanceof IDisassemblyPart && selection instanceof ITextSelection;
}
public void toggleMethodBreakpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
}
public boolean canToggleMethodBreakpoints(IWorkbenchPart part, ISelection selection) {
return false;
}
public void toggleWatchpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
}
public boolean canToggleWatchpoints(IWorkbenchPart part, ISelection selection) {
return false;
}
/*
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension#canToggleBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/ */
public boolean canToggleBreakpoints(IWorkbenchPart part, ISelection selection) { @Override
return canToggleLineBreakpoints(part, selection); protected void createLineBreakpoint( String sourceHandle, IResource resource, int lineNumber ) throws CoreException {
} CDIDebugModel.createLineBreakpoint( sourceHandle, resource, getBreakpointType(), lineNumber, true, 0, "", true ); //$NON-NLS-1$
/*
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension#toggleBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public void toggleBreakpoints(IWorkbenchPart part, ISelection selection) throws CoreException {
toggleLineBreakpoints(part, selection);
} }
private IBreakpoint[] getBreakpointsAtLine(IDisassemblyPart part, int line) { /* (non-Javadoc)
List<IBreakpoint> breakpoints = new ArrayList<IBreakpoint>(); * @see org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.AbstractDisassemblyBreakpointsTarget#createAddressBreakpoint(org.eclipse.core.resources.IResource, org.eclipse.cdt.core.IAddress)
IAnnotationModel annotationModel = part.getTextViewer().getAnnotationModel(); */
IDocument document = part.getTextViewer().getDocument(); @Override
if (annotationModel != null) { protected void createAddressBreakpoint( IResource resource, IAddress address ) throws CoreException {
Iterator<?> iterator = annotationModel.getAnnotationIterator(); CDIDebugModel.createAddressBreakpoint( null, null, resource, getBreakpointType(), address, true, 0, "", true ); //$NON-NLS-1$
while (iterator.hasNext()) { }
Object object = iterator.next();
if (object instanceof SimpleMarkerAnnotation) { protected int getBreakpointType() {
SimpleMarkerAnnotation markerAnnotation = (SimpleMarkerAnnotation) object; return ICBreakpointType.REGULAR;
IMarker marker = markerAnnotation.getMarker();
try {
if (marker.isSubtypeOf(IBreakpoint.BREAKPOINT_MARKER)) {
Position position = annotationModel.getPosition(markerAnnotation);
int bpLine = document.getLineOfOffset(position.getOffset());
if (line == bpLine) {
IBreakpoint breakpoint = DebugPlugin.getDefault().getBreakpointManager().getBreakpoint(marker);
if (breakpoint != null) {
breakpoints.add(breakpoint);
}
}
}
} catch (CoreException e) {
} catch (BadLocationException e) {
}
}
}
}
IBreakpoint[] breakpointsArray = new IBreakpoint[breakpoints.size()];
return breakpoints.toArray(breakpointsArray );
} }
private void insertBreakpoint(IDisassemblySelection selection) throws CoreException {
IAddress address = selection.getStartAddress();
if (address == null) {
return;
}
URI fileUri = selection.getSourceLocationURI();
if (fileUri != null) {
String filePath = null;
IResource resource = selection.getSourceFile();
if (resource != null) {
final IPath location= resource.getLocation();
if (location == null) {
return;
}
filePath = location.toOSString();
} else {
resource = ResourcesPlugin.getWorkspace().getRoot();
filePath = URIUtil.toPath(fileUri).toOSString();
}
int srcLine = selection.getSourceLine();
CDIDebugModel.createLineBreakpoint(filePath, resource, ICBreakpointType.REGULAR, srcLine + 1, true, 0, "", true); //$NON-NLS-1$
} else {
IResource resource = ResourcesPlugin.getWorkspace().getRoot();
CDIDebugModel.createAddressBreakpoint(null, null, resource, ICBreakpointType.REGULAR, address, true, 0, "", true); //$NON-NLS-1$
}
}
} }

View file

@ -0,0 +1,182 @@
/*******************************************************************************
* Copyright (c) 2011 Mentor Graphics and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* Mentor Graphics - Initial API and implementation
*******************************************************************************/
package org.eclipse.cdt.dsf.debug.ui.actions;
import java.net.URI;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import org.eclipse.cdt.core.IAddress;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.DisassemblySelection;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.IDisassemblyPart;
import org.eclipse.cdt.dsf.debug.internal.ui.disassembly.provisional.IDisassemblySelection;
import org.eclipse.core.filesystem.URIUtil;
import org.eclipse.core.resources.IMarker;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.debug.core.DebugPlugin;
import org.eclipse.debug.core.model.IBreakpoint;
import org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension;
import org.eclipse.jface.text.BadLocationException;
import org.eclipse.jface.text.IDocument;
import org.eclipse.jface.text.ITextSelection;
import org.eclipse.jface.text.Position;
import org.eclipse.jface.text.source.IAnnotationModel;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.ui.IWorkbenchPart;
import org.eclipse.ui.texteditor.SimpleMarkerAnnotation;
/**
* Base class for toggle breakpoint targets for the disassembly part.
* @since 2.2
*/
public abstract class AbstractDisassemblyBreakpointsTarget implements IToggleBreakpointsTargetExtension {
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTarget#toggleLineBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public void toggleLineBreakpoints( IWorkbenchPart part, ISelection selection ) throws CoreException {
assert part instanceof IDisassemblyPart && selection instanceof ITextSelection;
if ( !(selection instanceof IDisassemblySelection) ) {
selection = new DisassemblySelection( (ITextSelection)selection, (IDisassemblyPart)part );
}
IDisassemblySelection disassemblySelection = (IDisassemblySelection)selection;
int line = disassemblySelection.getStartLine();
IBreakpoint[] bp = getBreakpointsAtLine( (IDisassemblyPart)part, line );
if ( bp == null || bp.length == 0 ) {
insertBreakpoint( disassemblySelection );
}
else {
for( int i = 0; i < bp.length; i++ ) {
bp[i].delete();
}
}
}
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTarget#canToggleLineBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public boolean canToggleLineBreakpoints( IWorkbenchPart part, ISelection selection ) {
return part instanceof IDisassemblyPart && selection instanceof ITextSelection;
}
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTarget#toggleMethodBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public void toggleMethodBreakpoints( IWorkbenchPart part, ISelection selection ) throws CoreException {
}
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTarget#canToggleMethodBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public boolean canToggleMethodBreakpoints( IWorkbenchPart part, ISelection selection ) {
return false;
}
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTarget#toggleWatchpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public void toggleWatchpoints( IWorkbenchPart part, ISelection selection ) throws CoreException {
}
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTarget#canToggleWatchpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public boolean canToggleWatchpoints( IWorkbenchPart part, ISelection selection ) {
return false;
}
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension#toggleBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public void toggleBreakpoints( IWorkbenchPart part, ISelection selection ) throws CoreException {
toggleLineBreakpoints( part, selection );
}
/* (non-Javadoc)
* @see org.eclipse.debug.ui.actions.IToggleBreakpointsTargetExtension#canToggleBreakpoints(org.eclipse.ui.IWorkbenchPart, org.eclipse.jface.viewers.ISelection)
*/
public boolean canToggleBreakpoints( IWorkbenchPart part, ISelection selection ) {
return canToggleLineBreakpoints( part, selection );
}
protected abstract void createLineBreakpoint( String sourceHandle, IResource resource, int lineNumber ) throws CoreException;
protected abstract void createAddressBreakpoint( IResource resource, IAddress address ) throws CoreException;
private IBreakpoint[] getBreakpointsAtLine( IDisassemblyPart part, int line ) {
List<IBreakpoint> breakpoints = new ArrayList<IBreakpoint>();
IAnnotationModel annotationModel = part.getTextViewer().getAnnotationModel();
IDocument document = part.getTextViewer().getDocument();
if ( annotationModel != null ) {
Iterator<?> iterator = annotationModel.getAnnotationIterator();
while( iterator.hasNext() ) {
Object object = iterator.next();
if ( object instanceof SimpleMarkerAnnotation ) {
SimpleMarkerAnnotation markerAnnotation = (SimpleMarkerAnnotation)object;
IMarker marker = markerAnnotation.getMarker();
try {
if ( marker.isSubtypeOf( IBreakpoint.BREAKPOINT_MARKER ) ) {
Position position = annotationModel.getPosition( markerAnnotation );
int bpLine = document.getLineOfOffset( position.getOffset() );
if ( line == bpLine ) {
IBreakpoint breakpoint = DebugPlugin.getDefault().getBreakpointManager().getBreakpoint( marker );
if ( breakpoint != null ) {
breakpoints.add( breakpoint );
}
}
}
}
catch( CoreException e ) {
}
catch( BadLocationException e ) {
}
}
}
}
IBreakpoint[] breakpointsArray = new IBreakpoint[breakpoints.size()];
return breakpoints.toArray( breakpointsArray );
}
private void insertBreakpoint( IDisassemblySelection selection ) throws CoreException {
IAddress address = selection.getStartAddress();
if ( address == null ) {
return;
}
URI fileUri = selection.getSourceLocationURI();
if ( fileUri != null ) {
String filePath = null;
IResource resource = selection.getSourceFile();
if ( resource != null ) {
final IPath location = resource.getLocation();
if ( location == null ) {
return;
}
filePath = location.toOSString();
}
else {
resource = ResourcesPlugin.getWorkspace().getRoot();
filePath = URIUtil.toPath( fileUri ).toOSString();
}
int srcLine = selection.getSourceLine();
createLineBreakpoint( filePath, resource, srcLine + 1 );
}
else {
IResource resource = ResourcesPlugin.getWorkspace().getRoot();
createAddressBreakpoint( resource, address );
}
}
}